Commit Graph

224 Commits

Author SHA1 Message Date
Alexander Nicolaysen Sørnes
917851fceb Fix naming of OutputEditor() to be outputEditor() 2007-01-17 03:18:49 +00:00
Alexander Nicolaysen Sørnes
c71697dc5b Rename downloadurl::editor to OutputEditor for better conformance with other classes 2007-01-16 04:25:56 +00:00
Alexander Nicolaysen Sørnes
af877bfc70 processForm needs to be passed the $aClean array 2007-01-06 01:08:35 +00:00
Alexander Nicolaysen Sørnes
52a155588c Add the ability to add download URLs to application versions. They are
displayed in the version view marked as 'free downloads'.  The links will
later be used to allow browsing of downloadable applications.
2007-01-05 05:20:05 +00:00
Chris Morgan
a1a41d6b87 Fix and enable input filtering through include/filter.php 2007-01-04 02:35:01 +00:00
Alexander Nicolaysen Sørnes
582ee561fc If the admin tries to view an application that does not exist, print an error
and exit instead of fetching useless data as though there actually was an
application.
2007-01-04 00:43:58 +00:00
Francois Gouget
41fce37200 Assorted spelling fixes 2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
b6c06391c3 If the admin has not modified the field for a personalized response to a
maintainer application, do not include it in the e-mail sent to the user.
2006-12-30 06:15:33 +00:00
Alexander Nicolaysen Sørnes
72a8cd48c1 Add some missing quotes to input tags, to prevent the variables from being
assigned garbage values. Also conform the affected tags to newer HTML standards.
2006-12-02 05:10:11 +00:00
Alexander Nicolaysen Sørnes
beed29012e Fix moving versions by having the move version form update the internal version variable and then call the
Version::update() method to perform the update.
2006-11-26 17:15:38 +00:00
EA Durbin
d526a2a504 Standardize the case of Bug class constructors 2006-09-06 01:43:30 +00:00
EA Durbin
d1c037e0ae Make the case of 'Version' match the case used in the constructor 2006-08-31 02:39:09 +00:00
EA Durbin
320b8c0d82 Make the case of 'Application' class match the case used to define the class. Php doesn't care but its a nice touch. 2006-08-30 22:27:07 +00:00
Chris Morgan
cef2aec209 Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
240a241a54 Use require() instead of include() because we can't operate properly if we can't find all listed include files 2006-07-21 04:24:59 +00:00
Chris Morgan
9364f5bc5a Rename include/distributions.php to include/distribution.php so the name of the file matches exactly the name
of the distribution class
2006-07-21 04:21:04 +00:00
Chris Morgan
0b9a5b4e94 Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Chris Morgan
04e7fa9906 Rename include/testResults.php to include/testData.php to match the name of the class
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
4db25a90ad Add a 'back' link at the top of the page. Switch to using html_back_link() to keep the displayed text
uniform, we were missing the '<<' before 'Back'
2006-07-11 03:39:18 +00:00
Chris Morgan
160f739da8 Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
5f4998194a Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Tony Lambregts
dab95ccdb1 Fix spelling of iPage in redirect 2006-07-09 22:57:44 +00:00
Chris Morgan
0a9f8cc155 Performance improvements to version and application classes. Reduce the amount of queries to
what is necessary during object creation.  The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Tony Lambregts
0cf64d78e0 Fix moving version to existing application, variable wasn't prefixed correctly 2006-07-08 22:45:40 +00:00
Chris Morgan
95cb27dc69 Fix variable naming in adminMaintainerQueue.php to match the current naming convention 2006-07-08 22:12:08 +00:00
Chris Morgan
763ad58bcf Move function in include/comment.php inside of the comment class. This lets us refer to
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
2092d65827 Fix incorrect include, should be 'bugs.php' not 'bug.php' 2006-07-08 19:03:38 +00:00
Chris Morgan
854df987c6 Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
e56e95d63a Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function 2006-07-07 16:44:41 +00:00
Chris Morgan
ea02b57c25 Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
3096e63828 Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c Remove unnecessary exit calls after redirect() and util_show_error_page() calls 2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f Prefix all GPC variables according to our coding standard 2006-07-06 17:27:54 +00:00
Chris Morgan
91b44a3733 Cleanup note editing. Improve previewing of notes during addition and editing. Rename note related
variables to have the proper prefix.
2006-06-30 19:48:33 +00:00
Chris Morgan
a72f31e11a Rename some variables to match our current naming scheme 2006-06-30 16:33:02 +00:00
Jonathan Ernst
6d019b918a Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php 2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc Clean up application and version classes. Move class related functions into the class as static member functions 2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e Cleanup User class. Move user related functions into class as static member functions 2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a Use query_parameters() in SQL select, update and delete statements to protect against
sql injection attacks
2006-06-27 19:16:27 +00:00
Jonathan Ernst
c138da9766 Html attributes and values are lowercase to be forward compatible with xhtml 2006-06-27 16:54:22 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
3a3ff401cc Fix case of 'Submit' to fix creating a new distribution 2006-06-23 05:03:03 +00:00
Chris Morgan
540a29cb5e Fix editing bundles, they've been broken since appdb was imported into cvs and we haven't noticed, ha 2006-06-23 03:42:08 +00:00
Chris Morgan
67550405c3 Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting. 2006-06-21 01:04:12 +00:00
EA Durbin
d8a459af17 Eliminate the use of the undefined testResult() class and correcting spelling of testData. 2006-06-20 23:00:01 +00:00
Tony Lambregts
ca3fca2e0a Fix up administrating app queue, add missing '[' 2006-06-18 04:22:43 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
a088778a85 Get rid of redundant include to fix adminCommentView.php 2006-06-14 14:57:23 +00:00
Tony Lambregts
42b6c87c7b Add a message to the app/version deletion email to clarify deletions due the app/version being moved 2006-04-27 01:44:57 +00:00