Alexander Nicolaysen Sørnes
dde9a6a19b
Add url::display and replace old link display code.
2007-01-18 02:28:21 +00:00
Alexander Nicolaysen Sørnes
917851fceb
Fix naming of OutputEditor() to be outputEditor()
2007-01-17 03:18:49 +00:00
Chris Morgan
b9c59f6361
Remove unused $iAppId parameter from monitor::find()
2007-01-10 01:25:18 +00:00
Alexander Nicolaysen Sørnes
52a155588c
Add the ability to add download URLs to application versions. They are
...
displayed in the version view marked as 'free downloads'. The links will
later be used to allow browsing of downloadable applications.
2007-01-05 05:20:05 +00:00
Chris Morgan
a1a41d6b87
Fix and enable input filtering through include/filter.php
2007-01-04 02:35:01 +00:00
Francois Gouget
41fce37200
Assorted spelling fixes
2006-12-31 19:39:41 +00:00
Alexander Nicolaysen Sørnes
18acb017cd
Add a page showing a user's queued submissions to the AppDB. This should be
...
quite useful for a user, and should also reduce the number of duplicate
submissions, as many users seem to think their submissions have been lost if
they are not accepted within a few hours.
2006-12-27 03:26:16 +00:00
Alexander Nicolaysen Sørnes
7638866df0
Make sure that a version without a maintainer rating is not displayed with the
...
colour of the previous version.
2006-12-09 15:56:56 +00:00
Alexander Nicolaysen Sørnes
9fd31b235d
Colourize the maintainer's rating and version fields with the appropriate
...
rating colours, both in the application and version view.
This should make it easier for users to identify working versions, and it also
prevents the maintainer's rating from being 'overshadowed' by the test
results.
2006-12-09 04:28:20 +00:00
Alexander Nicolaysen Sørnes
83e83e504f
Change the maintainer button from 'be a maintainer for this app' to 'be a
...
maintainer for this version', and change 'monitor version' to 'monitor
changes'. Add a 'title' entry to the <input> to provide mouseover help to the user.
2006-12-02 05:05:54 +00:00
Alexander Nicolaysen Sørnes
79582b050a
Quote output parameters used in <input> tags, otherwise empty variables will end up incorrectly pulling in the / from the end
...
of a <input /> tag
2006-12-01 02:55:09 +00:00
WineHQ
b858e2ba53
Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors.
2006-11-25 17:24:44 +00:00
WineHQ
e1333dd7fc
Include the real name of the user deleting, rejecting and accepting applications and versions
2006-11-22 01:41:36 +00:00
Chris Morgan
57b05023ed
Version::aBuglinkIds doesn't exist anymore, retrieve buglink ids with Version::get_buglink_ids() and use the returned ids
...
in Version::delete() in place of the class variable that no longer exists
2006-09-26 02:09:26 +00:00
EA Durbin
d526a2a504
Standardize the case of Bug class constructors
2006-09-06 01:43:30 +00:00
Chris Morgan
cef2aec209
Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
...
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
1bdc44a003
Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
...
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Tony Lambregts
ed2cbe739d
Stop allowing anonymous test results
2006-07-16 05:39:56 +00:00
Jonathan Ernst
a4e384604b
Fix missing reply text by renaming replyText to sReplyText
2006-07-13 18:54:10 +00:00
Chris Morgan
04e7fa9906
Rename include/testResults.php to include/testData.php to match the name of the class
...
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
069a51fba8
Clean up category class. Move category related functions into the class and remove now extranious
...
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
160f739da8
Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
...
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
0d8de67fd9
Eliminate redundant parameters from testData function
2006-07-10 15:42:00 +00:00
Chris Morgan
0a9f8cc155
Performance improvements to version and application classes. Reduce the amount of queries to
...
what is necessary during object creation. The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Chris Morgan
07e2dab8f8
Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want
...
classes to depend on $_REQUEST if possible
2006-07-08 22:10:56 +00:00
Chris Morgan
763ad58bcf
Move function in include/comment.php inside of the comment class. This lets us refer to
...
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e
Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
...
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
0a836dd574
class version uses testResults so include it in version.php
2006-07-07 19:22:33 +00:00
Chris Morgan
e56e95d63a
Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function
2006-07-07 16:44:41 +00:00
Jonathan Ernst
3096e63828
Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
...
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c
Remove unnecessary exit calls after redirect() and util_show_error_page() calls
2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Chris Morgan
91b44a3733
Cleanup note editing. Improve previewing of notes during addition and editing. Rename note related
...
variables to have the proper prefix.
2006-06-30 19:48:33 +00:00
Chris Morgan
a72f31e11a
Rename some variables to match our current naming scheme
2006-06-30 16:33:02 +00:00
Chris Morgan
5e1cb3f8a9
Cleanup note class, move display of notes into the class. External code creates and calls Note::show() to display the note.
2006-06-29 19:22:26 +00:00
Jonathan Ernst
6d019b918a
Rename errorpage() to util_show_error_page() and move util_show_error_page() into include/util.php
2006-06-29 16:13:35 +00:00
Chris Morgan
034ea689bc
Clean up application and version classes. Move class related functions into the class as static member functions
2006-06-29 16:07:19 +00:00
Chris Morgan
245a6b993e
Cleanup User class. Move user related functions into class as static member functions
2006-06-29 15:54:29 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
ac5b4b0a95
Warn if magic quotes is enabled and explain a bit about why we require that magic quotes
...
be disabled. Also remove all of the conditional code that was working around cases where
we had magic quotes enabled. We were only working around a small portion of cases where magic
quotes was affecting the appdb.
2006-06-26 00:44:44 +00:00
Chris Morgan
fb0f3b5dd3
Protect against sql injection attacks in sql INSERT statements
2006-06-24 04:20:32 +00:00
Chris Morgan
ce71a0d8ed
Fix case of $aClean['appId']. Fixes the bug of orphaning newly submitted versions
2006-06-20 22:58:58 +00:00
EA Durbin
f982c8459e
Filter all user input to reduce the security impact of manipulated data
2006-06-17 06:10:10 +00:00
EA Durbin
62de655d75
Fix typo
2006-06-06 18:53:00 +00:00
Tony Lambregts
a0db997fdf
Fix the display-approved_versions() function by switching the use of a '=' in an if() to a '=='
2006-04-26 15:11:00 +00:00
Chris Morgan
f3ddc43dd1
Print application names correctly when versions are deleted. $this->appId should have been
...
$this->iAppId.
2006-03-19 18:06:18 +00:00
Tony Lambregts
092487fe91
Cleanup email code
2006-02-22 02:20:02 +00:00
Tony Lambregts
602d15cdca
Fix deletion of test results when a version is deleted
2006-02-20 02:51:19 +00:00
Chris Morgan
e309c1b44a
Move html output of application and version into the application and version classes
2006-01-29 04:04:46 +00:00
Tony Lambregts
9afa15776e
Version class fixes. Let update() be silent if desired, get rid of redundant message in unqueue().
2006-01-28 23:06:07 +00:00