Alexander Nicolaysen Sørnes
fb20a7b546
testData: add preview support
2007-09-24 21:00:05 -04:00
Alexander Nicolaysen Sørnes
c90d271886
testData: Fix 'Show All Tests' button
2007-09-24 19:57:23 -04:00
Chris Morgan
5c91961d12
Php5 improvements to table code. Add some accessor methods to classes so we can make class variables private.
2007-09-18 21:22:43 -04:00
Chris Morgan
232e889344
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
testData: Make the distribution help text more relevant. It should reflect the current situation instead of being static.
2007-09-14 23:43:57 -04:00
Chris Morgan
2827e0654e
Alexander Nicolaysen Sørnes <alex@thehandofagony.com>
...
Let objectManager handle deletion and delete notification.
2007-09-14 23:02:12 -04:00
Alexander Nicolaysen Sørnes
faf7d9bb19
Add objectGetChildren() method to classes without child objects
2007-09-08 22:29:17 +00:00
Alexander Nicolaysen Sørnes
ee70aeaaa2
make_maintainer_rating_list() should return a string containing the html for the list. Update
...
users of make_maintainer_rating_list() to echo its return value.
2007-09-08 01:48:53 +00:00
Chris Morgan
6119246b51
Replace direct mysql_xxx() calls with query_xxx() calls. Replace calls to mysql_insert_id()
...
with calls specific to the appdb or bugzilla database. Fixes a bug where a call to
mysql_insert_id() can potentially retrieve an id from either the bugzilla or appdb database,
depending on whichever database was last opened by mysql_connect().
2007-08-03 23:27:25 +00:00
Chris Morgan
b94a2a392b
Convert from timestamp to datetime. Datetime is consistent between mysql 4.0x and newer
...
versions and is faster for date/time computations. Modify object creation methods to specify
any time fields that were previously updated with timestamp properties.
2007-07-31 23:48:22 +00:00
Chris Morgan
a7d8eb7e20
Clean up return values of testData::delete(), return false upon failure.
2007-07-31 03:07:39 +00:00
Chris Morgan
0e3472e1bf
objectGetHeader() should return a TableRow instance as this is closer to what the information
...
represents and is a much more useful form.
2007-07-31 01:51:40 +00:00
Alexander Nicolaysen Sørnes
b127c30f1c
Fix rating colors in testData table, set the class, not the style.
2007-07-24 14:45:23 +00:00
Edwin Smulders
023ece493b
Eliminate some php notices caused by use of uninitialized variables
2007-07-24 01:45:19 +00:00
Edwin Smulders
d0a45fe550
Switch to using $_SERVER variables from what appears to be deprecated super globals
2007-07-24 00:30:04 +00:00
Chris Morgan
087697376f
Fix testData submission where the tested version is missing due to switching from a function
...
that previously echoed data out to one that returns the string for the caller to optionally
echo. The lack of echoing meant the version list html wasn't being output.
2007-07-23 20:45:22 +00:00
Alexander Nicolaysen Sørnes
1678c38c25
Fix testData::objectGetEntriesCount() for queued maintainers. Same fix was applied to
...
testData::objectGetEntries()
2007-07-23 20:02:24 +00:00
Chris Morgan
2652e68d01
Programmatic table support. Enhances several tables with highlightable and clickable rows and
...
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Edwin Smulders
1fe90a6ed5
Queued test results shouldn't be visible to maintainers of an application family or version
...
that are themselves still queued. Add where condition that 'appMaintainers.queued = 'false''.
2007-07-21 23:58:06 +00:00
Chris Morgan
b5a41fba77
Add the long awaited 'maintainer notification' system. This system, running from the cron
...
cleanup scripts, will look for maintainers that have queued entries that the maintainer can
process. If the queued entries aren't processed for X days an email is sent. In X*2 days
another email is sent. After X*3 days the maintainer is stripped of their maintainership as
they aren't really maintaining the application anyway. The hope is that this system lets
maintainers know that they have pending queued entries to process to reduce the pressure on the
appdb admins to handled hundreds of queued entries.
2007-07-20 22:24:37 +00:00
Chris Morgan
9831c1f762
Application view should list the number of test results for each version, this lets the appdb
...
user see which versions have the most feedback
2007-07-11 02:38:09 +00:00
Alexander Nicolaysen Sørnes
97f598b45e
Add 'delete' link to enable deleting testData
2007-07-08 17:37:33 +00:00
Chris Morgan
62bfb16016
Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
...
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7
Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
...
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Chris Morgan
f5b8cb3e8b
Enable multi-page support for unqueued testData
2007-06-12 00:40:20 +00:00
Alexander Nicolaysen Sørnes
ffd812b8a6
Add multi-page control to list of un-queued testData
2007-06-12 00:02:41 +00:00
Chris Morgan
956186d1c1
Add 'View Test Results' entry to admin sidebar. Enable testData deletion so we can either edit
...
or delete a given test entry.
2007-06-11 23:51:29 +00:00
Chris Morgan
e16df1cad3
Add some guidance to the 'Tested release' selection for a testData submission since we've
...
removed a bunch of versions lately, including 'CVS'.
2007-06-11 02:53:57 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a
Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
...
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
2adec2d724
Sort testData by id
2007-06-10 00:14:03 +00:00
Chris Morgan
b59a1d0b1f
Add a column to the test data queue to indicate whether a test result is for a application version
...
that has maintainers. This lets admins defer processing test results to give appliction and version maintiners
a chance to do so.
2007-06-07 02:04:15 +00:00
Chris Morgan
8970888921
Add a comment to encourage test result submitters not to include crash data in their test
...
submissions.
2007-06-05 03:35:46 +00:00
Ben Hodgetts
2984070157
Add more detail to the test data submission page
2007-05-26 17:01:11 +00:00
Chris Morgan
25edd78c73
Layout improvements. Change default inner padding for html_frame_start() from 5 to 0, this
...
lets us eliminate the white spacing between frames and their contents. Add in a
div.default_container class that has a 5px padding to replace the now not present default
spacing.
2007-05-02 01:08:22 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b
Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
...
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
a7789c2a8d
Fix loading of 'Runs?' value in the testData form, otherwise the value is displayed as
...
though no value is set
2007-04-26 00:17:42 +00:00
Alexander Nicolaysen Sørnes
42ecaf6eef
Fix typo in testData::update() causing the new release info to be absent from the mail sent
2007-04-23 23:38:30 +00:00
Chris Morgan
886cdeafa3
Clean up the layout of the version and application pages and add some css classes to define
...
the formatting
2007-04-23 02:33:19 +00:00
Alexander Nicolaysen Sørnes
6b265f46fe
State what was changed in the e-mail when testData is updated
2007-04-22 19:38:48 +00:00
Alexander Nicolaysen Sørnes
fb4db22141
Fix testData/version::mustBeQueued()
2007-04-22 16:15:12 +00:00
Chris Morgan
af465791f7
Work around bug where submitting versions resulted in testData not being properly queued
2007-04-22 05:21:12 +00:00
Chris Morgan
e83b9b2d58
Fix test result issue with incorrect name causing an error when 'Limit to 5 tests' was
...
selected
2007-04-22 04:23:57 +00:00
Alexander Nicolaysen Sørnes
d5aabe4d17
More fixes and uses for objectManager's version/testData queues
2007-04-21 01:02:10 +00:00
Alexander Nicolaysen Sørnes
a8a4da643b
Make testData's objectGetEntries more consistent for rejected testData. Don't allow
...
maintainers to view rejected entries for the versions they maintain, but show them their own
rejected entries instead
2007-04-20 00:02:20 +00:00
Alexander Nicolaysen Sørnes
c43563eca6
Fix testData::create() permissions. Separate the cases where a user has edit rights from
...
when he has the right to unqueue items
2007-04-19 23:45:15 +00:00
Alexander Nicolaysen Sørnes
fbb784c2f5
Fix mails for updated test results. Pass the correct 'edit' parameter to
...
sendNotificationMail() and only send mail if the test data has been changed.
2007-04-17 23:28:10 +00:00
Alexander Nicolaysen Sørnes
46df59f063
Use objectManager for new test results
2007-04-16 23:10:08 +00:00
Alexander Nicolaysen Sørnes
169d7ca493
Use objectMakeUrl()/Link() in more places
2007-04-08 23:04:31 +00:00
Chris Morgan
4402ac64b1
Rename testData::get_test_for_versionid() to testData::getNewestTestIdFromVersionId() so the
...
name of the method better describes the value the method is returning
2007-04-01 22:34:33 +00:00
Alexander Nicolaysen Sørnes
fa442e0c8e
Fix testData::unQueue() emails by passing 'add' to ::mailSubmitter(). Previously 'unQueue'
...
was passed but testData::mailSubmitter() doesn't recognize this so likely the response email
had an empty subject
2007-04-01 16:49:28 +00:00
Alexander Nicolaysen Sørnes
c494af3eb5
Fix display of latest testData to exclude queued entries
2007-03-28 00:09:12 +00:00