Jonathan Ernst
a4e384604b
Fix missing reply text by renaming replyText to sReplyText
2006-07-13 18:54:10 +00:00
Chris Morgan
04e7fa9906
Rename include/testResults.php to include/testData.php to match the name of the class
...
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
916517e6f5
Ensure that session.gc_probability is 1 and set session.gc_divisor to something reasonable for a reasonably
...
heavily accessed site like appdb. This change solves the mystery of why we had millions of unexpired sessions
in session_list and should make the session_list cron cleanup job superfluous.
2006-07-11 20:35:43 +00:00
Jonathan Ernst
53ed5725b4
Stop copying variables, update comments
2006-07-11 19:26:14 +00:00
Chris Morgan
ec77d82734
Clean up variable naming in query_parameters()
2006-07-11 19:25:16 +00:00
Chris Morgan
069a51fba8
Clean up category class. Move category related functions into the class and remove now extranious
...
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
457f7cc34b
Move distribution related functions into distribution class and combine getNumberOfDistributions() and
...
getNumberOfQueuedDistributions() by passing in a $bQueued flag
2006-07-11 17:02:35 +00:00
Chris Morgan
9adf7e5592
Clean up appimage code removing a bunch of redundant code and removing a query for each image that is actually output
...
to the browser
2006-07-11 03:48:40 +00:00
Chris Morgan
1587e8d0b4
Remove unused lookupVendorName()
2006-07-11 03:47:00 +00:00
Chris Morgan
88dde93132
Speed up outputTopXRowAppsFromRating() by earlying out if we have enough applications to fill our required amount.
...
This saves a database query for each top X table. Also rename $num_apps to $iNum_apps
2006-07-11 03:41:57 +00:00
Chris Morgan
4db25a90ad
Add a 'back' link at the top of the page. Switch to using html_back_link() to keep the displayed text
...
uniform, we were missing the '<<' before 'Back'
2006-07-11 03:39:18 +00:00
Chris Morgan
160f739da8
Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
...
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
d831939a07
Fix case of sWebpage to let updating of application class information correctly update the applications web page.
2006-07-10 23:02:03 +00:00
Jeremy Newman
219b5ac09c
enable zlib output compression from PHP
2006-07-10 20:49:46 +00:00
Chris Morgan
d6f7ddd17b
appVersion table should have an index on appId field as we frequently query this table
...
using appId
2006-07-10 16:32:05 +00:00
Chris Morgan
0d8de67fd9
Eliminate redundant parameters from testData function
2006-07-10 15:42:00 +00:00
Chris Morgan
cd5a620d88
testData class cleanup. Move some test related functions into the class as
...
static functions. Clean up some variable names.
2006-07-10 15:39:21 +00:00
Chris Morgan
5f4998194a
Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
...
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Tony Lambregts
6405eeafa4
Show tested rating and use its color when displaying the list of test results
2006-07-10 03:46:48 +00:00
Tony Lambregts
43a49d462a
Fix editing of a users administrative rights
2006-07-10 02:21:47 +00:00
Tony Lambregts
5b1d16da69
Require include/application.php to get the name of the application for email
2006-07-09 22:59:42 +00:00
Tony Lambregts
dab95ccdb1
Fix spelling of iPage in redirect
2006-07-09 22:57:44 +00:00
Tony Lambregts
9a52b37760
Fix a comment
2006-07-09 22:56:14 +00:00
Tony Lambregts
77170ab9dd
Sort test results by rating
2006-07-09 06:08:00 +00:00
Chris Morgan
97c96b2448
Fix commentview.php, missed an instance of view_app_comments() -> Comment::view_app_comments()
2006-07-09 01:36:17 +00:00
Chris Morgan
0a9f8cc155
Performance improvements to version and application classes. Reduce the amount of queries to
...
what is necessary during object creation. The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Chris Morgan
d06cba3977
appimage should use the image sUrl instead of the iId when trying to stat() the file. We can't always be sure
...
that the iId will be the name of the file
2006-07-09 00:39:43 +00:00
Tony Lambregts
0cf64d78e0
Fix moving version to existing application, variable wasn't prefixed correctly
2006-07-08 22:45:40 +00:00
Chris Morgan
95cb27dc69
Fix variable naming in adminMaintainerQueue.php to match the current naming convention
2006-07-08 22:12:08 +00:00
Chris Morgan
07e2dab8f8
Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want
...
classes to depend on $_REQUEST if possible
2006-07-08 22:10:56 +00:00
Chris Morgan
763ad58bcf
Move function in include/comment.php inside of the comment class. This lets us refer to
...
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e
Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
...
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
4708101f01
Add cron cleanup function to purge expired sessions from session_list table
2006-07-08 21:49:49 +00:00
Tony Lambregts
edcbd98b9e
Fix backward compatibility for bug ids. bug_id from bugzilla is the bug number not the internal buglinkid
2006-07-08 19:05:28 +00:00
Chris Morgan
2092d65827
Fix incorrect include, should be 'bugs.php' not 'bug.php'
2006-07-08 19:03:38 +00:00
Chris Morgan
88817c58b6
Revert test result filtering changes until we can figure out how to deal with xinha variable names
...
that don't match our internal ones
2006-07-08 05:02:22 +00:00
Chris Morgan
84d3f076f7
Variable is $iAppId, not $appId
2006-07-07 19:24:33 +00:00
Chris Morgan
e9456af9d5
application::display() should use the class internal iAppId instead of any $_REQUEST data
2006-07-07 19:23:58 +00:00
Chris Morgan
0a836dd574
class version uses testResults so include it in version.php
2006-07-07 19:22:33 +00:00
Chris Morgan
8303433f3b
Revert filtering changes in appview.php as they impact all of the classes downstream that haven't been updated
2006-07-07 18:50:45 +00:00
Chris Morgan
3c1d3a795b
Stop using global variables. Reorder functions so we don't have functions in the middle of
...
executing code. Rename a couple of variables to match our current naming convention
2006-07-07 18:18:09 +00:00
Chris Morgan
854df987c6
Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
...
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
64c1681e43
Fix another missed variable, 'create' to 'sCreate' to allow new users to be created
2006-07-07 18:03:42 +00:00
Jonathan Ernst
2d4ecadc6b
Enable filtering in votestats.php
2006-07-07 17:57:12 +00:00
Jonathan Ernst
1066c87d6c
Enable filtering in viewbugs.php
2006-07-07 17:55:27 +00:00
Jonathan Ernst
bdc6063b32
Enable filtering in viewScreenshots.php
2006-07-07 17:54:51 +00:00
Chris Morgan
b47070737c
Fix page changing that uses display_page_range(). Switch 'page' to 'iPage' and rename variables in
...
display_page_range() to use our current naming convention
2006-07-07 17:45:22 +00:00
Jonathan Ernst
76701cf530
Enable filtering in vendorview.php
2006-07-07 17:35:26 +00:00
Chris Morgan
8b579bc715
Use Version::showList() instead of ShowVersionList()
2006-07-07 17:27:23 +00:00
Chris Morgan
85b4981a30
Revert filtering in appsubmit, this requires a TON of other changes and we'll want to wait until
...
every other change goes in before appling this change
2006-07-07 17:24:57 +00:00