Chris Morgan
8bdf80982f
Fix table name case difference 'Appversion' -> 'appVersion' that was breaking a query
2006-07-16 17:37:23 +00:00
Chris Morgan
0b9a5b4e94
Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
...
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Tony Lambregts
ed2cbe739d
Stop allowing anonymous test results
2006-07-16 05:39:56 +00:00
Chris Morgan
ed0c692744
Exclude GPC values that start with 'Dialog', these are used by Xinha and we don't want to modify that code. Also exclude
...
PHPSESSID, this is a convenience for developers as php uses this key for its default session management and we really don't
mind if it is defined or not as we use our own session handlers
2006-07-15 05:16:37 +00:00
Tony Lambregts
e1711a2cdb
Show additional comments when viewing test data in application version
2006-07-14 01:48:46 +00:00
Tony Lambregts
ccbb2a14fc
Include link to app and version when displaying a list of test results
2006-07-14 01:32:04 +00:00
Jonathan Ernst
a4e384604b
Fix missing reply text by renaming replyText to sReplyText
2006-07-13 18:54:10 +00:00
Chris Morgan
04e7fa9906
Rename include/testResults.php to include/testData.php to match the name of the class
...
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
ec77d82734
Clean up variable naming in query_parameters()
2006-07-11 19:25:16 +00:00
Chris Morgan
069a51fba8
Clean up category class. Move category related functions into the class and remove now extranious
...
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
457f7cc34b
Move distribution related functions into distribution class and combine getNumberOfDistributions() and
...
getNumberOfQueuedDistributions() by passing in a $bQueued flag
2006-07-11 17:02:35 +00:00
Chris Morgan
1587e8d0b4
Remove unused lookupVendorName()
2006-07-11 03:47:00 +00:00
Chris Morgan
88dde93132
Speed up outputTopXRowAppsFromRating() by earlying out if we have enough applications to fill our required amount.
...
This saves a database query for each top X table. Also rename $num_apps to $iNum_apps
2006-07-11 03:41:57 +00:00
Chris Morgan
160f739da8
Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
...
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
d831939a07
Fix case of sWebpage to let updating of application class information correctly update the applications web page.
2006-07-10 23:02:03 +00:00
Chris Morgan
0d8de67fd9
Eliminate redundant parameters from testData function
2006-07-10 15:42:00 +00:00
Chris Morgan
cd5a620d88
testData class cleanup. Move some test related functions into the class as
...
static functions. Clean up some variable names.
2006-07-10 15:39:21 +00:00
Chris Morgan
5f4998194a
Screenshot class optimization. Defer creation of thumbnail and screenshot images until values are necessary.
...
This greatly speeds up the loading of the main page as we create screenshot objects to check their other internal
parameters and not output their images.
2006-07-10 15:18:08 +00:00
Tony Lambregts
6405eeafa4
Show tested rating and use its color when displaying the list of test results
2006-07-10 03:46:48 +00:00
Tony Lambregts
43a49d462a
Fix editing of a users administrative rights
2006-07-10 02:21:47 +00:00
Tony Lambregts
5b1d16da69
Require include/application.php to get the name of the application for email
2006-07-09 22:59:42 +00:00
Tony Lambregts
77170ab9dd
Sort test results by rating
2006-07-09 06:08:00 +00:00
Chris Morgan
0a9f8cc155
Performance improvements to version and application classes. Reduce the amount of queries to
...
what is necessary during object creation. The only use of all but one of the arrays we were fetching
during version and application construction was in ::delete() so we can just retrieve them there.
Speed screenshot class up by only querying for necessary columns, not select *
2006-07-09 00:48:33 +00:00
Chris Morgan
07e2dab8f8
Pass $iTestingId into Version::display() instead of reading it from $_REQUEST. We don't want
...
classes to depend on $_REQUEST if possible
2006-07-08 22:10:56 +00:00
Chris Morgan
763ad58bcf
Move function in include/comment.php inside of the comment class. This lets us refer to
...
these functions like Comment:: making it clear they are static functions of the comment class
2006-07-08 22:09:14 +00:00
Chris Morgan
f05c05864e
Pass input arrays into GetOutputEditoValues() and CheckOutputEditorInput(). We don't want
...
classes to be hardcoded to read directly from $_REQUEST
2006-07-08 22:06:28 +00:00
Chris Morgan
4708101f01
Add cron cleanup function to purge expired sessions from session_list table
2006-07-08 21:49:49 +00:00
Tony Lambregts
edcbd98b9e
Fix backward compatibility for bug ids. bug_id from bugzilla is the bug number not the internal buglinkid
2006-07-08 19:05:28 +00:00
Chris Morgan
e9456af9d5
application::display() should use the class internal iAppId instead of any $_REQUEST data
2006-07-07 19:23:58 +00:00
Chris Morgan
0a836dd574
class version uses testResults so include it in version.php
2006-07-07 19:22:33 +00:00
Chris Morgan
854df987c6
Clean up includes. Make 'path.php' and 'incl.php' required includes. Switch to using
...
require_once() for including files in /include so we can have include/*.php files include
their own dependencies rather than figuring out that to include A.php we need to include B.php
2006-07-07 18:14:53 +00:00
Chris Morgan
64c1681e43
Fix another missed variable, 'create' to 'sCreate' to allow new users to be created
2006-07-07 18:03:42 +00:00
Chris Morgan
b47070737c
Fix page changing that uses display_page_range(). Switch 'page' to 'iPage' and rename variables in
...
display_page_range() to use our current naming convention
2006-07-07 17:45:22 +00:00
Chris Morgan
e56e95d63a
Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function
2006-07-07 16:44:41 +00:00
Jonathan Ernst
89915be4f1
Add an option to prevent filtering of cookies in the case where multiple web apps are hosted
...
on the same virtualhost
2006-07-07 16:39:27 +00:00
Jonathan Ernst
aefbc1bf90
Fix showing of full size screenshots
2006-07-07 16:25:43 +00:00
Jonathan Ernst
3062bd4a99
Fix a comment in category.php
2006-07-07 16:24:33 +00:00
Chris Morgan
41597c9a79
Rename login to sLogin for upcoming filter changes to account.php
2006-07-07 16:16:19 +00:00
Jonathan Ernst
8048e97846
Empty numeric values should default to 0
2006-07-07 16:01:26 +00:00
Chris Morgan
427262a5c2
Fix account creation. Change cmd to sCmd like the account.php code expects
2006-07-07 15:45:48 +00:00
Jonathan Ernst
3be08453e7
$_REQUEST['mode'] backwards compatibility
2006-07-07 15:39:41 +00:00
Tony Lambregts
675a47f491
filter_gpc() should ignore any bugzilla parameters to avoid errors when these cookies are set
2006-07-07 04:49:32 +00:00
Chris Morgan
e817def053
Add backwards compatibility code to copy old style $_REQUEST variables to the new style
...
to allow old appdb urls in emails, in bugzilla and from google to continue working
2006-07-07 02:36:34 +00:00
Chris Morgan
445fbdfdd3
Switch a few more variables over to the new naming scheme, fix deleting comments and replying to comments
2006-07-06 23:49:51 +00:00
Chris Morgan
3d6da668a1
Remove require_once("mail.php") that was causing mail.php to be duplicately included. A cleaner fix is necessary
2006-07-06 22:35:01 +00:00
Chris Morgan
ea02b57c25
Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
...
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Jonathan Ernst
3096e63828
Rename util_show_error_page() to util_show_error_page_and_exit() and redirect() to util_redirect_and_exit()
...
so it is explicit that we exit in those functions that so we know it isn't necessary to put an exit after
we call them
2006-07-06 18:44:56 +00:00
Jonathan Ernst
54c484de8c
Remove unnecessary exit calls after redirect() and util_show_error_page() calls
2006-07-06 17:59:52 +00:00
Jonathan Ernst
735a2bc65f
Prefix all GPC variables according to our coding standard
2006-07-06 17:27:54 +00:00
Chris Morgan
adeb1adbdc
session::destroy() should call session_destroy() only if a session exists
2006-07-06 05:00:38 +00:00