Chris Morgan
f08ae29f58
Split maintainer::notifyMaintainerOfQueuedData() into two parts.
...
maintainer::fetchNotificationUpdate() that retrieves much of the email to the maintainer and
the target notification level, and maintainer::processNotificationUpdate() that acts on the
target notification level and completes and optionally sends the email to the maintainer. Add
admin/maintainerNotification.php to aid in debugging the notification system.
2007-07-21 23:49:36 +00:00
Chris Morgan
b5a41fba77
Add the long awaited 'maintainer notification' system. This system, running from the cron
...
cleanup scripts, will look for maintainers that have queued entries that the maintainer can
process. If the queued entries aren't processed for X days an email is sent. In X*2 days
another email is sent. After X*3 days the maintainer is stripped of their maintainership as
they aren't really maintaining the application anyway. The hope is that this system lets
maintainers know that they have pending queued entries to process to reduce the pressure on the
appdb admins to handled hundreds of queued entries.
2007-07-20 22:24:37 +00:00
Chris Morgan
62bfb16016
Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
...
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7
Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
...
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Alexander Nicolaysen Sørnes
f7b24fab9a
Object constructors shouldn't require an id if passed a $oRow object. Gets rid of
...
objectGetInstanceFromRow() since we can pass the row into the constructor instead.
2007-06-10 18:51:33 +00:00
Alexander Nicolaysen Sørnes
f4b7f2bd04
Don't display supermaintainers twice on maintainer processing screen. When printing the list of
...
non-super maintainers, only print the entry if the user is not a super maintainer
2007-05-13 16:54:33 +00:00
Alexander Nicolaysen Sørnes
11ecfa230b
Add allowAnonymousSubmissions(). objectManager checks the return value of this new function and
...
exists with an error during certain actions if the user is not logged in and the function returns
false
2007-04-29 23:00:01 +00:00
Alexander Nicolaysen Sørnes
59d97b676d
Display user name in the maintainer approval form
2007-04-21 18:23:11 +00:00
Alexander Nicolaysen Sørnes
b584fe1df7
Fix maintainer listing for versions. getMaintainersForAppIdVersionId() did not check that
...
additional entries had a superMaintainer = 1 so a maintainer of one version would be listed
as the maintainer for all versions of the application. Correct that issue and update the
unit test.
2007-04-16 23:19:44 +00:00
Alexander Nicolaysen Sørnes
169d7ca493
Use objectMakeUrl()/Link() in more places
2007-04-08 23:04:31 +00:00
Alexander Nicolaysen Sørnes
6b9abce52c
Avoid overlapping maintainer entries. When a user becomes a super maintainer of an
...
application remove all of their maintainer entries for the application versions. Update unit
tests to test maintainter overlapping.
2007-04-01 00:08:12 +00:00
Alexander Nicolaysen Sørnes
a93bcb6ffe
maintainer::deleteMaintainersForVersion() should properly return $hResult
2007-03-25 20:29:58 +00:00
Alexander Nicolaysen Sørnes
b57a9f516c
Add links to maintainer::objectOutputTableRow()
2007-03-25 03:54:07 +00:00
Alexander Nicolaysen Sørnes
c545581571
objectManager, add rejection support. Add support in objectManager for handling rejected
...
data.
2007-03-24 18:30:16 +00:00
Alexander Nicolaysen Sørnes
ed7026be6e
Let objectManager output table headers. A class returns an array of header cells and then
...
the objectManager adds an edit column if appropriate.
2007-03-17 21:04:43 +00:00
Alexander Nicolaysen Sørnes
75e6320a51
Show links in maintainer processing form
2007-03-17 19:39:29 +00:00
Alexander Nicolaysen Sørnes
4d5b566a78
Fix maintainer::objectGetEntries(). Remove UNION SELECT and properly check for application
...
queue status for un-queued maintainers
2007-03-17 00:51:20 +00:00
Alexander Nicolaysen Sørnes
641e1c32f6
Test objectGetEntries() in the objectManager tests
2007-03-17 00:50:10 +00:00
Alexander Nicolaysen Sørnes
9ef6268fa6
Let objectManager label the edit link in objectOutputTableRow() because the edit link text
...
depends on the queue state
2007-03-13 21:08:39 +00:00
WineHQ
43ac9708ca
Authors: Alexander Nicolaysen Sørnes <alex@thehandofagony.com>, Chris Morgan <cmorgan@alum.wpi.edu>
...
Fix queued maintainer sql with missing join causing millions of rows to be generated by a
relatively simple sql statement
2007-03-11 20:39:02 +00:00
Alexander Nicolaysen Sørnes
f12a5ded10
Include supermaintainers in getMaintainersForAppIdVersionId()
2007-03-10 03:35:06 +00:00
Alexander Nicolaysen Sørnes
bf7daaa789
Let ObjectManager handle maintainer requests
2007-03-04 23:22:57 +00:00
Alexander Nicolaysen Sørnes
83164089ae
Disallowid of 0 in deleteMaintainersForVersion(). Add a unit test to ensure that
...
deleteMaintainersForVersion() behaves properly.
2007-01-24 04:10:05 +00:00
Alexander Nicolaysen Sørnes
a81ce02877
Allow maintainer requests on version submission
2007-01-20 17:41:43 +00:00
Alexander Nicolaysen Sørnes
917851fceb
Fix naming of OutputEditor() to be outputEditor()
2007-01-17 03:18:49 +00:00
Alexander Nicolaysen Sørnes
87cb1627e5
Add a URL to the application/version and a few line breaks.
2006-12-30 06:13:46 +00:00
Alexander Nicolaysen Sørnes
8786673db6
Allow the user to tick a checkbox upon application submission, indication
...
whether he would like to become a super maintainer of the application. The
request is processed along with the application. Also add a unit test that
tests maintainer requests submitted along with an application.
2006-12-09 05:07:25 +00:00
Alexander Nicolaysen Sørnes
cc7f3d3bc3
Auto-accept a maintainer request if the user has sufficient privileges.
2006-12-09 04:34:07 +00:00
WineHQ
9643c80288
Authors: Alexander Nicolaysen Sørnes <alex@thehandofagony.com>, Chris Morgan <cmorgan@alum.wpi.edu>
...
Make sure that a maintainer entry is not deleted incorrectly in Maintainer::unQueue(). If
a request has already been accepted, it is not a duplicate. Add a unit test to test the behavior of Maintainer::unQueue() on
an already unqueued maintainer.
2006-12-03 16:26:38 +00:00
WineHQ
b858e2ba53
Unit tests should run with E_ALL so we can detect all errors. Fix dozens of errors that popped up after enabling all errors.
2006-11-25 17:24:44 +00:00
EA Durbin
369639c1f1
Require user.php as the user class is called from within maintainer.php
2006-09-01 02:23:24 +00:00
EA Durbin
ced455be5b
Include 'version.php' and 'application.php' in maintainer.php as we new version and application objects in this class.
...
Fixes bug 5981.
2006-08-21 18:57:44 +00:00
Chris Morgan
8248346630
Simplify maintainer::getMaintainersForAppIdVersionId() query to be the same as the query used prior to the maintainer
...
changes. Fixes display of loads of maintainers due to permutations in a join that wasn't properly defined
2006-07-27 16:38:59 +00:00
Chris Morgan
cef2aec209
Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
...
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
0b9a5b4e94
Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
...
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Chris Morgan
e56e95d63a
Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup callers of this function
2006-07-07 16:44:41 +00:00
Chris Morgan
ea02b57c25
Move getAppsFromUserId() to user::getAppsMaintained(). Also implement a unit test for
...
user::getAppsMaintained()
2006-07-06 22:08:37 +00:00
Chris Morgan
e3f9e5371a
Use query_parameters() in SQL select, update and delete statements to protect against
...
sql injection attacks
2006-06-27 19:16:27 +00:00
Chris Morgan
67550405c3
Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting.
2006-06-21 01:04:12 +00:00
Chris Morgan
82c3000190
Sort applications that the user maintains alphabetically
2005-08-25 02:26:18 +00:00
Chris Morgan
1570a91d9d
getMaintainersUserIdsFromAppIdVersionId() shouldn't return all supermaintainers when passed a versionId of 0
2005-08-13 01:45:42 +00:00
Chris Morgan
3269785131
Fix comment
2005-06-05 18:33:01 +00:00
Jonathan Ernst
7d2505777f
Show supermaintainers names in version's page
2005-02-17 01:01:01 +00:00
Jonathan Ernst
dcf7c819a4
- replaced mysql_query with appdb_query
...
- fixed mysql query in include/session.php
2005-01-08 18:24:55 +00:00
Jonathan Ernst
d3d9e853d9
- replaced tons of tabs with spaces
...
- replaced <? with <?php for compatibility sake (see TODO and CODING_STANDARD to know more)
- improved overall code lisibility
2004-12-12 03:51:51 +00:00
Chris Morgan
3fa8a3bd7a
Add support for application wide maintainers, super maintainers, that are
...
maintainers for all versions of a particular application.
2004-12-10 00:18:01 +00:00
Chris Morgan
c81eebd949
add support for application maintainers
2004-11-09 22:41:18 +00:00