Commit Graph

761 Commits

Author SHA1 Message Date
Chris Morgan
fd448b96d7 Fix appData objectGetTableRow() to work with the new table classes 2007-07-23 20:30:57 +00:00
Edwin Smulders
477c5efb72 Fix a   that had a missing ; in the page selector code 2007-07-23 20:15:21 +00:00
Alexander Nicolaysen Sørnes
1678c38c25 Fix testData::objectGetEntriesCount() for queued maintainers. Same fix was applied to
testData::objectGetEntries()
2007-07-23 20:02:24 +00:00
Chris Morgan
2652e68d01 Programmatic table support. Enhances several tables with highlightable and clickable rows and
cleans up the existing table row highlight and click code.
2007-07-23 19:56:43 +00:00
Edwin Smulders
8c2959494d Hide RESOLVED and CLOSED bugs unless we are displaying all bugs. 2007-07-22 00:49:15 +00:00
Edwin Smulders
1fe90a6ed5 Queued test results shouldn't be visible to maintainers of an application family or version
that are themselves still queued. Add where condition that 'appMaintainers.queued = 'false''.
2007-07-21 23:58:06 +00:00
Chris Morgan
f08ae29f58 Split maintainer::notifyMaintainerOfQueuedData() into two parts.
maintainer::fetchNotificationUpdate() that retrieves much of the email to the maintainer and
the target notification level, and maintainer::processNotificationUpdate() that acts on the
target notification level and completes and optionally sends the email to the maintainer. Add
admin/maintainerNotification.php to aid in debugging the notification system.
2007-07-21 23:49:36 +00:00
Edwin Smulders
5a5383515c Hide resolved bugs by default, add link to toggle between hiding resolved bugs and showing all
bugs.
2007-07-21 23:32:10 +00:00
Chris Morgan
b5a41fba77 Add the long awaited 'maintainer notification' system. This system, running from the cron
cleanup scripts, will look for maintainers that have queued entries that the maintainer can
process. If the queued entries aren't processed for X days an email is sent. In X*2 days
another email is sent. After X*3 days the maintainer is stripped of their maintainership as
they aren't really maintaining the application anyway. The hope is that this system lets
maintainers know that they have pending queued entries to process to reduce the pressure on the
appdb admins to handled hundreds of queued entries.
2007-07-20 22:24:37 +00:00
Chris Morgan
b0cecaf9d5 objectManager::display_table() should exit out only if the user isn't logged in AND the table
is a queue
2007-07-16 03:04:54 +00:00
Chris Morgan
88a832199d Implement browsing of newest apps in the object manager infrastructure 2007-07-16 03:04:07 +00:00
Chris Morgan
7c76ba42eb Color versions when displaying the version table on the application page. Add dynamic
highlighting and the ability to click on the row in the version table.
2007-07-12 23:58:00 +00:00
Chris Morgan
15c57e937b Place the 'AppDB' link at the top of the global menu, users may use it to return back to the
main page of the AppDB and having it be the second link makes it more difficult to locate
2007-07-11 02:41:58 +00:00
Chris Morgan
9831c1f762 Application view should list the number of test results for each version, this lets the appdb
user see which versions have the most feedback
2007-07-11 02:38:09 +00:00
Alexander Nicolaysen Sørnes
97f598b45e Add 'delete' link to enable deleting testData 2007-07-08 17:37:33 +00:00
Alexander Nicolaysen Sørnes
e9b7740aa2 Fix email messageboxes to be on multiple lines again. The email array passed to addmsg() must
be space-separated.
2007-07-06 01:24:09 +00:00
Chris Morgan
232c3bda40 Add a suggestion to users that are receiving filter errors to clear out their cookies. 2007-07-05 21:49:17 +00:00
Alexander Nicolaysen Sørnes
53c0a0b393 Make mail_appdb() send mail with Bcc and only appdb-noreply@winehq.org as the recipient. 2007-07-02 01:09:16 +00:00
Alexander Nicolaysen Sørnes
403e052a8c Display login link when processing queues. Display a login link when processing queues and the
user isn't logged in, rather than saying that there are no entries.
2007-07-02 01:07:09 +00:00
Alexander Nicolaysen Sørnes
e93f09b0ad Check for valid result resource before number of rows. objectGetEntries() may return FALSE if
the user does not have permission to view a queue, for instance.
2007-07-02 00:50:32 +00:00
Chris Morgan
62bfb16016 Make objectGetTableRow() return a TableRow class instance. Added accessors to set the
appropriate parameters in the TableRow class. Removed some unused parameters from the TableRow
class.
2007-07-02 00:35:17 +00:00
Chris Morgan
15cd979264 Exclude 'XinhaColorPicker' get/post/cookie variable from normal filtering. Fixes a bug where
using the color picker resulted in an appdb error message until the cookie was removed.
2007-06-29 02:20:11 +00:00
Alexander Nicolaysen Sørnes
52c0e75af9 Don't display editor for non-existent entries 2007-06-19 00:29:37 +00:00
Alexander Nicolaysen Sørnes
d99f705863 Delete all objects in version_queue::delete() 2007-06-19 00:28:49 +00:00
Alexander Nicolaysen Sørnes
e6b09f417f testData_queue: always delete empty distributions if we can 2007-06-19 00:28:01 +00:00
Alexander Nicolaysen Sørnes
051a1e5d0c Cleanup objectManager tests so all objects created during the test are deleted 2007-06-19 00:26:21 +00:00
Chris Morgan
6221e9b921 Cleanup make_bugzilla_version_list(). Use standard naming convention, add some documentation.
Add a work around so a selected version, if not present, is added to the list and selected.
This fixes the issue where editing an older test result leaves us in an unattainable position,
we can't select the version since it was pruned from the list and we don't want to pick the
wrong version for the results.
2007-06-17 22:44:47 +00:00
Chris Morgan
a8df90b23d Remove duplicate 'Appdb home' entry. Shorten the names of a few other entries 2007-06-17 22:10:30 +00:00
Alexander Nicolaysen Sørnes
3abcfefe00 Encode the sReturnTo argument to the login page, otherwise we may have problems with some urls 2007-06-17 16:59:42 +00:00
Alexander Nicolaysen Sørnes
bdca7c3bac distribution: Fix empty submitter notification email. Pass the correct argument to
mailSubmitter()
2007-06-16 17:02:25 +00:00
Alexander Nicolaysen Sørnes
b9588ab76e Store iPage in handleMultiPageControls(). Fixes the case where an iPage would not be set for
page 1, causing iItemsPerPage value to be ignored when returning from data processing
2007-06-16 17:00:57 +00:00
Chris Morgan
80ca144225 Fix a typo in the common response text. 2007-06-16 16:58:54 +00:00
Chris Morgan
a41b65c25e Remove duplicate and unused sDate variables from application and version classes 2007-06-16 04:55:34 +00:00
Chris Morgan
00ccd7b18b Fix subject of database error log email sent during cron maintenance 2007-06-16 03:35:05 +00:00
Alexander Nicolaysen Sørnes
dd5edba2ed Hide the maintainer box if the user supermaintains the application 2007-06-15 23:54:50 +00:00
Alexander Nicolaysen Sørnes
c5e1b08b5d Preserve current url when logging in. Pass the current url as part of the url to the login form
so we can return the user to the starting url after login.
2007-06-15 23:40:21 +00:00
Alexander Nicolaysen Sørnes
5e7a75584a Remember multipage values when processing entries 2007-06-15 04:10:42 +00:00
Chris Morgan
4078ad879f Add some common responses to the entry processing page, selectable via radio buttons. This
should make admin responses more consistent and make it quicker and easier to process
submissions.
2007-06-14 01:27:59 +00:00
Alexander Nicolaysen Sørnes
ca8e4f56df Fix admin response in submitter notifications. Some code was in the wrong place inside of a
switch statement
2007-06-14 00:52:57 +00:00
Alexander Nicolaysen Sørnes
fc03cb827f Display the help text for application queues 2007-06-14 00:51:21 +00:00
Alexander Nicolaysen Sørnes
cd198f44d7 Replace objectOutputTableRow() with objectGetTableRow(). Redesign the table output mechanism so
that we fetch a table row from a class instead of letting the class display it. Move adding of
edit/delete links from the classes to the objectManager. Fix a hole in the distribution class
where an uninitialized variable could have been used in the constructor.
2007-06-14 00:50:35 +00:00
Chris Morgan
46f4f20ce6 Fix minor indenting issue 2007-06-13 03:13:06 +00:00
Chris Morgan
945df6a78c Fix incorrect member variable, its $bIsQueue, not $bIsQueued. Fixes the number of items on a
multi-page queue
2007-06-12 01:28:59 +00:00
Chris Morgan
f5b8cb3e8b Enable multi-page support for unqueued testData 2007-06-12 00:40:20 +00:00
Chris Morgan
f6a4905d77 Pass a valid $iPageRange into display_page_range(), otherwise display_page_range() behaves
improperly
2007-06-12 00:36:29 +00:00
Alexander Nicolaysen Sørnes
ffd812b8a6 Add multi-page control to list of un-queued testData 2007-06-12 00:02:41 +00:00
Chris Morgan
956186d1c1 Add 'View Test Results' entry to admin sidebar. Enable testData deletion so we can either edit
or delete a given test entry.
2007-06-11 23:51:29 +00:00
Alexander Nicolaysen Sørnes
65a77980c7 Fix type in appData::objectGetEntries() 2007-06-11 23:20:55 +00:00
Chris Morgan
59ed94fc54 Add a couple of comments and braces 2007-06-11 04:06:06 +00:00
Chris Morgan
e16df1cad3 Add some guidance to the 'Tested release' selection for a testData submission since we've
removed a bunch of versions lately, including 'CVS'.
2007-06-11 02:53:57 +00:00