EA Durbin
ced455be5b
Include 'version.php' and 'application.php' in maintainer.php as we new version and application objects in this class.
...
Fixes bug 5981.
2006-08-21 18:57:44 +00:00
Alexander Nicolaysen Sørnes
d5a00e576f
Create distributions table in create_tables script
2006-07-30 02:53:35 +00:00
Alexander Nicolaysen Sørnes
2351a6ff8c
Create table statement has a semi-colon where it should have a comma
2006-07-30 02:52:46 +00:00
Alexander Nicolaysen Sørnes
98f1ff0453
Fix some text in the test results form
2006-07-29 04:08:14 +00:00
Chris Morgan
8248346630
Simplify maintainer::getMaintainersForAppIdVersionId() query to be the same as the query used prior to the maintainer
...
changes. Fixes display of loads of maintainers due to permutations in a join that wasn't properly defined
2006-07-27 16:38:59 +00:00
Chris Morgan
61d338abbd
Comment::grab_comments() should use $iParentId when != NULL, not just !$iParentId as this prevents the use of
...
$iParentId in cases where the value is 0. Fixes duplicate display of every comment for an application version reported by
Nick Law.
2006-07-26 19:30:11 +00:00
Chris Morgan
cef2aec209
Start to move maintainer related functions into maintainer class and separate maintainer related queries and logic from
...
display code. Also move maintainer related code from the user class. Fix up unit tests to work with the new maintainer class.
2006-07-24 16:20:40 +00:00
Chris Morgan
25cf0a827f
Darken up the top X highlighting to make it more visible
2006-07-24 15:55:56 +00:00
Chris Morgan
4b380d37b3
Add a subtle highlight when mouse is over top X rows to provide better feedback to users that they may click anywhere
...
in the row to visit the application version. Add underlining to the text in the test results table to provide similar
feedback.
2006-07-21 19:18:10 +00:00
Chris Morgan
c726511204
Make table rows clickable using javascript. Use this functionality in the top X lists and in the test results table
2006-07-21 04:34:58 +00:00
Chris Morgan
f73d9c0283
Shift magnifying glass icon 10px left to put it near the corner of the thumbnail it is overlaying
2006-07-21 04:27:01 +00:00
Chris Morgan
240a241a54
Use require() instead of include() because we can't operate properly if we can't find all listed include files
2006-07-21 04:24:59 +00:00
Chris Morgan
9364f5bc5a
Rename include/distributions.php to include/distribution.php so the name of the file matches exactly the name
...
of the distribution class
2006-07-21 04:21:04 +00:00
Chris Morgan
1bdc44a003
Add a magnifying glass image overlay on top of screenshot thumbnails to make it more obvious to users that clicking on the
...
image will allow them to see a larger version of the thumbnail
2006-07-21 04:18:28 +00:00
Chris Morgan
3f1bfd3685
Attempt to capture the source of erroneous input to grab_comments() using error_log::logBackTrace()
2006-07-20 03:52:02 +00:00
Chris Morgan
34594b6eb4
Add logBackTrace() call to error_log class so we can determine code flow during error logging
2006-07-20 03:50:47 +00:00
Chris Morgan
f7763bdbfa
Clean up variable naming in grab_comments() , use null instead of -1 for parent ID
2006-07-20 03:19:23 +00:00
Chris Morgan
311081fda5
Handle mysql transaction deadlocks more gracefully by making multiple attempts when they occur
2006-07-19 19:20:16 +00:00
Chris Morgan
55065a254c
Add mysql_errno() output to error logging
2006-07-19 17:34:59 +00:00
Chris Morgan
3697e8b9c4
Swap error logging and addmsg() calls as addmsg() performs a database transaction and will clear out any error that
...
we wanted to report when error logging and calling mysql_error()
2006-07-19 17:18:16 +00:00
Chris Morgan
a651a3cdf3
Modify query_error() to log errors to a database table instead of displaying them on the screen. This should
...
let us more easily debug difficult or intermittent issues that users may not report. Add a cron to report logged
errors to appdb admins every night. Implement some basic unit tests for the new error logging code
2006-07-19 16:37:54 +00:00
Chris Morgan
2976ff9833
Fix centering of screenshot images on application/version pages
2006-07-19 00:54:56 +00:00
Chris Morgan
2ef31edf05
Fix voting(again) by changing all variables to use the new naming scheme
2006-07-19 00:11:40 +00:00
Chris Morgan
71f963b04c
Remove some unused functions from html.php
2006-07-19 00:11:11 +00:00
Jonathan Ernst
3a61131ffd
Trim 's' and 'sh' variables in filter.php so we correctly convert variable values with spaces into "" strings
2006-07-18 02:42:57 +00:00
Chris Morgan
0019810922
Rename include/db.php to include/query.php, all of the functions in db.php were named query_*(). Rename test_db.php to
...
test_query.php to match the rename of include/db.php. Modify include/incl.php to include query.php instead of db.php
2006-07-17 20:56:07 +00:00
Chris Morgan
a41a3577ce
Remove the application created to perform the unit test so we don't 'leak' dummy applications
2006-07-17 20:41:18 +00:00
Chris Morgan
8bdf80982f
Fix table name case difference 'Appversion' -> 'appVersion' that was breaking a query
2006-07-16 17:37:23 +00:00
Chris Morgan
0b9a5b4e94
Merge appMaintainerQueue table into appMaintainers table. This simplifies the handling of queued vs.
...
unqueued maintainers and removes a table from the database
2006-07-16 16:53:08 +00:00
Tony Lambregts
ed2cbe739d
Stop allowing anonymous test results
2006-07-16 05:39:56 +00:00
Chris Morgan
ed0c692744
Exclude GPC values that start with 'Dialog', these are used by Xinha and we don't want to modify that code. Also exclude
...
PHPSESSID, this is a convenience for developers as php uses this key for its default session management and we really don't
mind if it is defined or not as we use our own session handlers
2006-07-15 05:16:37 +00:00
Tony Lambregts
e1711a2cdb
Show additional comments when viewing test data in application version
2006-07-14 01:48:46 +00:00
Tony Lambregts
ccbb2a14fc
Include link to app and version when displaying a list of test results
2006-07-14 01:32:04 +00:00
Jonathan Ernst
a4e384604b
Fix missing reply text by renaming replyText to sReplyText
2006-07-13 18:54:10 +00:00
Chris Morgan
04e7fa9906
Rename include/testResults.php to include/testData.php to match the name of the class
...
inside of the file.
2006-07-12 00:29:35 +00:00
Chris Morgan
916517e6f5
Ensure that session.gc_probability is 1 and set session.gc_divisor to something reasonable for a reasonably
...
heavily accessed site like appdb. This change solves the mystery of why we had millions of unexpired sessions
in session_list and should make the session_list cron cleanup job superfluous.
2006-07-11 20:35:43 +00:00
Jonathan Ernst
53ed5725b4
Stop copying variables, update comments
2006-07-11 19:26:14 +00:00
Chris Morgan
ec77d82734
Clean up variable naming in query_parameters()
2006-07-11 19:25:16 +00:00
Chris Morgan
069a51fba8
Clean up category class. Move category related functions into the class and remove now extranious
...
$catId parameter from category::display()
2006-07-11 18:53:06 +00:00
Chris Morgan
457f7cc34b
Move distribution related functions into distribution class and combine getNumberOfDistributions() and
...
getNumberOfQueuedDistributions() by passing in a $bQueued flag
2006-07-11 17:02:35 +00:00
Chris Morgan
9adf7e5592
Clean up appimage code removing a bunch of redundant code and removing a query for each image that is actually output
...
to the browser
2006-07-11 03:48:40 +00:00
Chris Morgan
1587e8d0b4
Remove unused lookupVendorName()
2006-07-11 03:47:00 +00:00
Chris Morgan
88dde93132
Speed up outputTopXRowAppsFromRating() by earlying out if we have enough applications to fill our required amount.
...
This saves a database query for each top X table. Also rename $num_apps to $iNum_apps
2006-07-11 03:41:57 +00:00
Chris Morgan
4db25a90ad
Add a 'back' link at the top of the page. Switch to using html_back_link() to keep the displayed text
...
uniform, we were missing the '<<' before 'Back'
2006-07-11 03:39:18 +00:00
Chris Morgan
160f739da8
Screenshot class cleanups. Move screenshot related functions into the class. Rename get_screenshot_img() to
...
get_random_screenshot_img() so the name of the function matches its purpose
2006-07-11 03:37:07 +00:00
Chris Morgan
d831939a07
Fix case of sWebpage to let updating of application class information correctly update the applications web page.
2006-07-10 23:02:03 +00:00
Jeremy Newman
219b5ac09c
enable zlib output compression from PHP
2006-07-10 20:49:46 +00:00
Chris Morgan
d6f7ddd17b
appVersion table should have an index on appId field as we frequently query this table
...
using appId
2006-07-10 16:32:05 +00:00
Chris Morgan
0d8de67fd9
Eliminate redundant parameters from testData function
2006-07-10 15:42:00 +00:00
Chris Morgan
cd5a620d88
testData class cleanup. Move some test related functions into the class as
...
static functions. Clean up some variable names.
2006-07-10 15:39:21 +00:00