Commit Graph

987 Commits

Author SHA1 Message Date
Chris Morgan
98ba61db03 Clean up user class. Implement start of unit testing framework for appdb.
Implement start of user class unit test.
2006-06-27 03:59:16 +00:00
Jonathan Ernst
c8e07f8ae7 Update coding standard document 2006-06-26 17:25:19 +00:00
Tony Lambregts
a79d4a654c Fix applying to become a super maintainer 2006-06-26 01:43:00 +00:00
Chris Morgan
ac5b4b0a95 Warn if magic quotes is enabled and explain a bit about why we require that magic quotes
be disabled.  Also remove all of the conditional code that was working around cases where
we had magic quotes enabled.  We were only working around a small portion of cases where magic
quotes was affecting the appdb.
2006-06-26 00:44:44 +00:00
Chris Morgan
63d90984a1 Fix a warning due to missing first parameter when testData::OutputEditor() is called from adminTestResults.php.
At this point we never expect to have a $sDistribution so we can just default the parameter to a null string
2006-06-24 05:02:56 +00:00
Chris Morgan
fb0f3b5dd3 Protect against sql injection attacks in sql INSERT statements 2006-06-24 04:20:32 +00:00
Chris Morgan
c31173ef9e Disable hackish looking "we've got errors message" since we'll display human readable errors later on. 2006-06-24 04:07:42 +00:00
Chris Morgan
6f35da69d7 Fix voting. Another case, ha ha, where different capitalization messed us up 2006-06-24 03:09:07 +00:00
Chris Morgan
baa92fba38 Retrieve iCatId from $_REQUEST(), we can't use $aClean[] because it isn't in scope.
Fixes editing categories
2006-06-24 03:05:16 +00:00
Chris Morgan
3537fcbd88 Fix entering a new distribution when submitting a new application or version 2006-06-24 02:38:44 +00:00
Chris Morgan
3a3ff401cc Fix case of 'Submit' to fix creating a new distribution 2006-06-23 05:03:03 +00:00
Chris Morgan
1a6cde7f1e Fix the application name column in the top 'X' lists to be 150px wide so each top 'X' list
looks uniform
2006-06-23 04:11:50 +00:00
Chris Morgan
540a29cb5e Fix editing bundles, they've been broken since appdb was imported into cvs and we haven't noticed, ha 2006-06-23 03:42:08 +00:00
Chris Morgan
58b267506f Fix indenting and formatting 2006-06-22 22:34:56 +00:00
Chris Morgan
eea66ec98c $_SESSION['current']->userId should be ->iUserId, there is no userId member of
class user.
2006-06-22 22:34:23 +00:00
Chris Morgan
b55c2776a5 Compact the top 'X' lists on the main page by adding a flag to get_screenshot_img() that disables the output of
html that was putting the image inside of another table
2006-06-22 21:41:41 +00:00
Chris Morgan
2076ff9efc Fix preferences page. It is $_REQUEST and $_POST, not $REQUEST and $POST 2006-06-21 05:37:48 +00:00
Chris Morgan
67550405c3 Make code more consistent by making it follow the appdb coding standards. Fix some spaces vs. tabs odd indenting. 2006-06-21 01:04:12 +00:00
EA Durbin
d8a459af17 Eliminate the use of the undefined testResult() class and correcting spelling of testData. 2006-06-20 23:00:01 +00:00
Chris Morgan
ce71a0d8ed Fix case of $aClean['appId']. Fixes the bug of orphaning newly submitted versions 2006-06-20 22:58:58 +00:00
EA Durbin
4b0f0473f7 class testResult() doesn't exist, include/testResults.php is the name but the class is testData. Correct spelling of
testData().
2006-06-20 04:05:55 +00:00
Chris Morgan
bc9d2bcefe Clean all preferences, fixes setting preferences 2006-06-19 21:28:45 +00:00
EA Durbin
84b5a86e11 Update the TODO to reflect that we keep this information in the wiki now 2006-06-19 16:32:11 +00:00
Chris Morgan
6ceb14ef92 Disable addslashes() in makeSafe() until more finely grained filtering can be implemented 2006-06-19 15:40:53 +00:00
Tony Lambregts
ca3fca2e0a Fix up administrating app queue, add missing '[' 2006-06-18 04:22:43 +00:00
Tony Lambregts
fdc0760ce6 Open ratings definitions page in a new window so we don't erase any data a user has entered into input boxes 2006-06-17 06:12:28 +00:00
EA Durbin
f982c8459e Filter all user input to reduce the security impact of manipulated data 2006-06-17 06:10:10 +00:00
Tony Lambregts
02c5682c01 Don't expose email addresses to robots on the distribution page 2006-06-16 03:31:00 +00:00
Tony Lambregts
7fec72b632 Don't expose users email addresses to robots 2006-06-16 03:18:45 +00:00
Tony Lambregts
1069478c8a Prevent users from creating accounts with a blank username 2006-06-16 02:04:33 +00:00
Tony Lambregts
7250f751e5 Fix session current cookie being corrupted when creating a user and the user exists. 2006-06-16 02:03:12 +00:00
Tony Lambregts
a088778a85 Get rid of redundant include to fix adminCommentView.php 2006-06-14 14:57:23 +00:00
EA Durbin
7d5fe3986d Fix grammatical error 2006-06-06 18:55:04 +00:00
EA Durbin
efe08bae68 Fix typos 2006-06-06 18:54:12 +00:00
EA Durbin
62de655d75 Fix typo 2006-06-06 18:53:00 +00:00
Tony Lambregts
5fe6ad37c1 Fix wiki link 2006-06-05 01:11:07 +00:00
Tony Lambregts
5d8293bdb1 Update appdb to have a menu with links to all wine related sites 2006-06-03 23:53:41 +00:00
Alexander Nicolaysen Sørnes
24d1d1b598 Add link to rating definitions next to 'raiting' field on the test submission form 2006-06-03 22:17:00 +00:00
EA Durbin
522722dff4 Fix typo on the test results page 2006-05-27 01:42:45 +00:00
Alexander Nicolaysen Sørnes
b8318e22ca Improve language consistency in testResults.php 2006-05-04 00:24:18 +00:00
Alexander Nicolaysen Sørnes
270ea39bc9 Make the use of capitalization in the Application Form more consistent 2006-05-04 00:23:39 +00:00
Alexander Nicolaysen Sørnes
f7671e9d2a Language improvements. Also make the use of language more consistent. 2006-05-04 00:22:32 +00:00
EA Durbin
3fba57d0ff Correct the spelling of oThumbnail variable in get_thumbnail() 2006-05-04 00:03:47 +00:00
Tony Lambregts
fe004f36fa Add note to use the AppDB to reply to email instead of replying to the email 2006-04-28 00:53:01 +00:00
Tony Lambregts
42b6c87c7b Add a message to the app/version deletion email to clarify deletions due the app/version being moved 2006-04-27 01:44:57 +00:00
Tony Lambregts
647de96f9d Allow moving test results of a queued version to an approved version 2006-04-26 15:12:55 +00:00
Tony Lambregts
a0db997fdf Fix the display-approved_versions() function by switching the use of a '=' in an if() to a '==' 2006-04-26 15:11:00 +00:00
Alexander Nicolaysen Sørnes
300ad22e4b When vendor changes display before and after vendors instead of displaying the before vendor
twice.
2006-04-16 16:33:41 +00:00
Chris Morgan
0d9766059c Remove extra 'slash' in url that was causing all kinds of issues like users going to odd websites
after clicking on some links on the site
2006-04-06 02:02:52 +00:00
Tony Lambregts
4bd603af4f Give maintainers/administrators an easy way to edit test results 2006-04-03 03:51:26 +00:00