Chris Wilson 29732ca5d6 drm/i915: Only destroy a constructed mmap offset ...

commit 7e61615857c6fb3afbcb43f5c4e97511a923f5a8 upstream.

drm_ht_remove_item() does not handle removing an absent item and the hlist
in particular is incorrectly initialised. The easy remedy is simply skip
calling i915_gem_free_mmap_offset() unless we have actually created the
offset and associated ht entry.

This also fixes the mishandling of a partially constructed offset which
leaves pointers initialized after freeing them along the
i915_gem_create_mmap_offset() error paths.

In particular this should fix the oops found here:
https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/415357/comments/8

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Eric Anholt <eric@anholt.net>

2009-10-05 09:32:05 -07:00

..

drm

drm/i915: Only destroy a constructed mmap offset

2009-10-05 09:32:05 -07:00

Makefile

drm: reorganise drm tree to be more future proof.

2008-07-14 10:45:01 +10:00