Lai Jiangshan
b2aa30f7bb
cgroups: don't put struct cgroupfs_root protected by RCU
...
We don't access struct cgroupfs_root in fast path, so we should not put
struct cgroupfs_root protected by RCU
But the comment in struct cgroup_subsys.root confuse us.
struct cgroup_subsys.root is used in these places:
1 find_css_set(): if (ss->root->subsys_list.next == &ss->sibling)
2 rebind_subsystems(): if (ss->root != &rootnode)
rcu_assign_pointer(ss->root, root);
rcu_assign_pointer(subsys[i]->root, &rootnode);
3 cgroup_has_css_refs(): if (ss->root != cgrp->root)
4 cgroup_init_subsys(): ss->root = &rootnode;
5 proc_cgroupstats_show(): ss->name, ss->root->subsys_bits,
ss->root->number_of_cgroups, !ss->disabled);
6 cgroup_clone(): root = subsys->root;
if ((root != subsys->root) ||
All these place we have held cgroup_lock() or we don't dereference to
struct cgroupfs_root. It's means wo don't need RCU when use struct
cgroup_subsys.root, and we should not put struct cgroupfs_root protected
by RCU.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com >
Reviewed-by: Paul Menage <menage@google.com >
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com >
Cc: Pavel Emelyanov <xemul@openvz.org >
Cc: Balbir Singh <balbir@in.ibm.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2009-01-08 08:31:02 -08:00
..
2009-01-06 18:10:26 -08:00
2009-01-02 17:15:07 -02:00
2009-01-06 17:14:01 -08:00
2009-01-06 11:53:56 -05:00
2009-01-04 12:17:42 +01:00
2008-12-31 18:18:13 +01:00
2009-01-07 11:31:52 -08:00
2009-01-07 17:38:32 -05:00
2009-01-07 11:31:52 -08:00
2009-01-06 11:53:47 -05:00
2009-01-07 10:00:06 -08:00
2009-01-07 10:00:22 -08:00
2009-01-02 10:19:37 -08:00
2008-12-29 08:29:50 +01:00
2009-01-07 08:45:46 -08:00
2009-01-05 16:35:31 +01:00
2009-01-04 15:14:42 -05:00
2009-01-06 15:59:23 -08:00
2009-01-06 15:59:23 -08:00
2009-01-06 15:59:29 -08:00
2008-12-29 08:29:50 +01:00
2008-12-30 09:05:13 +10:30
2009-01-01 10:12:19 +10:30
2008-12-29 08:29:50 +01:00
2009-01-04 13:33:20 -08:00
2008-12-29 08:28:44 +01:00
2009-01-07 09:38:48 +11:00
2009-01-08 08:31:02 -08:00
2009-01-02 12:19:34 -08:00
2009-01-02 09:29:43 -08:00
2009-01-02 09:23:03 -08:00
2009-01-02 09:23:03 -08:00
2008-12-29 17:47:23 +10:00
2009-01-01 10:12:30 +10:30
2009-01-06 15:58:59 -08:00
2008-12-25 11:01:43 +11:00
2008-12-25 11:01:33 +11:00
2008-12-31 18:07:38 -05:00
2009-01-07 10:00:16 -08:00
2009-01-06 03:05:09 +00:00
2009-01-06 10:44:33 -08:00
2009-01-04 11:00:05 +01:00
2009-01-03 11:57:35 +01:00
2008-12-29 07:39:34 -05:00
2009-01-05 08:40:21 -08:00
2009-01-05 08:40:25 -08:00
2009-01-05 08:40:25 -08:00
2008-12-29 08:29:50 +01:00
2009-01-08 08:31:00 -08:00
2009-01-08 08:31:00 -08:00
2009-01-08 08:31:00 -08:00
2009-01-08 08:31:01 -08:00
2008-12-29 11:27:46 +02:00
2008-12-31 18:07:42 -05:00
2008-12-31 18:07:42 -05:00
2009-01-07 08:47:24 -08:00
2009-01-02 10:19:38 -08:00
2008-12-29 08:29:51 +01:00
2009-01-06 15:59:01 -08:00
2008-12-30 16:10:19 -08:00
2009-01-04 01:00:53 +01:00
2009-01-04 01:00:51 +01:00
2009-01-06 15:58:58 -08:00
2009-01-07 14:29:17 +01:00
2009-01-06 17:21:02 +01:00
2008-12-31 18:07:42 -05:00
2008-12-25 11:40:29 +01:00
2009-01-03 14:11:08 +01:00
2009-01-06 17:10:53 -08:00
2009-01-03 14:10:09 +01:00
2009-01-07 11:12:32 -08:00
2009-01-02 11:44:09 -08:00
2009-01-05 14:53:30 +01:00
2009-01-02 10:19:40 -08:00
2009-01-05 08:40:30 -08:00
2009-01-08 08:31:00 -08:00
2009-01-05 08:40:30 -08:00
2009-01-07 10:00:22 -08:00
2008-12-31 15:11:46 +01:00
2009-01-06 17:02:07 -08:00
2009-01-06 10:44:30 -08:00
2009-01-06 15:59:21 -08:00
2009-01-03 14:11:07 +01:00
2008-12-31 16:55:47 +02:00
2008-12-30 09:26:11 +10:30
2008-12-28 22:43:21 -05:00
2008-12-30 16:20:19 -08:00
2009-01-08 08:30:59 -08:00
2008-12-29 04:59:31 -08:00
2009-01-06 15:59:00 -08:00
2009-01-06 15:59:00 -08:00
2009-01-06 15:59:00 -08:00
2008-12-29 08:29:50 +01:00
2009-01-06 15:58:58 -08:00
2009-01-06 15:59:20 -08:00
2009-01-05 08:40:13 +10:30
2008-12-31 18:07:38 -05:00
2009-01-06 11:28:07 +01:00
2009-01-04 16:13:40 -08:00
2009-01-07 17:38:31 -05:00
2009-01-06 15:59:00 -08:00
2009-01-07 09:59:50 -08:00
2009-01-06 15:59:07 -08:00
2009-01-04 13:33:20 -08:00
2009-01-06 15:59:00 -08:00
2009-01-07 11:13:11 -08:00
2009-01-06 17:21:01 +01:00
2009-01-07 11:13:22 -08:00
2009-01-07 11:13:11 -08:00
2009-01-07 11:13:25 -08:00
2009-01-06 17:10:04 -08:00
2009-01-06 10:44:29 -08:00
2009-01-06 10:44:30 -08:00
2009-01-06 15:59:12 -08:00
2009-01-04 12:17:39 +01:00
2009-01-07 21:44:20 +01:00
2009-01-07 21:44:20 +01:00
2009-01-05 08:40:25 -08:00
2009-01-05 08:40:25 -08:00
2009-01-05 18:31:12 -08:00
2009-01-03 12:01:23 -08:00
2009-01-01 10:12:26 +10:30
2009-01-05 10:18:08 +01:00
2008-12-30 17:31:25 -08:00
2009-01-06 15:59:28 -08:00
2009-01-06 15:59:07 -08:00
2009-01-04 13:33:20 -08:00
2009-01-06 17:10:33 -08:00
2009-01-07 09:58:22 +11:00
2008-12-30 09:05:19 +10:30
2009-01-02 10:19:43 -08:00
2009-01-02 10:19:43 -08:00
2009-01-02 10:19:42 -08:00
2008-12-29 11:45:47 +02:00
2008-12-30 09:05:16 +10:30
2009-01-05 08:40:14 +10:30
2009-01-06 21:17:57 -08:00
2009-01-06 15:59:07 -08:00
2008-12-28 09:54:52 +01:00
2009-01-05 11:54:29 -05:00
2008-12-30 09:05:12 +10:30
2009-01-01 10:12:25 +10:30
2008-12-31 09:53:21 +01:00
2009-01-02 10:19:36 -08:00
2009-01-02 10:19:40 -08:00
2009-01-07 11:27:12 -08:00
2009-01-06 10:44:44 -08:00
2009-01-07 10:00:11 -08:00
2009-01-07 10:00:14 -08:00
2009-01-02 17:11:52 -02:00
2008-12-30 09:26:04 +10:30
2008-12-30 09:26:10 +10:30
2008-12-30 09:25:58 +10:30
2008-12-30 09:26:03 +10:30
2009-01-06 15:59:05 -08:00
2009-01-07 10:00:16 -08:00
2009-01-06 15:59:09 -08:00