starred/C
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C.git synced 2026-04-24 06:19:35 +00:00
Code Issues 1.4k Packages Projects Releases Wiki Activity

[PR #771] [MERGED] fix: several bugs on games/tic_tac_toe.c #1283

New Issue
Open
opened 2026-01-29 15:18:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:18:55 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/TheAlgorithms/C/pull/771
Author: @kana800
Created: 11/4/2020
Status: ✅ Merged
Merged: 2/10/2021
Merged by: @kvedala

Base: master ← Head: fix_bug

📝 Commits (10+)

📊 Changes

1 file changed (+38 additions, -27 deletions)

View changed files

📝 games/tic_tac_toe.c (+38 -27)

📄 Description

Description of Change

Issue: #729
As mentioned in the issue , The piece code listed below throws the program into an loop (from line 247) if an invalid character is entered.

        else
        {
+            int n = check_placex();
-             printf("Invalid move\n");

-            printf("Enter new position : ");
-            scanf("%d", &n1);
+           placex(n);
-            placex(n1);
        }
    }
    else
    {
-        printf("Invalid move \n");
+       int n = check_placex();
-        printf("Enter new position : ");
-        scanf("%d", &n1);
+       placex(n);
-        placex(n1);
    }
}

Fixes / Changes

Added an array [dynamic] at line36 :
+ int *stored_pos = NULL;

line 47:

+  stored_pos = (int*)calloc(9,sizeof(int))
Assignment of the stored_pos array:

line 331, line 308 & line 278

example:

+ stored_pos[e] = 1;
Freed the stored_pos memory

line 75

+ free(stored_pos);
Added a new function called check_places at line237 to line256
int check_placex(){
	char input[50];
	int n1;
	while (1){
		fgets(input,49,stdin);
		if ( strlen(input) > 2 || strlen(input)  == 0){
			fprintf(stderr,"Invalid move, Enter number 1 - 9: ");
			continue;
		}
		if(sscanf(input,"%d",&n1) != 1){
			fprintf(stderr,"Invalid move, Enter number 1 - 9: ");
			continue;
		} 
		if ((stored_pos[n1-1] == 1) || (n1== 0)){
			fprintf(stderr,"Already allocated, Enter number: ");
			continue;
		}
		return n1;
	}
}

The while-loop in the above above function will ask for an input until it gets a correct output.

  1. The first if condition checks whether the input is within the range. (strlen() is used so string.h lib is need)
  2. Second if condition checks if the value is integer
  3. Third if condition checks if the value (posistion) is already occupied.

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/TheAlgorithms/C/pull/771 **Author:** [@kana800](https://github.com/kana800) **Created:** 11/4/2020 **Status:** ✅ Merged **Merged:** 2/10/2021 **Merged by:** [@kvedala](https://github.com/kvedala) **Base:** `master` ← **Head:** `fix_bug` --- ### 📝 Commits (10+) - [`2d27be8`](https://github.com/TheAlgorithms/C/commit/2d27be85528772fb60e09e8ac40a3fff7bf01e40) fixed several bugs on tic_tac_toe - [`5ba242f`](https://github.com/TheAlgorithms/C/commit/5ba242f579abf28add2fb1226e5741bbe5d3a2a4) final changes bug fixed - [`d78506e`](https://github.com/TheAlgorithms/C/commit/d78506ea47ec1d9f495e0073beb0197c486d5f45) added requested changes - [`8299b01`](https://github.com/TheAlgorithms/C/commit/8299b01a54b3e2771e4ea2946fb289b66d21f765) fixed changes - [`67c8883`](https://github.com/TheAlgorithms/C/commit/67c88832cf71482f13eeceeaf78fd8687b903acf) fixed stuff - [`3ec1d85`](https://github.com/TheAlgorithms/C/commit/3ec1d854492c8bc1d2ef301b58d73590b50d9c0e) fix clang-tidy warnings - [`535c531`](https://github.com/TheAlgorithms/C/commit/535c5318e0365104747c47e54d4c33bcde9e17ee) removed unnecessary headers - [`de070f6`](https://github.com/TheAlgorithms/C/commit/de070f6bc199e62d72d0adbb6308a6974e6efc4c) resolved some warnings - [`e024589`](https://github.com/TheAlgorithms/C/commit/e0245894b8f3c3a5fad4bba53a8db9a84ef93d5f) fixed warning c4244 - [`31220af`](https://github.com/TheAlgorithms/C/commit/31220af6cb809938de61466dc0ac4f81a8814f93) Tiggering CI checks ### 📊 Changes **1 file changed** (+38 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `games/tic_tac_toe.c` (+38 -27) </details> ### 📄 Description #### Description of Change Issue: #729 As **mentioned** in the issue , The piece code listed below throws the program into an loop (from `line 247`) if an **invalid** character is entered. ```diff else { + int n = check_placex(); - printf("Invalid move\n"); - printf("Enter new position : "); - scanf("%d", &n1); + placex(n); - placex(n1); } } else { - printf("Invalid move \n"); + int n = check_placex(); - printf("Enter new position : "); - scanf("%d", &n1); + placex(n); - placex(n1); } } ``` #### Fixes / Changes ##### Added an array [dynamic] at `line36` : ```diff + int *stored_pos = NULL; ``` `line 47`: ```diff + stored_pos = (int*)calloc(9,sizeof(int)) ``` ##### _Assignment_ of the **stored_pos** array: `line 331`, `line 308` & `line 278` example: ```diff + stored_pos[e] = 1; ``` ##### Freed the _stored_pos_ memory `line 75` ```diff + free(stored_pos); ``` ##### Added a new function called `check_places` at `line237` to `line256` ```C int check_placex(){ char input[50]; int n1; while (1){ fgets(input,49,stdin); if ( strlen(input) > 2 || strlen(input) == 0){ fprintf(stderr,"Invalid move, Enter number 1 - 9: "); continue; } if(sscanf(input,"%d",&n1) != 1){ fprintf(stderr,"Invalid move, Enter number 1 - 9: "); continue; } if ((stored_pos[n1-1] == 1) || (n1== 0)){ fprintf(stderr,"Already allocated, Enter number: "); continue; } return n1; } } ``` The `while-loop` in the above above function will ask for an input until it gets a correct output. 1. The first **if condition** checks whether the **input** is within the range. _(strlen() is used so `string.h` lib is need)_ 1. Second **if condition** checks if the value is integer 1. Third **if condition** checks if the value (_posistion_) is already occupied. #### References #### Checklist - [x] Added description of change - [x] Added file name matches [File name guidelines](https://github.com/TheAlgorithms/C/blob/master/CONTRIBUTING.md#File-Name-guidelines) - [x] Added tests and example, test must pass - [x] Relevant documentation/comments is changed or added - [x] PR title follows semantic [commit guidelines](https://github.com/TheAlgorithms/C/blob/master/CONTRIBUTING.md#Commit-Guidelines) - [x] Search previous suggestions before making a new one, as yours may be a duplicate. - [x] I acknowledge that all my contributions will be made under the project's license. Notes: <!-- Please add a one-line description for developers or pull request viewers --> <a href="https://gitpod.io/#https://github.com/TheAlgorithms/C/pull/771"><img src="https://gitpod.io/api/apps/github/pbs/github.com/kana800/C.git/2d27be85528772fb60e09e8ac40a3fff7bf01e40.svg" /></a> <a href="https://gitpod.io/#https://github.com/TheAlgorithms/C/pull/771"><img src="https://gitpod.io/api/apps/github/pbs/github.com/kana800/C.git/e0245894b8f3c3a5fad4bba53a8db9a84ef93d5f.svg" /></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 15:18:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dont-close
enhancement
good first issue
hacktoberfest
hacktoberfest
help wanted
invalid
not-an-algorithm
out of date
Practice coding
pull-request
Mirrored from GitHub Pull Request
 question
Stale
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/C#1283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?