starred/C
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C.git synced 2026-04-23 05:49:37 +00:00
Code Issues 1.4k Packages Projects Releases Wiki Activity

[PR #1336] fix: hexadecimal_to_octal.c #1938

New Issue
Open
opened 2026-01-29 15:26:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:26:27 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/TheAlgorithms/C/pull/1336

State: closed
Merged: No

Description of Change

Fix to Issue #1330
I've made the following changes:

  • Removed the newline character from the input string.

  • Improved the binary to octal conversion loop.

  • Added a return statement after printing an error message for invalid hexadecimal input.

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

**Original Pull Request:** https://github.com/TheAlgorithms/C/pull/1336 **State:** closed **Merged:** No --- #### Description of Change Fix to Issue #1330 I've made the following changes: - Removed the newline character from the input string. - Improved the binary to octal conversion loop. - Added a return statement after printing an error message for invalid hexadecimal input. <!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Contributors guide: https://github.com/TheAlgorithms/C/blob/master/CONTRIBUTING.md --> #### References <!-- Add any reference to previous pull-request or issue --> #### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [x] Added description of change - [x] Added file name matches [File name guidelines](https://github.com/TheAlgorithms/C/blob/master/CONTRIBUTING.md#File-Name-guidelines) - [ ] Added tests and example, test must pass - [ ] Relevant documentation/comments is changed or added - [x] PR title follows semantic [commit guidelines](https://github.com/TheAlgorithms/C/blob/master/CONTRIBUTING.md#Commit-Guidelines) - [ ] Search previous suggestions before making a new one, as yours may be a duplicate. - [x] I acknowledge that all my contributions will be made under the project's license. Notes: <!-- Please add a one-line description for developers or pull request viewers -->
claunia added the pull-request label 2026-01-29 15:26:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dont-close
enhancement
good first issue
hacktoberfest
hacktoberfest
help wanted
invalid
not-an-algorithm
out of date
Practice coding
pull-request
Mirrored from GitHub Pull Request
 question
Stale
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/C#1938
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?