starred/C
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C.git synced 2026-02-04 05:44:35 +00:00
Code Issues 1.4k Packages Projects Releases Wiki Activity

[PR #554] [MERGED] [bugs & docs] lots of documentation and bug fixes #979

New Issue
Open
opened 2026-01-29 15:16:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 15:16:35 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/TheAlgorithms/C/pull/554
Author: @kvedala
Created: 7/2/2020
Status: ✅ Merged
Merged: 7/4/2020
Merged by: @kvedala

Base: master ← Head: fixes/lgtm

📝 Commits (9)

  • 2f970ec sudoku - lots of documentation and bug fixes
  • a3fe21c fix uint8_t format specifier
  • 5a0a2cf fix format specifiers
  • b1bebe4 fix space in doc
  • 3811000 fix doc for get_next_unknown
  • d4f090d fix docs and lgtm alert in euler problem 19
  • b64508f fix docs & lgtm error fibonacci_fast
  • 9102644 fix docs & lgtm alert merge_sort
  • 5eaa6ca free dynamic memory

📊 Changes

4 files changed (+315 additions, -100 deletions)

View changed files

📝 misc/fibonacci_fast.c (+14 -10)
📝 misc/sudoku_solver.c (+238 -61)
📝 project_euler/problem_19/sol1.c (+21 -18)
📝 sorting/merge_sort.c (+42 -11)

📄 Description

Description of Change

  • Sudoku file used multiple global variables with ambiguous names and had no documentation.
    These issues have been fixed. Moreover, extensive documentation and debug messages have been added.
  • More documentation and LGTM alerts fixes for:
    • fibonacci_fast
    • project euler problem 19
    • merge_sort
      • also fixed dynamic memory de-allocation

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/TheAlgorithms/C/pull/554 **Author:** [@kvedala](https://github.com/kvedala) **Created:** 7/2/2020 **Status:** ✅ Merged **Merged:** 7/4/2020 **Merged by:** [@kvedala](https://github.com/kvedala) **Base:** `master` ← **Head:** `fixes/lgtm` --- ### 📝 Commits (9) - [`2f970ec`](https://github.com/TheAlgorithms/C/commit/2f970ec7eaf7c2f7cc033b28ec9d5f478e1c1558) sudoku - lots of documentation and bug fixes - [`a3fe21c`](https://github.com/TheAlgorithms/C/commit/a3fe21c45c98d06a0fbb9618e7eb8581d4ba0a35) fix uint8_t format specifier - [`5a0a2cf`](https://github.com/TheAlgorithms/C/commit/5a0a2cf6f1e29d8c77e1cb3b1e6c76324b25fa4a) fix format specifiers - [`b1bebe4`](https://github.com/TheAlgorithms/C/commit/b1bebe4daad913ae6612081e523c03ec5aac4dc1) fix space in doc - [`3811000`](https://github.com/TheAlgorithms/C/commit/381100082483613edb04a2478ec5ef9e026b25fd) fix doc for get_next_unknown - [`d4f090d`](https://github.com/TheAlgorithms/C/commit/d4f090d5c390c610ab6d8fa14243363b0ac84e6c) fix docs and lgtm alert in euler problem 19 - [`b64508f`](https://github.com/TheAlgorithms/C/commit/b64508fcca230b68cedad4464e85cb1fb488f78a) fix docs & lgtm error fibonacci_fast - [`9102644`](https://github.com/TheAlgorithms/C/commit/910264456a7135edd8c3c2fb7cd366f389f4d01e) fix docs & lgtm alert merge_sort - [`5eaa6ca`](https://github.com/TheAlgorithms/C/commit/5eaa6cad80f210fef8a4984e1de0aa59babee505) free dynamic memory ### 📊 Changes **4 files changed** (+315 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `misc/fibonacci_fast.c` (+14 -10) 📝 `misc/sudoku_solver.c` (+238 -61) 📝 `project_euler/problem_19/sol1.c` (+21 -18) 📝 `sorting/merge_sort.c` (+42 -11) </details> ### 📄 Description #### Description of Change <!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Contributors guide: https://github.com/TheAlgorithms/C-Plus-Plus/CONTRIBUTING.md --> * Sudoku file used multiple global variables with ambiguous names and had no documentation. These issues have been fixed. Moreover, extensive documentation and debug messages have been added. * More documentation and LGTM alerts fixes for: * fibonacci_fast * project euler problem 19 * merge_sort * also fixed dynamic memory de-allocation #### References <!-- Add any reference to previous pull-request or issue --> * Part of efforts for #550 * original commit for sudoku: 97f8c4a782d80f1afb0a7a0881b11c98968ae57f #### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [x] Added description of change - [ ] Added file name matches [File name guidelines](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#New-File-Name-guidelines) - [x] Added tests and example, test must pass - [x] Relevant documentation/comments is changed or added - [x] PR title follows semantic [commit guidelines](https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md#Commit-Guidelines) - [x] Search previous suggestions before making a new one, as yours may be a duplicate. - [x] I acknowledge that all my contributions will be made under the project's license. Notes: <!-- Please add a one-line description for developers or pull request viewers --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 15:16:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dont-close
enhancement
good first issue
hacktoberfest
hacktoberfest
help wanted
invalid
not-an-algorithm
out of date
Practice coding
pull-request
Mirrored from GitHub Pull Request
 question
Stale
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/C#979
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?