diff --git a/Changelog.md b/Changelog.md index f2121bf..c9a16a7 100644 --- a/Changelog.md +++ b/Changelog.md @@ -8,6 +8,7 @@ - Fixed floating point display resolution (#944) @softworkz - Fixed previous API break using exposed `JsonElement` objects (#938) @softworkz - Fixed and improved several test cases (#962) @softworkz +- Fixed startup of Electron.NET from VS Code Debug Adapter (#952) - Fixed the `BrowserWindowOptions` (#945) @softworkz - Added several migration checks for publishing (#966) @softworkz - Added more test runners for E2E tests (#950, #951) @agracio diff --git a/src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs b/src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs index c607836..b37359f 100644 --- a/src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs +++ b/src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs @@ -60,6 +60,11 @@ public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, string[] args, Func onAppReadyCallback) { ElectronNetRuntime.OnAppReadyCallback = onAppReadyCallback; + + // no matter how this is set - let's unset to prevent Electron not starting as expected + // e.g., VS Code sets this env variable, but this will cause `require("electron")` to not + // work as expected, see issue #952 + Environment.SetEnvironmentVariable("ELECTRON_RUN_AS_NODE", null); var webPort = PortHelper.GetFreePort(ElectronNetRuntime.AspNetWebPort ?? ElectronNetRuntime.DefaultWebPort); ElectronNetRuntime.AspNetWebPort = webPort;