From 8a3b9951fa6d4348bc3bd7b8e403a61eb1d9adf2 Mon Sep 17 00:00:00 2001 From: kthrose Date: Wed, 29 May 2019 10:50:24 -0400 Subject: [PATCH 1/3] fix async issue where same port is considered open --- ElectronNET.Host/main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ElectronNET.Host/main.js b/ElectronNET.Host/main.js index c5f9062..8a87ada 100644 --- a/ElectronNET.Host/main.js +++ b/ElectronNET.Host/main.js @@ -99,10 +99,10 @@ function startSocketApiBridge(port) { server.listen(port, 'localhost'); server.on('listening', function () { console.log('Electron Socket started on port %s at %s', server.address().port, server.address().address); + // Now that socket connection is established, we can guarantee port will not be open for portscanner + startAspCoreBackend(port); }); - startAspCoreBackend(port); - io.on('connection', (socket) => { global['electronsocket'] = socket; global['electronsocket'].setMaxListeners(0); From 43028afc02fcd186b69bbd3fe4fe7030277e0226 Mon Sep 17 00:00:00 2001 From: kthrose Date: Fri, 31 May 2019 10:08:44 -0400 Subject: [PATCH 2/3] add bash version of release script --- buildReleaseNuGetPackages.sh | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100755 buildReleaseNuGetPackages.sh diff --git a/buildReleaseNuGetPackages.sh b/buildReleaseNuGetPackages.sh new file mode 100755 index 0000000..d847934 --- /dev/null +++ b/buildReleaseNuGetPackages.sh @@ -0,0 +1,13 @@ +echo "Start building Electron.NET dev stack..." +echo "Restore & Build API" +cd ElectronNet.API +dotnet restore +dotnet build --configuration Release --force /property:Version=5.22.12 +dotnet pack /p:Version=5.22.12 --configuration Release --force --output "%~dp0artifacts" +cd .. +echo "Restore & Build CLI" +cd ElectronNet.CLI +dotnet restore +dotnet build --configuration Release --force /property:Version=5.22.12 +dotnet pack /p:Version=5.22.12 --configuration Release --force --output "%~dp0artifacts" +cd .. \ No newline at end of file From 0a02b7140b34172140013376eedc4a6307683f12 Mon Sep 17 00:00:00 2001 From: kthrose Date: Mon, 3 Jun 2019 16:54:25 -0400 Subject: [PATCH 3/3] Fix filenames in shell script, ElectronNet != ElectionNET on Linux for builds. --- buildReleaseNuGetPackages.sh | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/buildReleaseNuGetPackages.sh b/buildReleaseNuGetPackages.sh index d847934..2771bb6 100755 --- a/buildReleaseNuGetPackages.sh +++ b/buildReleaseNuGetPackages.sh @@ -1,13 +1,15 @@ echo "Start building Electron.NET dev stack..." + echo "Restore & Build API" -cd ElectronNet.API -dotnet restore -dotnet build --configuration Release --force /property:Version=5.22.12 -dotnet pack /p:Version=5.22.12 --configuration Release --force --output "%~dp0artifacts" -cd .. +cd ElectronNET.API && \ +dotnet restore && \ +dotnet build --configuration Release --force /property:Version=5.22.12 && \ +dotnet pack /p:Version=5.22.12 --configuration Release --force --output "%~dp0artifacts"; + +cd ../; + echo "Restore & Build CLI" -cd ElectronNet.CLI -dotnet restore -dotnet build --configuration Release --force /property:Version=5.22.12 -dotnet pack /p:Version=5.22.12 --configuration Release --force --output "%~dp0artifacts" -cd .. \ No newline at end of file +cd ElectronNET.CLI && \ +dotnet restore && \ +dotnet build --configuration Release --force /property:Version=5.22.12 && \ +dotnet pack /p:Version=5.22.12 --configuration Release --force --output "%~dp0artifacts";