starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

Test failure after one of PRs #1009

New Issue
Closed
opened 2026-01-29 16:54:33 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 16:54:33 +00:00
Owner
Copy Link

Originally created by @agracio on GitHub (Nov 12, 2025).

Failure branch: develop

Test WebContentsTests -> DomReady_event_fires() is currently stuck in perpetual load. It is using fx.MainWindow.WebContents.GetUrl that never returns.
Since it does not use ApiBase there is no timeout which causes test suit to become permanently stuck.

So far was unable to resolve it as all, endpoints and JS implementation appear to be correct.

Since it causes test suite to become permanently stuck I propose to mark test as skipped while we try to figure out what is causing failure.

EDIT: it does not fail on my branch with changes to events and tasks but started failing during merge.

Originally created by @agracio on GitHub (Nov 12, 2025). Failure branch: `develop` Test `WebContentsTests` -> `DomReady_event_fires()` is currently stuck in perpetual load. It is using `fx.MainWindow.WebContents.GetUrl` that never returns. Since it does not use ApiBase there is no timeout which causes test suit to become permanently stuck. So far was unable to resolve it as all, endpoints and JS implementation appear to be correct. Since it causes test suite to become permanently stuck I propose to mark test as skipped while we try to figure out what is causing failure. EDIT: it does not fail on my branch with changes to events and tasks but started failing during merge.
claunia added the bug label 2026-01-29 16:54:33 +00:00
claunia commented 2026-01-29 16:54:35 +00:00
Author
Owner
Copy Link

@agracio commented on GitHub (Nov 12, 2025):

Initially I suspected that LoadURLAsync is at fault, after further investigation it is GetUrl that is failing, reverting Once resolves the issue.

This particular task uses strange event naming I will try to resolve it.

@agracio commented on GitHub (Nov 12, 2025): Initially I suspected that LoadURLAsync is at fault, after further investigation it is GetUrl that is failing, reverting `Once` resolves the issue. This particular task uses strange event naming I will try to resolve it.
claunia commented 2026-01-29 16:54:35 +00:00
Author
Owner
Copy Link

@agracio commented on GitHub (Nov 12, 2025):

Resolved.

@agracio commented on GitHub (Nov 12, 2025): Resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1009
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?