starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #95] [MERGED] fix: socket.connnect JS : Scope & Closures #1081

New Issue
Open
opened 2026-01-29 16:57:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:57:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/95
Author: @mojinxun
Created: 2/9/2018
Status: ✅ Merged
Merged: 7/22/2018
Merged by: @GregorBiswanger

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

17 files changed (+336 additions, -226 deletions)

View changed files

📝 ElectronNET.API/Dialog.cs (+8 -1)
📝 ElectronNET.API/ElectronNET.API.csproj (+3 -1)
📝 ElectronNET.API/IpcMain.cs (+1 -0)
📝 ElectronNET.CLI/ElectronNET.CLI.csproj (+1 -1)
📝 ElectronNET.Host/api/app.js (+34 -34)
📝 ElectronNET.Host/api/browserWindows.js (+119 -122)
📝 ElectronNET.Host/api/clipboard.js (+6 -6)
📝 ElectronNET.Host/api/dialog.js (+11 -5)
📝 ElectronNET.Host/api/globalShortcut.js (+2 -2)
📝 ElectronNET.Host/api/ipc.js (+8 -7)
📝 ElectronNET.Host/api/menu.js (+2 -2)
📝 ElectronNET.Host/api/notification.js (+6 -6)
📝 ElectronNET.Host/api/screen.js (+9 -9)
📝 ElectronNET.Host/api/shell.js (+7 -7)
📝 ElectronNET.Host/api/tray.js (+8 -8)
📝 ElectronNET.Host/api/webContents.js (+4 -4)
📝 ElectronNET.Host/main.js (+107 -11)

📄 Description

when io reconnect, a new socket well create.
but from front socket not be updated

the commit is fix it by global.elesocket

please check, or better method

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/95 **Author:** [@mojinxun](https://github.com/mojinxun) **Created:** 2/9/2018 **Status:** ✅ Merged **Merged:** 7/22/2018 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`53c591f`](https://github.com/ElectronNET/Electron.NET/commit/53c591f7b7669d417c458ed94c54c487ba84467c) Merge pull request #1 from ElectronNET/master - [`3ba46a3`](https://github.com/ElectronNET/Electron.NET/commit/3ba46a3565845943a34ccc8ac7c362af7e472cad) 1 - [`ad20230`](https://github.com/ElectronNET/Electron.NET/commit/ad20230b2049940c458f377d47c1bf26b084126d) Merge branch 'master' of https://github.com/mojinxun/Electron.NET - [`e20dafb`](https://github.com/ElectronNET/Electron.NET/commit/e20dafbb665e055adccf495a8786d89b15abe457) resume csproj - [`0997291`](https://github.com/ElectronNET/Electron.NET/commit/09972914842f47b67cbfa1459362869a71ef4bd4) fix: possible eventemitter memory leak delected - [`ef1f0ab`](https://github.com/ElectronNET/Electron.NET/commit/ef1f0ab3307ca01145a69fa6cbbcc50d33216ea4) registerIpcMainChannel remove channel - [`e3eee0c`](https://github.com/ElectronNET/Electron.NET/commit/e3eee0c32f0a78fc97e98b575a7f17707668379b) 1 - [`949741d`](https://github.com/ElectronNET/Electron.NET/commit/949741d992d95253c3ec3dc274b2665078adf6c3) getWindowById(id) add undefined check - [`1bf274a`](https://github.com/ElectronNET/Electron.NET/commit/1bf274a73c82ddea53cccae7d404bac41c005e3a) 1. getWindowById(id) add undefined check - [`354b4f0`](https://github.com/ElectronNET/Electron.NET/commit/354b4f09e61ab6e69587e837fa2d84ab5b4697e2) add loadingWindow ### 📊 Changes **17 files changed** (+336 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/Dialog.cs` (+8 -1) 📝 `ElectronNET.API/ElectronNET.API.csproj` (+3 -1) 📝 `ElectronNET.API/IpcMain.cs` (+1 -0) 📝 `ElectronNET.CLI/ElectronNET.CLI.csproj` (+1 -1) 📝 `ElectronNET.Host/api/app.js` (+34 -34) 📝 `ElectronNET.Host/api/browserWindows.js` (+119 -122) 📝 `ElectronNET.Host/api/clipboard.js` (+6 -6) 📝 `ElectronNET.Host/api/dialog.js` (+11 -5) 📝 `ElectronNET.Host/api/globalShortcut.js` (+2 -2) 📝 `ElectronNET.Host/api/ipc.js` (+8 -7) 📝 `ElectronNET.Host/api/menu.js` (+2 -2) 📝 `ElectronNET.Host/api/notification.js` (+6 -6) 📝 `ElectronNET.Host/api/screen.js` (+9 -9) 📝 `ElectronNET.Host/api/shell.js` (+7 -7) 📝 `ElectronNET.Host/api/tray.js` (+8 -8) 📝 `ElectronNET.Host/api/webContents.js` (+4 -4) 📝 `ElectronNET.Host/main.js` (+107 -11) </details> ### 📄 Description when io reconnect, a new socket well create. but from front socket not be updated the commit is fix it by global.elesocket please check, or better method --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:57:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1081
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?