[PR #228] [MERGED] Adds new command line parameters to 'electronize build' #1108

New Issue

claunia · 2026-01-29T16:57:27Z

claunia commented

2026-01-29 16:57:27 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/228
Author: @gfs
Created: 3/28/2019
Status: ✅ Merged
Merged: 5/16/2019
Merged by: @GregorBiswanger

Base: master ← Head: master

📝 Commits (6)

c0ee3b8 Fixes directory change when running script.
f7cc2a9 Adds three new command line options for build. Specifying the output path, and allowing specification of a package.json file to use.
078ac99 Revert version change.
6642f9d Correct license information in package.json to match license file included with source.
7dc3072 Adds additional new parameter to force a node install, instead of
8b5bb63 Merge branch 'master' into master

📊 Changes

1 file changed (+31 additions, -1 deletions)

View changed files

📝 ElectronNET.CLI/Commands/BuildCommand.cs (+31 -1)

📄 Description

Fixes #227.

Adds four new command line parameters to electronize build allowing users to specify the output path, and to provide their own package.json and to specify that they want an npm install

/package-json specifies a package.json file the user wishes to use, and sets /install-modules
/install-modules specifies that electronize build should always npm install
/relative-path specifies a relative path to output binaries
/absolute-path specifies an absolute path to output binaries.

Fixes a directory change side effect of the buildReleaseNuGetPackages.cmd script.
Updates the license information in Package.json to match the license included in the code (ISC -> MIT)

The path specifications change the path provided to electron-packager.

The package-json argument overwrites the bundled package.json after laying out the pre-packed files.

I've tested all four commands manually.

I have noticed you have to be very careful to match your custom package.json with the auto deployed package.json. So documentation for these commands should note that. My procedure was to layout the files normally and then edit the package.json setting it aside to provide as an argument.

Update:
After additional work added one more command line parameter.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/228 **Author:** [@gfs](https://github.com/gfs) **Created:** 3/28/2019 **Status:** ✅ Merged **Merged:** 5/16/2019 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`c0ee3b8`](https://github.com/ElectronNET/Electron.NET/commit/c0ee3b8859e1bd19d68cf46c47152e489be16a01) Fixes directory change when running script. - [`f7cc2a9`](https://github.com/ElectronNET/Electron.NET/commit/f7cc2a995fee78a5439fda8f60f30031080feec6) Adds three new command line options for build. Specifying the output path, and allowing specification of a package.json file to use. - [`078ac99`](https://github.com/ElectronNET/Electron.NET/commit/078ac990984dbe88ae644ffd8986695b824961e6) Revert version change. - [`6642f9d`](https://github.com/ElectronNET/Electron.NET/commit/6642f9d505ff6686bfffc48cbfd96e25b205bd95) Correct license information in package.json to match license file included with source. - [`7dc3072`](https://github.com/ElectronNET/Electron.NET/commit/7dc3072b5f05f0f29b934555e1c428b109f444a6) Adds additional new parameter to force a node install, instead of - [`8b5bb63`](https://github.com/ElectronNET/Electron.NET/commit/8b5bb636f34c8a3be54d8c889c18d10c8a7cd022) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+31 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+31 -1) </details> ### 📄 Description Fixes #227. 1. Adds four new command line parameters to `electronize build` allowing users to specify the output path, and to provide their own package.json and to specify that they want an `npm install` - `/package-json` specifies a package.json file the user wishes to use, and sets `/install-modules` - `/install-modules` specifies that `electronize build` should always `npm install` - `/relative-path` specifies a relative path to output binaries - `/absolute-path` specifies an absolute path to output binaries. 2. Fixes a directory change side effect of the `buildReleaseNuGetPackages.cmd` script. 3. Updates the license information in `Package.json` to match the license included in the code (ISC -> MIT) The path specifications change the path provided to `electron-packager`. The `package-json` argument overwrites the bundled package.json after laying out the pre-packed files. I've tested all four commands manually. I have noticed you have to be very careful to match your custom package.json with the auto deployed package.json. So documentation for these commands should note that. My procedure was to layout the files normally and then edit the package.json setting it aside to provide as an argument. Update: After additional work added one more command line parameter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:57:27 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1108