[PR #236] [MERGED] Reduce chance of detecting false positives when scanning subprocesses for errors. #1114

New Issue

claunia · 2026-01-29T16:57:32Z

claunia commented

2026-01-29 16:57:32 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/236
Author: @BorisTheBrave
Created: 4/27/2019
Status: ✅ Merged
Merged: 5/15/2019
Merged by: @GregorBiswanger

Base: master ← Head: electronize-cli-false-positive

📝 Commits (1)

a5cee6e Reduce chance of detecting false positives when scanning subprocesses for errors.

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 ElectronNET.CLI/ProcessHelper.cs (+5 -2)

📄 Description

Fixes #160

The problem is that ng build logs lines like the following:

20% building modules 90/102 modules 12 active 
...modules\\rxjs\\_esm5\\util\\EmptyError.js

The original code detects this as an error, unintentionally. The problem is compounded by the fact that the build process uses backspace characters, which means the "offending" line is invisible to end users.

This fix doesn't address the fact that scanning for "error" is a horrible hack, but I'm sure you've already explored the alternatives. Instead, I've made the smallest change possible that will continue to detect any likely error, while ignoring these problematic files. Fortunately, no file called "error.js" is installed, at least when I tested (Windowx x64, netcoreapp2.1, default new angular project).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/236 **Author:** [@BorisTheBrave](https://github.com/BorisTheBrave) **Created:** 4/27/2019 **Status:** ✅ Merged **Merged:** 5/15/2019 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `electronize-cli-false-positive` --- ### 📝 Commits (1) - [`a5cee6e`](https://github.com/ElectronNET/Electron.NET/commit/a5cee6e6d5086e9a64bdb3e5284f185d0b57aab2) Reduce chance of detecting false positives when scanning subprocesses for errors. ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.CLI/ProcessHelper.cs` (+5 -2) </details> ### 📄 Description Fixes #160 The problem is that `ng build` logs lines like the following: ``` 20% building modules 90/102 modules 12 active ...modules\\rxjs\\_esm5\\util\\EmptyError.js ``` The original code detects this as an error, unintentionally. The problem is compounded by the fact that the build process uses backspace characters, which means the "offending" line is invisible to end users. This fix doesn't address the fact that scanning for "error" is a horrible hack, but I'm sure you've already explored the alternatives. Instead, I've made the smallest change possible that will continue to detect any likely error, while ignoring these problematic files. Fortunately, no file called "error.js" is installed, at least when I tested (Windowx x64, netcoreapp**2.1**, default new angular project). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:57:32 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1114