mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
[PR #243] [MERGED] Call electronize from the Path instead of via dotnet in launchSettings.json #1117
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ElectronNET/Electron.NET/pull/243
Author: @Hecatron
Created: 5/8/2019
Status: ✅ Merged
Merged: 5/15/2019
Merged by: @GregorBiswanger
Base:
master← Head:hecatron-dev📝 Commits (1)
4235aa4Calls electronize from the Path instead of via dotnet📊 Changes
2 files changed (+14 additions, -11 deletions)
View changed files
📝
ElectronNET.CLI/Commands/InitCommand.cs(+7 -6)📝
ElectronNET.WebApp/Properties/launchSettings.json(+7 -5)📄 Description
I've noticed that when calling electronize init
The default behaviour is to modify launchSettings.json to add a profile to launch electronize via dotnet
However this would only work if electronize.exe was renamed to dotnet-electronize.exe in the tools directory
I've modified the init routine and the launchSettings.json of the example web app
to instead call electronize directly from the Path
Typically under windows it's located under C:\Users\UserName\.dotnet\tools\electronize.exe
which seems to be on my path by default.
For info the WorkingDirectory parameter of "." is needed to place the working directory in the same directory as the .csproj file instead of somewhere inside a bin/Debug folder.
The only other way to fix this would be to rename electronize.exe to dotnet-electronize.exe when it's installed as a tool
see https://github.com/natemcmaster/dotnet-tools
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.