[PR #236] Reduce chance of detecting false positives when scanning subprocesses for errors. #1119

New Issue

claunia · 2026-01-29T16:57:33Z

claunia commented

2026-01-29 16:57:33 +00:00

Original Pull Request: https://github.com/ElectronNET/Electron.NET/pull/236

State: closed
Merged: Yes

Fixes #160

The problem is that ng build logs lines like the following:

20% building modules 90/102 modules 12 active 
...modules\\rxjs\\_esm5\\util\\EmptyError.js

The original code detects this as an error, unintentionally. The problem is compounded by the fact that the build process uses backspace characters, which means the "offending" line is invisible to end users.

This fix doesn't address the fact that scanning for "error" is a horrible hack, but I'm sure you've already explored the alternatives. Instead, I've made the smallest change possible that will continue to detect any likely error, while ignoring these problematic files. Fortunately, no file called "error.js" is installed, at least when I tested (Windowx x64, netcoreapp2.1, default new angular project).

**Original Pull Request:** https://github.com/ElectronNET/Electron.NET/pull/236 **State:** closed **Merged:** Yes --- Fixes #160 The problem is that `ng build` logs lines like the following: ``` 20% building modules 90/102 modules 12 active ...modules\\rxjs\\_esm5\\util\\EmptyError.js ``` The original code detects this as an error, unintentionally. The problem is compounded by the fact that the build process uses backspace characters, which means the "offending" line is invisible to end users. This fix doesn't address the fact that scanning for "error" is a horrible hack, but I'm sure you've already explored the alternatives. Instead, I've made the smallest change possible that will continue to detect any likely error, while ignoring these problematic files. Fortunately, no file called "error.js" is installed, at least when I tested (Windowx x64, netcoreapp**2.1**, default new angular project).

claunia added the pull-request label 2026-01-29 16:57:33 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1119