[PR #289] [CLOSED] Fix for #288, use a fixed, local version for electron-builder #1130

New Issue

claunia · 2026-01-29T16:57:39Z

claunia commented

2026-01-29 16:57:39 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/289
Author: @GeorgDangl
Created: 7/11/2019
Status: ❌ Closed

Base: master ← Head: localElectronBuilder

📝 Commits (2)

ac62f87 Use local, fixed version for electron-builder instead of global tool
bed220f Add Json escaping for quotes in case custom electron parameters contain quotes

📊 Changes

2 files changed (+11 additions, -15 deletions)

View changed files

📝 ElectronNET.CLI/Commands/BuildCommand.cs (+10 -15)
📝 ElectronNET.CLI/ElectronNET.CLI.csproj (+1 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/289 **Author:** [@GeorgDangl](https://github.com/GeorgDangl) **Created:** 7/11/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `localElectronBuilder` --- ### 📝 Commits (2) - [`ac62f87`](https://github.com/ElectronNET/Electron.NET/commit/ac62f87acbff4c32a7390b6edc062e6905a4dc15) Use local, fixed version for electron-builder instead of global tool - [`bed220f`](https://github.com/ElectronNET/Electron.NET/commit/bed220f5b7c532c4e447f94c1737e0de94adb63d) Add Json escaping for quotes in case custom electron parameters contain quotes ### 📊 Changes **2 files changed** (+11 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+10 -15) 📝 `ElectronNET.CLI/ElectronNET.CLI.csproj` (+1 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:57:39 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1130