starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #313] [MERGED] Update to .NET Core 3.0 #1135

New Issue
Open
opened 2026-01-29 16:57:42 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:57:42 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/313
Author: @robertmuehsig
Created: 10/3/2019
Status: ✅ Merged
Merged: 10/28/2019
Merged by: @robertmuehsig

Base: master ← Head: netcore30

📝 Commits (10+)

📊 Changes

20 files changed (+74 additions, -79 deletions)

View changed files

📝 .travis.yml (+1 -2)
📝 ElectronNET.API/ElectronNET.API.csproj (+13 -7)
➕ ElectronNET.API/PackageIcon.png (+0 -0)
📝 ElectronNET.CLI/Commands/AddCommand.cs (+1 -2)
📝 ElectronNET.CLI/Commands/BuildCommand.cs (+3 -21)
📝 ElectronNET.CLI/Commands/StartElectronCommand.cs (+2 -3)
📝 ElectronNET.CLI/ElectronNET.CLI.csproj (+10 -5)
➕ ElectronNET.CLI/PackageIcon.png (+0 -0)
📝 ElectronNET.WebApp/Controllers/TrayController.cs (+2 -2)
📝 ElectronNET.WebApp/ElectronHostHook/excelCreator.js (+2 -1)
📝 ElectronNET.WebApp/ElectronHostHook/excelCreator.js.map (+1 -1)
📝 ElectronNET.WebApp/ElectronHostHook/index.js (+2 -1)
📝 ElectronNET.WebApp/ElectronHostHook/index.js.map (+1 -1)
📝 ElectronNET.WebApp/ElectronNET.WebApp.csproj (+5 -7)
📝 ElectronNET.WebApp/Program.cs (+2 -0)
📝 ElectronNET.WebApp/Startup.cs (+7 -10)
📝 README.md (+11 -8)
📝 appveyor.yml (+1 -1)
📝 buildAll.cmd (+9 -6)
📝 buildReleaseNuGetPackages.cmd (+1 -1)

📄 Description

Based on this PR https://github.com/ElectronNET/Electron.NET/pull/300 all packages are updated to .NET Core 3.0 + the build files should point to the correct environment.

Not sure if on the NPM part, but we will see what the CI Systems tells us :)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/313 **Author:** [@robertmuehsig](https://github.com/robertmuehsig) **Created:** 10/3/2019 **Status:** ✅ Merged **Merged:** 10/28/2019 **Merged by:** [@robertmuehsig](https://github.com/robertmuehsig) **Base:** `master` ← **Head:** `netcore30` --- ### 📝 Commits (10+) - [`e25b89f`](https://github.com/ElectronNET/Electron.NET/commit/e25b89ff6a36cb1f1576b6583079b353ff3dc931) Update to .NET Core 3.0 - [`b3bb3ce`](https://github.com/ElectronNET/Electron.NET/commit/b3bb3ceb978b03ff6b0eac7ec6c383f8d46a7d65) fix build issues - [`5cd11a8`](https://github.com/ElectronNET/Electron.NET/commit/5cd11a8110160df97bd0c1b74b43477e324eedba) build - [`f1eaffb`](https://github.com/ElectronNET/Electron.NET/commit/f1eaffb2031c62828651e0bbc80aa3aa60ca4dc0) update github sourcelink and framework reference - [`25f35e3`](https://github.com/ElectronNET/Electron.NET/commit/25f35e34fef8392d43e6d176f927fa1c174b781f) global npm outside of build commands - [`8dd5d15`](https://github.com/ElectronNET/Electron.NET/commit/8dd5d1561ac8bd8f1de0907312406d0dd0227292) test - [`b7e7ace`](https://github.com/ElectronNET/Electron.NET/commit/b7e7ace6f360e4c670cfc950f92e31b58873e8ca) fix build issues on windows - [`54ff11a`](https://github.com/ElectronNET/Electron.NET/commit/54ff11acf5f7c18cf5769b00b2733b4cf9bca580) beta... - [`2c14693`](https://github.com/ElectronNET/Electron.NET/commit/2c146934301a31fdc8d7a641ebe1f312104b132e) Merge branch 'master' into netcore30 - [`14d0270`](https://github.com/ElectronNET/Electron.NET/commit/14d02706c0a20b62cefb2f6c3c7eb6725e1282f2) small changes for version stuff ### 📊 Changes **20 files changed** (+74 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -2) 📝 `ElectronNET.API/ElectronNET.API.csproj` (+13 -7) ➕ `ElectronNET.API/PackageIcon.png` (+0 -0) 📝 `ElectronNET.CLI/Commands/AddCommand.cs` (+1 -2) 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+3 -21) 📝 `ElectronNET.CLI/Commands/StartElectronCommand.cs` (+2 -3) 📝 `ElectronNET.CLI/ElectronNET.CLI.csproj` (+10 -5) ➕ `ElectronNET.CLI/PackageIcon.png` (+0 -0) 📝 `ElectronNET.WebApp/Controllers/TrayController.cs` (+2 -2) 📝 `ElectronNET.WebApp/ElectronHostHook/excelCreator.js` (+2 -1) 📝 `ElectronNET.WebApp/ElectronHostHook/excelCreator.js.map` (+1 -1) 📝 `ElectronNET.WebApp/ElectronHostHook/index.js` (+2 -1) 📝 `ElectronNET.WebApp/ElectronHostHook/index.js.map` (+1 -1) 📝 `ElectronNET.WebApp/ElectronNET.WebApp.csproj` (+5 -7) 📝 `ElectronNET.WebApp/Program.cs` (+2 -0) 📝 `ElectronNET.WebApp/Startup.cs` (+7 -10) 📝 `README.md` (+11 -8) 📝 `appveyor.yml` (+1 -1) 📝 `buildAll.cmd` (+9 -6) 📝 `buildReleaseNuGetPackages.cmd` (+1 -1) </details> ### 📄 Description Based on this PR https://github.com/ElectronNET/Electron.NET/pull/300 all packages are updated to .NET Core 3.0 + the build files should point to the correct environment. Not sure if on the NPM part, but we will see what the CI Systems tells us :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:57:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?