mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
[PR #311] [MERGED] Support of AddExtension, RemoveExtension, GetExtensions #1136
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ElectronNET/Electron.NET/pull/311
Author: @Daddoon
Created: 9/26/2019
Status: ✅ Merged
Merged: 11/27/2019
Merged by: @GregorBiswanger
Base:
master← Head:master📝 Commits (6)
ba64639- Added AddExtension, RemoveExtension and GetExtensions methods body8b66bdd- Added BrowserWindow.AddExtension, RemoveExtension, GetExtensions support. Not yet testeda781234- Removed not existent parameter in method declaration of browserWindowGetExtensions in browserWindows.tsa32b50f- Fixed / Updated API for Chrome extensions8bf10c3- Added XML documentation on ChromeExtensionInfo constructor28be0dd- Removed unused variable from a previous attempt.📊 Changes
5 files changed (+353 additions, -213 deletions)
View changed files
📝
ElectronNET.API/BrowserWindow.cs(+53 -0)➕
ElectronNET.API/Entities/ChromeExtensionInfo.cs(+33 -0)📝
ElectronNET.Host/api/browserWindows.js(+244 -212)📝
ElectronNET.Host/api/browserWindows.js.map(+1 -1)📝
ElectronNET.Host/api/browserWindows.ts(+22 -0)📄 Description
This PR add the support of:
I have tested the code on my side by loading the updated ElectronNET.CLI, and tested with the following sample test in Startup.cs:
Attached here, a little Chrome extension created from a Mozilla WebExtension i created for my plugin BlazorMobile. Actually, the running code in this extension should not work as it's specific for a special expected environment, but the goal here is just to test that the Chrome extension load in Electron.
chromextensions.zip
Of course update the AddExtensionAsync with a valid extension folder on your side.
The shown dialog should validate the expected behaviors, according to the method call orders and expected return values.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.