[PR #413] [MERGED] Implementation for electronjs cookie handling #1162

New Issue

claunia · 2026-01-29T16:57:57Z

claunia commented

2026-01-29 16:57:57 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/413
Author: @freosc
Created: 5/22/2020
Status: ✅ Merged
Merged: 5/23/2020
Merged by: @GregorBiswanger

Base: master ← Head: CookieHandling

📝 Commits (1)

d409c3a Implementation for electronjs cookie handling

📊 Changes

9 files changed (+413 additions, -1 deletions)

View changed files

➕ ElectronNET.API/Cookies.cs (+154 -0)
➕ ElectronNET.API/Entities/Cookie.cs (+51 -0)
➕ ElectronNET.API/Entities/CookieChangedCause.cs (+38 -0)
➕ ElectronNET.API/Entities/CookieDetails.cs (+56 -0)
➕ ElectronNET.API/Entities/CookieFilter.cs (+43 -0)
📝 ElectronNET.API/Session.cs (+6 -0)
📝 ElectronNET.Host/api/webContents.js (+27 -0)
📝 ElectronNET.Host/api/webContents.js.map (+1 -1)
📝 ElectronNET.Host/api/webContents.ts (+37 -0)

📄 Description

I needed cookie handling in my app, so decided to implement the electronjs's session cookie handling in Electron.Net and here's the pull request (actually my first github pull request ever ;) )
I tried to use your coding standards as much as possible.
Properties might need extra decorators or default values, not sure about them.

I only tested roughly the OnChanged, Get and Set
Important for the Set method is that the URL needs to be filled in. ElectronJS doc is quite clear on that, and I copied the comments.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/413 **Author:** [@freosc](https://github.com/freosc) **Created:** 5/22/2020 **Status:** ✅ Merged **Merged:** 5/23/2020 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `CookieHandling` --- ### 📝 Commits (1) - [`d409c3a`](https://github.com/ElectronNET/Electron.NET/commit/d409c3a0f9d794727297f7dbcf1d013c00ad8278) Implementation for electronjs cookie handling ### 📊 Changes **9 files changed** (+413 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `ElectronNET.API/Cookies.cs` (+154 -0) ➕ `ElectronNET.API/Entities/Cookie.cs` (+51 -0) ➕ `ElectronNET.API/Entities/CookieChangedCause.cs` (+38 -0) ➕ `ElectronNET.API/Entities/CookieDetails.cs` (+56 -0) ➕ `ElectronNET.API/Entities/CookieFilter.cs` (+43 -0) 📝 `ElectronNET.API/Session.cs` (+6 -0) 📝 `ElectronNET.Host/api/webContents.js` (+27 -0) 📝 `ElectronNET.Host/api/webContents.js.map` (+1 -1) 📝 `ElectronNET.Host/api/webContents.ts` (+37 -0) </details> ### 📄 Description I needed cookie handling in my app, so decided to implement the electronjs's session cookie handling in Electron.Net and here's the pull request (actually my first github pull request ever ;) ) I tried to use your coding standards as much as possible. Properties might need extra decorators or default values, not sure about them. I only tested roughly the OnChanged, Get and Set Important for the Set method is that the URL needs to be filled in. ElectronJS doc is quite clear on that, and I copied the comments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:57:57 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1162