[PR #430] [MERGED] HostHook.CallAsync should use TaskCompletionSource.SetException instead of throwing exception #1178

New Issue

claunia · 2026-01-29T16:58:07Z

claunia commented

2026-01-29 16:58:07 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/430
Author: @freosc
Created: 6/12/2020
Status: ✅ Merged
Merged: 6/12/2020
Merged by: @GregorBiswanger

Base: master ← Head: master

📝 Commits (3)

1238854 Merge pull request #1 from freosc/CookieHandling
519fb53 Merge pull request #2 from ElectronNET/master
37ae869 HostHook CallAsync

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 ElectronNET.API/HostHook.cs (+4 -2)

📄 Description

Actually, this pattern should be updated in the rest of the code as well.
Anywhere you use a TaskCompletionSource, you have to make sure the setResult or setException is called, otherwise the calling code will await forever.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/430 **Author:** [@freosc](https://github.com/freosc) **Created:** 6/12/2020 **Status:** ✅ Merged **Merged:** 6/12/2020 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`1238854`](https://github.com/ElectronNET/Electron.NET/commit/12388541aba7598b9623390dd830439cdd5f102e) Merge pull request #1 from freosc/CookieHandling - [`519fb53`](https://github.com/ElectronNET/Electron.NET/commit/519fb53c00a33662adb26a5ec68e74ba8b2ffbbc) Merge pull request #2 from ElectronNET/master - [`37ae869`](https://github.com/ElectronNET/Electron.NET/commit/37ae869dcbd637e250ab0758e1a914dc7d7ea87d) HostHook CallAsync ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/HostHook.cs` (+4 -2) </details> ### 📄 Description Actually, this pattern should be updated in the rest of the code as well. Anywhere you use a TaskCompletionSource, you have to make sure the setResult or setException is called, otherwise the calling code will await forever. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:07 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1178