[PR #486] [MERGED] 442: maintain references between socket.io connection events #1197

New Issue

claunia · 2026-01-29T16:58:19Z

claunia commented

2026-01-29 16:58:19 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/486
Author: @danatcofo
Created: 10/6/2020
Status: ✅ Merged
Merged: 1/11/2021
Merged by: @GregorBiswanger

Base: master ← Head: bug/442

📝 Commits (2)

e73655b 442: maintain references between socket.io connection events
d2f6308 Merge remote-tracking branch 'upstream/master' into bug/442

📊 Changes

8 files changed (+133 additions, -142 deletions)

View changed files

📝 ElectronNET.Host/api/browserView.ts (+1 -1)
📝 ElectronNET.Host/api/browserWindows.ts (+1 -1)
📝 ElectronNET.Host/api/menu.ts (+1 -1)
📝 ElectronNET.Host/api/notification.js (+14 -15)
📝 ElectronNET.Host/api/notification.ts (+1 -1)
📝 ElectronNET.Host/api/tray.js (+52 -53)
📝 ElectronNET.Host/api/tray.ts (+29 -29)
📝 ElectronNET.Host/main.js (+34 -41)

📄 Description

fixes #442

remove deletes of modules during disconnect
add delete of hostHook during disconnect
check if modules exist before importing them during connect
move local caches of modules into global scope.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/486 **Author:** [@danatcofo](https://github.com/danatcofo) **Created:** 10/6/2020 **Status:** ✅ Merged **Merged:** 1/11/2021 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `bug/442` --- ### 📝 Commits (2) - [`e73655b`](https://github.com/ElectronNET/Electron.NET/commit/e73655bd688e59216a49593aa26eece598fde839) 442: maintain references between socket.io connection events - [`d2f6308`](https://github.com/ElectronNET/Electron.NET/commit/d2f6308dd23302629683ebaf52d6f723b8ff1643) Merge remote-tracking branch 'upstream/master' into bug/442 ### 📊 Changes **8 files changed** (+133 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.Host/api/browserView.ts` (+1 -1) 📝 `ElectronNET.Host/api/browserWindows.ts` (+1 -1) 📝 `ElectronNET.Host/api/menu.ts` (+1 -1) 📝 `ElectronNET.Host/api/notification.js` (+14 -15) 📝 `ElectronNET.Host/api/notification.ts` (+1 -1) 📝 `ElectronNET.Host/api/tray.js` (+52 -53) 📝 `ElectronNET.Host/api/tray.ts` (+29 -29) 📝 `ElectronNET.Host/main.js` (+34 -41) </details> ### 📄 Description fixes #442 remove deletes of modules during disconnect add delete of hostHook during disconnect check if modules exist before importing them during connect move local caches of modules into global scope. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:19 +00:00

claunia closed this issue

2026-01-29 16:58:19 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1197