[PR #540] [MERGED] Resolve #539, #357 - Fix splash screen interaction causing crashes, ghost dragging, and resizable behavior #1207

Open
opened 2026-01-29 16:58:25 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/540
Author: @indiemini
Created: 2/17/2021
Status: Merged
Merged: 7/1/2021
Merged by: @GregorBiswanger

Base: masterHead: master


📝 Commits (3)

📊 Changes

2 files changed (+7 additions, -6 deletions)

View changed files

📝 ElectronNET.Host/main.js (+5 -4)
📝 ElectronNET.Host/splashscreen/index.html (+2 -2)

📄 Description

Resolves #539, #357

Using the browser-window-focus event would cause the splashScreen window to be destroyed early (since regular mouse-focus events would cause the event to be fired).

Switching to the browser-window-created event produces the correct behavior.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/540 **Author:** [@indiemini](https://github.com/indiemini) **Created:** 2/17/2021 **Status:** ✅ Merged **Merged:** 7/1/2021 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`4596492`](https://github.com/ElectronNET/Electron.NET/commit/4596492cd953034f11fc776031521c2ccc4f5cd7) Fix splash screen interaction causing crashes, fix splash screen content ghost drag, fix resizable splash screen. Resolves #539, #357 - [`7e49451`](https://github.com/ElectronNET/Electron.NET/commit/7e494518f3f7da48d76cf187e362d2c4408f3689) Fully ignore mouse events on splash screen (avoids drag + drop file into window) - [`55a3f10`](https://github.com/ElectronNET/Electron.NET/commit/55a3f10d37f6ca0ca917c37f9b67facf3ac612a1) Splash screen always renders on top ### 📊 Changes **2 files changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.Host/main.js` (+5 -4) 📝 `ElectronNET.Host/splashscreen/index.html` (+2 -2) </details> ### 📄 Description Resolves #539, #357 Using the `browser-window-focus` event would cause the splashScreen window to be destroyed early (since regular mouse-focus events would cause the event to be fired). Switching to the `browser-window-created` event produces the correct behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:58:25 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1207