[PR #531] [MERGED] fixes #523 allow for property overrides to be passed in #1208

New Issue

claunia · 2026-01-29T16:58:25Z

claunia commented

2026-01-29 16:58:25 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/531
Author: @danatcofo
Created: 1/25/2021
Status: ✅ Merged
Merged: 7/1/2021
Merged by: @GregorBiswanger

Base: master ← Head: issue/523

📝 Commits (2)

5d90786 Bump socket.io from 2.2.0 to 2.4.0 in /ElectronNET.Host
dd5bfd3 Pass dotnet publsh /p: arguments to the publish command

📊 Changes

4 files changed (+148 additions, -1925 deletions)

View changed files

📝 ElectronNET.CLI/Commands/BuildCommand.cs (+49 -20)
📝 ElectronNET.CLI/SimpleCommandLineParser.cs (+17 -1)
📝 ElectronNET.Host/package-lock.json (+81 -1903)
📝 ElectronNET.Host/package.json (+1 -1)

📄 Description

Use /p:propertyName=value or /property:propertyName=value to pass in property overrides. This is equivalent to the -p: option documented here.

https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-publish

fixes #523

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/531 **Author:** [@danatcofo](https://github.com/danatcofo) **Created:** 1/25/2021 **Status:** ✅ Merged **Merged:** 7/1/2021 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `issue/523` --- ### 📝 Commits (2) - [`5d90786`](https://github.com/ElectronNET/Electron.NET/commit/5d907864d84ffe791f35b777214f50aaeb2836af) Bump socket.io from 2.2.0 to 2.4.0 in /ElectronNET.Host - [`dd5bfd3`](https://github.com/ElectronNET/Electron.NET/commit/dd5bfd3961ac353e735ae1aa6f7ff06b8791b2b0) Pass dotnet publsh /p: arguments to the publish command ### 📊 Changes **4 files changed** (+148 additions, -1925 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+49 -20) 📝 `ElectronNET.CLI/SimpleCommandLineParser.cs` (+17 -1) 📝 `ElectronNET.Host/package-lock.json` (+81 -1903) 📝 `ElectronNET.Host/package.json` (+1 -1) </details> ### 📄 Description Use `/p:propertyName=value` or `/property:propertyName=value` to pass in property overrides. This is equivalent to the `-p:` option documented here. https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-publish fixes #523 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:25 +00:00

claunia closed this issue

2026-01-29 16:58:26 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1208