[PR #573] [MERGED] Vibrancy serialization fix #1218

New Issue

claunia · 2026-01-29T16:58:33Z

claunia commented

2026-01-29 16:58:33 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/573
Author: @tantumalice
Created: 6/14/2021
Status: ✅ Merged
Merged: 7/1/2021
Merged by: @GregorBiswanger

Base: master ← Head: serialization-fix

📝 Commits (1)

cd9e06d Vibrancy serialization fix

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 ElectronNET.API/Entities/Vibrancy.cs (+4 -4)

📄 Description

Noticed that Vibrancy serialization works incorrect. It may lead to crash on macOS if incorrectly serialized values are used. I've tested it. Application crashed.
Json property attributes are ignored because they are placed too deep. This changes will fix that.

You may read about custom enum values names serialization here (random article about it) or somewhere else.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/573 **Author:** [@tantumalice](https://github.com/tantumalice) **Created:** 6/14/2021 **Status:** ✅ Merged **Merged:** 7/1/2021 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `serialization-fix` --- ### 📝 Commits (1) - [`cd9e06d`](https://github.com/ElectronNET/Electron.NET/commit/cd9e06d5dbfcacbe2cdaeef7667310dc4e18cd21) Vibrancy serialization fix ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/Entities/Vibrancy.cs` (+4 -4) </details> ### 📄 Description Noticed that Vibrancy serialization works incorrect. It may lead to crash on macOS if incorrectly serialized values are used. I've tested it. Application crashed. Json property attributes are ignored because they are placed too deep. This changes will fix that. You may read about custom enum values names serialization [here](https://automationrhapsody.com/serialize-and-deserialize-enum-values-to-custom-string-in-c-with-json-net/) (random article about it) or somewhere else. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:33 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1218