starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #579] [MERGED] Upgrade to use Electron 12.0.12 #1220

New Issue
Open
opened 2026-01-29 16:58:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:58:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/579
Author: @tub5
Created: 6/28/2021
Status: ✅ Merged
Merged: 7/1/2021
Merged by: @GregorBiswanger

Base: master ← Head: bug/578

📝 Commits (3)

  • fb8ca94 Upgrade to use Electron 12.0.12
  • 476cc9e Updating ContextIsolation as per the comment from @danatcofo. "on electron v12 WebPreferences.contextIsolation defaults to true… this means that window.require() will no longer function"
  • 78d9d60 Merge branch 'master' into bug/578

📊 Changes

4 files changed (+1792 additions, -11 deletions)

View changed files

📝 ElectronNET.API/Entities/WebPreferences.cs (+2 -2)
📝 ElectronNET.CLI/Commands/BuildCommand.cs (+1 -1)
📝 ElectronNET.Host/package-lock.json (+1788 -7)
📝 ElectronNET.Host/package.json (+1 -1)

📄 Description

Upgrade the ElectronNET.CLI to use Electron v12.0.12 to prevent crashing when the auto update feature is used.

Resolves #578

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/579 **Author:** [@tub5](https://github.com/tub5) **Created:** 6/28/2021 **Status:** ✅ Merged **Merged:** 7/1/2021 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `bug/578` --- ### 📝 Commits (3) - [`fb8ca94`](https://github.com/ElectronNET/Electron.NET/commit/fb8ca94e8e22c207227da57d28fec50ce235cd91) Upgrade to use Electron 12.0.12 - [`476cc9e`](https://github.com/ElectronNET/Electron.NET/commit/476cc9e5057d3411b570c518b6b0de545c89dfd6) Updating ContextIsolation as per the comment from @danatcofo. "on electron v12 WebPreferences.contextIsolation defaults to true… this means that window.require() will no longer function" - [`78d9d60`](https://github.com/ElectronNET/Electron.NET/commit/78d9d601b16ed1eba89a5b4a968b24eb3b9de025) Merge branch 'master' into bug/578 ### 📊 Changes **4 files changed** (+1792 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/Entities/WebPreferences.cs` (+2 -2) 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+1 -1) 📝 `ElectronNET.Host/package-lock.json` (+1788 -7) 📝 `ElectronNET.Host/package.json` (+1 -1) </details> ### 📄 Description Upgrade the ElectronNET.CLI to use Electron v12.0.12 to prevent crashing when the auto update feature is used. Resolves #578 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:58:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1220
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?