mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
[PR #624] [MERGED] Support Apple Silicon Natively #1231
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ElectronNET/Electron.NET/pull/624
Author: @bman46
Created: 11/21/2021
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @GregorBiswanger
Base:
master← Head:master📝 Commits (9)
438c8e1Switch from dotnet 5.0 to dotnet 6.05dbe62bAdd osx-arm64 support to electronize command07d6fedFix for build command4ba8d9bAdd fix for Apple Silicon to build commande0e8572Update README.md1d9e540Change back to dotnet 5e4deba2Add dotnet 6 check7e89e27Better way to check versionb08a075Revert automatic change by VS📊 Changes
3 files changed (+76 additions, -4 deletions)
View changed files
📝
ElectronNET.CLI/Commands/Actions/GetTargetPlatformInformation.cs(+66 -3)📝
ElectronNET.CLI/Commands/BuildCommand.cs(+6 -0)📝
README.md(+4 -1)📄 Description
While the current version works well with Rosetta 2, it is beneficial to be able to compile natively for ARM/Apple Silicon.
One issue that I would like input on is the switch from dotnet 5 to 6 for the CLI tools. Dotnet 6 is the minimum version to be able to target
osx-arm64and switching the CLI tools to 6 allows for the tools to be compiled and run natively on arm. The changes that I made should still work fine with dotnet 5 and be able to compile forosx-arm64as long as dotnet 6 is also installed. It may also make more sense for this upgrade to be a separate pull request and upgrade all of the projects together to dotnet 6.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.