[PR #626] [MERGED] Allow ignoring certificate errors #1233

New Issue

claunia · 2026-01-29T16:58:42Z

claunia commented

2026-01-29 16:58:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/626
Author: @javierlarota
Created: 11/26/2021
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @GregorBiswanger

Base: master ← Head: feature/ignore-cert-errors

📝 Commits (2)

d9d655c Allow ignoring certificate errors when using an untrusted self-signed certificate for https communication with the AspCore backend.
431e401 Feedback from code review. Improving logging of the domain names that will be ignored.

📊 Changes

1 file changed (+34 additions, -1 deletions)

View changed files

📝 ElectronNET.Host/main.js (+34 -1)

📄 Description

The Electron app fails when using a self-signed certificate for https communications with its ASP.NET Core backend. The native electron framework allows to ignore or bypass certificate errors. I am exposing this feature to Electron.NET

There will be two ways to bypass certificate errors:

By adding this flag to the electron.manifest.json file: "ignoreAllCertificateErrors": true it will allow to ignore all cert errors. This option is less secure
By adding a list of domain names that we want to ignore certificate errors for in the electron.manifest.json file:

  "domainNamesToIgnoreCertificateErrors": [
    "localhost",
    "127.0.0.1",
    "www.insecure.site.com"
  ],

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/626 **Author:** [@javierlarota](https://github.com/javierlarota) **Created:** 11/26/2021 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `feature/ignore-cert-errors` --- ### 📝 Commits (2) - [`d9d655c`](https://github.com/ElectronNET/Electron.NET/commit/d9d655cae89a0e481e796cf3fc62058c13e1baa2) Allow ignoring certificate errors when using an untrusted self-signed certificate for https communication with the AspCore backend. - [`431e401`](https://github.com/ElectronNET/Electron.NET/commit/431e4014516df296d278e454e7363f42e6058227) Feedback from code review. Improving logging of the domain names that will be ignored. ### 📊 Changes **1 file changed** (+34 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.Host/main.js` (+34 -1) </details> ### 📄 Description The Electron app fails when using a self-signed certificate for https communications with its ASP.NET Core backend. The native electron framework allows to ignore or bypass certificate errors. I am exposing this feature to Electron.NET There will be two ways to bypass certificate errors: 1. By adding this flag to the electron.manifest.json file: `"ignoreAllCertificateErrors": true` it will allow to ignore all cert errors. This option is less secure 2. By adding a list of domain names that we want to ignore certificate errors for in the electron.manifest.json file: ``` "domainNamesToIgnoreCertificateErrors": [ "localhost", "127.0.0.1", "www.insecure.site.com" ], ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:42 +00:00

claunia closed this issue

2026-01-29 16:58:43 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1233