mirror of
https://github.com/ElectronNET/Electron.NET.git
synced 2026-02-03 21:25:13 +00:00
[PR #655] [MERGED] Support for additional dotnet publish flags. #1240
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ElectronNET/Electron.NET/pull/655
Author: @danatcofo
Created: 1/21/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @GregorBiswanger
Base:
master← Head:feature/dotnet-args📝 Commits (2)
4790c4eSupport for additional dotnet publish flags.5338749Fixed extraction of arguments📊 Changes
2 files changed (+62 additions, -1 deletions)
View changed files
📝
ElectronNET.CLI/Commands/BuildCommand.cs(+47 -1)📝
README.md(+15 -0)📄 Description
Many build scenarios and scripts require certain flags to succeed. For example
nuget restoremight be required prior to runningelectronize buildand support for the--no-restoreflag in the generated publish command is required.This PR adds the capability to add any of the dotnet publish flags to the
electronize buildcommand by appending the command with-- [--dotnet-publish-flag(s)]Backwards compatibility to keep current builds running is maintained by adding the
--self-containedflag if not present or overridden by--self-contained false|--no-self-contained. Additionally any other flags that are already built into the design of the command are ignored or stripped.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.