[PR #655] [MERGED] Support for additional dotnet publish flags. #1240

Open
opened 2026-01-29 16:58:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/655
Author: @danatcofo
Created: 1/21/2022
Status: Merged
Merged: 4/6/2022
Merged by: @GregorBiswanger

Base: masterHead: feature/dotnet-args


📝 Commits (2)

  • 4790c4e Support for additional dotnet publish flags.
  • 5338749 Fixed extraction of arguments

📊 Changes

2 files changed (+62 additions, -1 deletions)

View changed files

📝 ElectronNET.CLI/Commands/BuildCommand.cs (+47 -1)
📝 README.md (+15 -0)

📄 Description

Many build scenarios and scripts require certain flags to succeed. For example nuget restore might be required prior to running electronize build and support for the --no-restore flag in the generated publish command is required.

This PR adds the capability to add any of the dotnet publish flags to the electronize build command by appending the command with -- [--dotnet-publish-flag(s)]

Backwards compatibility to keep current builds running is maintained by adding the --self-contained flag if not present or overridden by --self-contained false|--no-self-contained. Additionally any other flags that are already built into the design of the command are ignored or stripped.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/655 **Author:** [@danatcofo](https://github.com/danatcofo) **Created:** 1/21/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `feature/dotnet-args` --- ### 📝 Commits (2) - [`4790c4e`](https://github.com/ElectronNET/Electron.NET/commit/4790c4ebb2b6e2baa706cc47b3e0c6d72e4aab34) Support for additional dotnet publish flags. - [`5338749`](https://github.com/ElectronNET/Electron.NET/commit/5338749e4d2b0fcd9c46bad1a61e5c7d7d0f18cc) Fixed extraction of arguments ### 📊 Changes **2 files changed** (+62 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+47 -1) 📝 `README.md` (+15 -0) </details> ### 📄 Description Many build scenarios and scripts require certain flags to succeed. For example `nuget restore` might be required prior to running `electronize build` and support for the `--no-restore` flag in the generated publish command is required. This PR adds the capability to add any of the dotnet publish flags to the `electronize build` command by appending the command with `-- [--dotnet-publish-flag(s)]` Backwards compatibility to keep current builds running is maintained by adding the `--self-contained` flag if not present or overridden by `--self-contained false|--no-self-contained`. Additionally any other flags that are already built into the design of the command are ignored or stripped. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:58:50 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1240