starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #656] [MERGED] Support DI and Mocking better + Support launching app with file for win and linux #1243

New Issue
Open
opened 2026-01-29 16:58:51 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:58:51 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/656
Author: @danatcofo
Created: 1/25/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @GregorBiswanger

Base: master ← Head: feature/DI-MOC-Process

📝 Commits (10+)

  • 1b14bb0 Convert main static references off of Electron into interface implementation and expose the underlying Socket for low level interaction.
  • 8e1e184 #647 process argv for open-file for win and linux
  • 1406fc1 #647 add initial Process class to ElectronNET.API
  • 562cccb #647 add to ElectronNET.API Process member interfaces for argv and type
  • ba82b9a #647 add to ElectronNET.API Process member interfaces for various fields
  • 5921481 #647 correct to ElectronNET.API Process member for versions field
  • 24a2005 #647 update XML documentation to ElectronNET.API Process members
  • 64e058b #647 make ProcessVersions Entity a record to ensure readonly access to props
  • 1767bcd Merge commit '64e058b0b59a4fbbd6c0ec9de2ee1850a66684c4' into feature/DI-MOC-Process
  • b8845bb Include Process into DI Mocking and interfaces

📊 Changes

47 files changed (+2504 additions, -34 deletions)

View changed files

📝 ElectronNET.API/App.cs (+2 -1)
➕ ElectronNET.API/ApplicationSocket.cs (+16 -0)
📝 ElectronNET.API/AutoUpdater.cs (+2 -1)
📝 ElectronNET.API/BridgeConnector.cs (+109 -1)
📝 ElectronNET.API/Clipboard.cs (+2 -1)
📝 ElectronNET.API/Dialog.cs (+2 -1)
📝 ElectronNET.API/Dock.cs (+2 -1)
📝 ElectronNET.API/Electron.cs (+5 -0)
📝 ElectronNET.API/ElectronNET.API.csproj (+0 -0)
➕ ElectronNET.API/Entities/ProcessVersions.cs (+10 -0)
📝 ElectronNET.API/GlobalShortcut.cs (+2 -1)
📝 ElectronNET.API/HostHook.cs (+2 -1)
➕ ElectronNET.API/Interfaces/IApp.cs (+713 -0)
➕ ElectronNET.API/Interfaces/IApplicationSocket.cs (+15 -0)
➕ ElectronNET.API/Interfaces/IAutoUpdater.cs (+146 -0)
➕ ElectronNET.API/Interfaces/IClipboard.cs (+122 -0)
➕ ElectronNET.API/Interfaces/IDialog.cs (+102 -0)
➕ ElectronNET.API/Interfaces/IDock.cs (+93 -0)
➕ ElectronNET.API/Interfaces/IGlobalShortcut.cs (+39 -0)
➕ ElectronNET.API/Interfaces/IHostHook.cs (+30 -0)

...and 27 more files

📄 Description

This is a combo of #648 & #633 that have conflicts natively with those conflict's addressed

This adds an IProcess interface and applies it to the Process class as well as includes it into the IServiceCollection extension method.

See the other 2 PR's for details on those.

FYI @GregorBiswanger

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/656 **Author:** [@danatcofo](https://github.com/danatcofo) **Created:** 1/25/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `feature/DI-MOC-Process` --- ### 📝 Commits (10+) - [`1b14bb0`](https://github.com/ElectronNET/Electron.NET/commit/1b14bb0fe56c24330c9d38d3c19ead4da27d2281) Convert main static references off of `Electron` into interface implementation and expose the underlying Socket for low level interaction. - [`8e1e184`](https://github.com/ElectronNET/Electron.NET/commit/8e1e184d1e1ef4682547d2dae8c6e7820eb22d38) #647 process argv for open-file for win and linux - [`1406fc1`](https://github.com/ElectronNET/Electron.NET/commit/1406fc1d798ada0d98e30bf712ce4da491d98f64) #647 add initial Process class to ElectronNET.API - [`562cccb`](https://github.com/ElectronNET/Electron.NET/commit/562cccbfae8a9230aa19490976fb3b39bf79c294) #647 add to ElectronNET.API Process member interfaces for argv and type - [`ba82b9a`](https://github.com/ElectronNET/Electron.NET/commit/ba82b9a600ab9264584b6747af9484868c5bdb79) #647 add to ElectronNET.API Process member interfaces for various fields - [`5921481`](https://github.com/ElectronNET/Electron.NET/commit/592148116bcfc8aa5da2799fa74907f86ccb0d59) #647 correct to ElectronNET.API Process member for versions field - [`24a2005`](https://github.com/ElectronNET/Electron.NET/commit/24a20057761b7ec8e71ccdac8d8e316f428b86e4) #647 update XML documentation to ElectronNET.API Process members - [`64e058b`](https://github.com/ElectronNET/Electron.NET/commit/64e058b0b59a4fbbd6c0ec9de2ee1850a66684c4) #647 make ProcessVersions Entity a record to ensure readonly access to props - [`1767bcd`](https://github.com/ElectronNET/Electron.NET/commit/1767bcd5ada9dd7c6a17d2e5c0e469cc4bd10732) Merge commit '64e058b0b59a4fbbd6c0ec9de2ee1850a66684c4' into feature/DI-MOC-Process - [`b8845bb`](https://github.com/ElectronNET/Electron.NET/commit/b8845bb4026fc3b65fa95b6c572dac4e42acad8b) Include Process into DI Mocking and interfaces ### 📊 Changes **47 files changed** (+2504 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/App.cs` (+2 -1) ➕ `ElectronNET.API/ApplicationSocket.cs` (+16 -0) 📝 `ElectronNET.API/AutoUpdater.cs` (+2 -1) 📝 `ElectronNET.API/BridgeConnector.cs` (+109 -1) 📝 `ElectronNET.API/Clipboard.cs` (+2 -1) 📝 `ElectronNET.API/Dialog.cs` (+2 -1) 📝 `ElectronNET.API/Dock.cs` (+2 -1) 📝 `ElectronNET.API/Electron.cs` (+5 -0) 📝 `ElectronNET.API/ElectronNET.API.csproj` (+0 -0) ➕ `ElectronNET.API/Entities/ProcessVersions.cs` (+10 -0) 📝 `ElectronNET.API/GlobalShortcut.cs` (+2 -1) 📝 `ElectronNET.API/HostHook.cs` (+2 -1) ➕ `ElectronNET.API/Interfaces/IApp.cs` (+713 -0) ➕ `ElectronNET.API/Interfaces/IApplicationSocket.cs` (+15 -0) ➕ `ElectronNET.API/Interfaces/IAutoUpdater.cs` (+146 -0) ➕ `ElectronNET.API/Interfaces/IClipboard.cs` (+122 -0) ➕ `ElectronNET.API/Interfaces/IDialog.cs` (+102 -0) ➕ `ElectronNET.API/Interfaces/IDock.cs` (+93 -0) ➕ `ElectronNET.API/Interfaces/IGlobalShortcut.cs` (+39 -0) ➕ `ElectronNET.API/Interfaces/IHostHook.cs` (+30 -0) _...and 27 more files_ </details> ### 📄 Description This is a combo of #648 & #633 that have conflicts natively with those conflict's addressed This adds an `IProcess` interface and applies it to the Process class as well as includes it into the IServiceCollection extension method. See the other 2 PR's for details on those. FYI @GregorBiswanger --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:58:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?