starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #658] Conversion to use ImageSharp rather than System.Drawing.Common #1246

New Issue
Closed
opened 2026-01-29 16:58:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:58:52 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/ElectronNET/Electron.NET/pull/658

State: closed
Merged: Yes

fixes #637 Conversion to use ImageSharp rather than System.Drawing.Common for cross platform compatibility.

Breaking Changes:

  • System.Drawing.Common is dropped and SixLabors.ImageSharp is introduced.
  • uses of NativeImage.CreateFromBitmap(bitmap, options); is no longer supported, will cause failed builds.

Unexpected Behaviors:

  • uses ToDataUrl will always create png data urls, unexpected output may happen for those that manipulate this output expecting a different data url format.

Obsoletions:

  • CreateFromBitmapOptions & CreateFromBufferOptions have been consolidated into CreateOptions. Implicit conversions added to ease transition.
  • ToBitmapOptions, ToDataUrlOptions, ToPngOptions & BitmapOptions have been consolidated into ImageOptions. Implicit conversions added to ease transition.
**Original Pull Request:** https://github.com/ElectronNET/Electron.NET/pull/658 **State:** closed **Merged:** Yes --- fixes #637 Conversion to use ImageSharp rather than System.Drawing.Common for cross platform compatibility. Breaking Changes: * `System.Drawing.Common` is dropped and `SixLabors.ImageSharp` is introduced. * uses of `NativeImage.CreateFromBitmap(bitmap, options);` is no longer supported, will cause failed builds. Unexpected Behaviors: * uses `ToDataUrl` will always create png data urls, unexpected output may happen for those that manipulate this output expecting a different data url format. Obsoletions: * `CreateFromBitmapOptions` & `CreateFromBufferOptions` have been consolidated into `CreateOptions`. Implicit conversions added to ease transition. * `ToBitmapOptions`, `ToDataUrlOptions`, `ToPngOptions` & `BitmapOptions` have been consolidated into `ImageOptions`. Implicit conversions added to ease transition.
claunia added the pull-request label 2026-01-29 16:58:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?