[PR #709] [CLOSED] Cleaned code and switched to .NET Framework 4.8 #1261

New Issue

claunia · 2026-01-29T16:59:03Z

claunia commented

2026-01-29 16:59:03 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/709
Author: @onionware-github
Created: 7/9/2022
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

db27ff8 Cleaned code and switched to .NET Framework 4.8

📊 Changes

8 files changed (+102 additions, -143 deletions)

View changed files

📝 ElectronNET.CLI/Commands/Actions/DeployEmbeddedElectronFiles.cs (+8 -8)
📝 ElectronNET.CLI/Commands/Actions/DirectoryCopy.cs (+11 -31)
📝 ElectronNET.CLI/Commands/BuildCommand.cs (+3 -6)
📝 ElectronNET.CLI/Commands/StartElectronCommand.cs (+5 -16)
📝 ElectronNET.CLI/EmbeddedFileHelper.cs (+14 -20)
📝 ElectronNET.CLI/ProcessHelper.cs (+44 -54)
📝 ElectronNET.CLI/Program.cs (+2 -8)
➕ ElectronNET.Host/Web.config (+15 -0)

📄 Description

Cleaned some code, changed the .NET Framework version from 4.0 to 4.8 (through Visual Studio).

PS: Directory.Create() only creates a folder if it doesn't already exist. If statements with Directory.Exist are therefore not necessary if a folder is to be created if it does not already exist. I did not find tests for Electron.NET. Please verify that it works with .NET Framework 4.8 as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/709 **Author:** [@onionware-github](https://github.com/onionware-github) **Created:** 7/9/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`db27ff8`](https://github.com/ElectronNET/Electron.NET/commit/db27ff88dfe93b3915ff73ec1b5e5374a2658d48) Cleaned code and switched to .NET Framework 4.8 ### 📊 Changes **8 files changed** (+102 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.CLI/Commands/Actions/DeployEmbeddedElectronFiles.cs` (+8 -8) 📝 `ElectronNET.CLI/Commands/Actions/DirectoryCopy.cs` (+11 -31) 📝 `ElectronNET.CLI/Commands/BuildCommand.cs` (+3 -6) 📝 `ElectronNET.CLI/Commands/StartElectronCommand.cs` (+5 -16) 📝 `ElectronNET.CLI/EmbeddedFileHelper.cs` (+14 -20) 📝 `ElectronNET.CLI/ProcessHelper.cs` (+44 -54) 📝 `ElectronNET.CLI/Program.cs` (+2 -8) ➕ `ElectronNET.Host/Web.config` (+15 -0) </details> ### 📄 Description Cleaned some code, changed the .NET Framework version from 4.0 to 4.8 (through Visual Studio). PS: Directory.Create() only creates a folder if it doesn't already exist. If statements with Directory.Exist are therefore not necessary if a folder is to be created if it does not already exist. I did not find tests for Electron.NET. Please verify that it works with .NET Framework 4.8 as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:03 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1261