[PR #714] [CLOSED] Fixsocketcompilerunbugs #1266

New Issue

claunia · 2026-01-29T16:59:07Z

claunia commented

2026-01-29 16:59:07 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/714
Author: @lafleurh
Created: 7/27/2022
Status: ❌ Closed

Base: master ← Head: fixsocketcompilerunbugs

📝 Commits (4)

43a8941 Fix compile errors
1702cae Bug fixes and best practice changes
fb34847 Remove unnecessary console log
b22ab09 Remove net5-specific webapp

📊 Changes

10 files changed (+103 additions, -27 deletions)

View changed files

📝 ElectronNET.API/App.cs (+22 -0)
📝 ElectronNET.API/ApplicationSocket.cs (+2 -2)
📝 ElectronNET.API/AutoUpdater.cs (+51 -0)
📝 ElectronNET.API/BridgeConnector.cs (+13 -7)
📝 ElectronNET.API/Interfaces/IApplicationSocket.cs (+2 -2)
📝 ElectronNET.API/LifetimeServiceHost.cs (+2 -5)
📝 ElectronNET.API/ServiceCollectionExtensions.cs (+1 -1)
📝 ElectronNET.Host/main.js (+6 -6)
📝 ElectronNET.WebApp/Properties/launchSettings.json (+1 -1)
📝 appveyor.cmd (+3 -3)

📄 Description

The current code on master does not compile and has bugs so the demo did not run. I fixed the issues. Also, cleaned an await call and have the Socket.IO in main.js use code similar to the documentation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/714 **Author:** [@lafleurh](https://github.com/lafleurh) **Created:** 7/27/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fixsocketcompilerunbugs` --- ### 📝 Commits (4) - [`43a8941`](https://github.com/ElectronNET/Electron.NET/commit/43a894180f302dc1417043c2e52f1fa369d65c24) Fix compile errors - [`1702cae`](https://github.com/ElectronNET/Electron.NET/commit/1702cae63fef34d2c321a28ab5d4848d487eb949) Bug fixes and best practice changes - [`fb34847`](https://github.com/ElectronNET/Electron.NET/commit/fb34847a4eb034c46e740e73451ebc99f2d1133c) Remove unnecessary console log - [`b22ab09`](https://github.com/ElectronNET/Electron.NET/commit/b22ab09132c349733bc279c91dadb3aa11f2f31e) Remove net5-specific webapp ### 📊 Changes **10 files changed** (+103 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/App.cs` (+22 -0) 📝 `ElectronNET.API/ApplicationSocket.cs` (+2 -2) 📝 `ElectronNET.API/AutoUpdater.cs` (+51 -0) 📝 `ElectronNET.API/BridgeConnector.cs` (+13 -7) 📝 `ElectronNET.API/Interfaces/IApplicationSocket.cs` (+2 -2) 📝 `ElectronNET.API/LifetimeServiceHost.cs` (+2 -5) 📝 `ElectronNET.API/ServiceCollectionExtensions.cs` (+1 -1) 📝 `ElectronNET.Host/main.js` (+6 -6) 📝 `ElectronNET.WebApp/Properties/launchSettings.json` (+1 -1) 📝 `appveyor.cmd` (+3 -3) </details> ### 📄 Description The current code on master does not compile and has bugs so the demo did not run. I fixed the issues. Also, cleaned an await call and have the Socket.IO in main.js use code similar to the documentation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:07 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1266