[PR #736] [CLOSED] Fixes issue #735 - paths are URL escaped #1269

New Issue

claunia · 2026-01-29T16:59:08Z

claunia commented

2026-01-29 16:59:08 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/736
Author: @cosmo0
Created: 1/18/2023
Status: ❌ Closed

Base: main ← Head: issue-735

📝 Commits (10+)

5f4b162 fix display serialization, serialize only window id when sending ipc message
4fae2ae fix ipc data serialization
c229d49 remove debug message
bb8965f remove semaphore in favor of unique events per window /view create request
47f4516 Add flag to check if the socket is connected
d18700f missing static flag
7f5db58 fix deadlock case on emit before any Socket use
ea40249 refactor Socket to use a task completion source instead of a getter with locks
374d92f don't throw in case the tray was destroyed between calls
236c31a Merge branch 'master' of https://github.com/theolivenbaum/Electron.NET

📊 Changes

243 files changed (+10251 additions, -5293 deletions)

View changed files

➕ .devops/build-nuget.yaml (+84 -0)
📝 .vscode/tasks.json (+10 -5)
➕ .vscode/tasks.json.old (+16 -0)
📝 Changelog.md (+24 -3)
📝 ElectronNET.API/App.cs (+284 -515)
📝 ElectronNET.API/AutoUpdater.cs (+91 -238)
📝 ElectronNET.API/BridgeConnector.cs (+525 -18)
📝 ElectronNET.API/BridgeSettings.cs (+11 -0)
📝 ElectronNET.API/BrowserView.cs (+10 -30)
📝 ElectronNET.API/BrowserWindow.cs (+350 -559)
📝 ElectronNET.API/Clipboard.cs (+26 -118)
📝 ElectronNET.API/CommandLine.cs (+6 -40)
📝 ElectronNET.API/Cookies.cs (+23 -27)
➕ ElectronNET.API/DesktopCapturer.cs (+38 -0)
📝 ElectronNET.API/Dialog.cs (+38 -50)
📝 ElectronNET.API/Dock.cs (+24 -81)
➕ ElectronNET.API/Electron.Experimental.cs (+144 -0)
📝 ElectronNET.API/Electron.cs (+49 -2)
📝 ElectronNET.API/ElectronNET.API.csproj (+16 -8)
📝 ElectronNET.API/Entities/AddRepresentationOptions.cs (+1 -1)

...and 80 more files

📄 Description

When selecting a path with special characters, they might get removed by the folder selection C#-side (see issue #735).

They are URL-decoded inside the ShowOpenDialogAsync method, which doesn't make sense: the decoding, if applicable, should be the responsibility of the JS side.

It's clearly not mandatory because other "dialog" methods, such as ShowSaveDialogAsync, don't use this UrlDecode and work fine.

This PR removes the URL decoding.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/736 **Author:** [@cosmo0](https://github.com/cosmo0) **Created:** 1/18/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `issue-735` --- ### 📝 Commits (10+) - [`5f4b162`](https://github.com/ElectronNET/Electron.NET/commit/5f4b1628e5a111780c0df5cd384e13cdaf607d57) fix display serialization, serialize only window id when sending ipc message - [`4fae2ae`](https://github.com/ElectronNET/Electron.NET/commit/4fae2aeef2a89cf7ffe113c9a5cb537ac9cc2c2c) fix ipc data serialization - [`c229d49`](https://github.com/ElectronNET/Electron.NET/commit/c229d497655fcedec60409d993584f1d30d533cd) remove debug message - [`bb8965f`](https://github.com/ElectronNET/Electron.NET/commit/bb8965fa912ca3dae943b66916ee5d460a0a14c1) remove semaphore in favor of unique events per window /view create request - [`47f4516`](https://github.com/ElectronNET/Electron.NET/commit/47f4516ae25e0dd772990a688505a16c0edf6ee3) Add flag to check if the socket is connected - [`d18700f`](https://github.com/ElectronNET/Electron.NET/commit/d18700f64d0f71ab85b1f0de5a87ae068b840892) missing static flag - [`7f5db58`](https://github.com/ElectronNET/Electron.NET/commit/7f5db58edd0113904e0db4e37071795845eece0f) fix deadlock case on emit before any Socket use - [`ea40249`](https://github.com/ElectronNET/Electron.NET/commit/ea40249a9c4f28740b8fc6d4909cf54fb357f94f) refactor Socket to use a task completion source instead of a getter with locks - [`374d92f`](https://github.com/ElectronNET/Electron.NET/commit/374d92f3b114e91c650ea0848c86e3799cd9ea75) don't throw in case the tray was destroyed between calls - [`236c31a`](https://github.com/ElectronNET/Electron.NET/commit/236c31abe07f2d4f29942433a801363f755708fe) Merge branch 'master' of https://github.com/theolivenbaum/Electron.NET ### 📊 Changes **243 files changed** (+10251 additions, -5293 deletions) <details> <summary>View changed files</summary> ➕ `.devops/build-nuget.yaml` (+84 -0) 📝 `.vscode/tasks.json` (+10 -5) ➕ `.vscode/tasks.json.old` (+16 -0) 📝 `Changelog.md` (+24 -3) 📝 `ElectronNET.API/App.cs` (+284 -515) 📝 `ElectronNET.API/AutoUpdater.cs` (+91 -238) 📝 `ElectronNET.API/BridgeConnector.cs` (+525 -18) 📝 `ElectronNET.API/BridgeSettings.cs` (+11 -0) 📝 `ElectronNET.API/BrowserView.cs` (+10 -30) 📝 `ElectronNET.API/BrowserWindow.cs` (+350 -559) 📝 `ElectronNET.API/Clipboard.cs` (+26 -118) 📝 `ElectronNET.API/CommandLine.cs` (+6 -40) 📝 `ElectronNET.API/Cookies.cs` (+23 -27) ➕ `ElectronNET.API/DesktopCapturer.cs` (+38 -0) 📝 `ElectronNET.API/Dialog.cs` (+38 -50) 📝 `ElectronNET.API/Dock.cs` (+24 -81) ➕ `ElectronNET.API/Electron.Experimental.cs` (+144 -0) 📝 `ElectronNET.API/Electron.cs` (+49 -2) 📝 `ElectronNET.API/ElectronNET.API.csproj` (+16 -8) 📝 `ElectronNET.API/Entities/AddRepresentationOptions.cs` (+1 -1) _...and 80 more files_ </details> ### 📄 Description When selecting a path with special characters, they might get removed by the folder selection C#-side (see issue #735). They are URL-decoded inside the `ShowOpenDialogAsync` method, which doesn't make sense: the decoding, if applicable, should be the responsibility of the JS side. It's clearly not mandatory because other "dialog" methods, such as `ShowSaveDialogAsync`, don't use this `UrlDecode` and work fine. This PR removes the URL decoding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:08 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1269