[PR #758] [MERGED] Fixes issue #735 - paths are URL escaped #1277

New Issue

claunia · 2026-01-29T16:59:13Z

claunia commented

2026-01-29 16:59:13 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/758
Author: @cosmo0
Created: 4/3/2023
Status: ✅ Merged
Merged: 4/3/2023
Merged by: @GregorBiswanger

Base: main ← Head: patch-1

📝 Commits (1)

1ae2f1d Fixes issue #735 - paths are URL escaped

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 ElectronNET.API/Dialog.cs (+1 -6)

📄 Description

When selecting a path with special characters, they might get removed by the folder selection C#-side (see issue https://github.com/ElectronNET/Electron.NET/issues/735).

They are URL-decoded inside the ShowOpenDialogAsync method, which doesn't make sense: the decoding, if applicable, should be the responsibility of the JS side.

It's clearly not mandatory because other "dialog" methods, such as ShowSaveDialogAsync, don't use this UrlDecode and work fine.

This PR removes the URL decoding.

Re-creation of PR #736

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/758 **Author:** [@cosmo0](https://github.com/cosmo0) **Created:** 4/3/2023 **Status:** ✅ Merged **Merged:** 4/3/2023 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`1ae2f1d`](https://github.com/ElectronNET/Electron.NET/commit/1ae2f1de932ec79a8bbbd6c8a1b6841006893d8e) Fixes issue #735 - paths are URL escaped ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/Dialog.cs` (+1 -6) </details> ### 📄 Description When selecting a path with special characters, they might get removed by the folder selection C#-side (see issue https://github.com/ElectronNET/Electron.NET/issues/735). They are URL-decoded inside the ShowOpenDialogAsync method, which doesn't make sense: the decoding, if applicable, should be the responsibility of the JS side. It's clearly not mandatory because other "dialog" methods, such as ShowSaveDialogAsync, don't use this UrlDecode and work fine. This PR removes the URL decoding. Re-creation of PR #736 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:13 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1277