[PR #758] Fixes issue #735 - paths are URL escaped #1282

New Issue

claunia · 2026-01-29T16:59:14Z

claunia commented

2026-01-29 16:59:14 +00:00

Original Pull Request: https://github.com/ElectronNET/Electron.NET/pull/758

State: closed
Merged: Yes

When selecting a path with special characters, they might get removed by the folder selection C#-side (see issue https://github.com/ElectronNET/Electron.NET/issues/735).

They are URL-decoded inside the ShowOpenDialogAsync method, which doesn't make sense: the decoding, if applicable, should be the responsibility of the JS side.

It's clearly not mandatory because other "dialog" methods, such as ShowSaveDialogAsync, don't use this UrlDecode and work fine.

This PR removes the URL decoding.

Re-creation of PR #736

**Original Pull Request:** https://github.com/ElectronNET/Electron.NET/pull/758 **State:** closed **Merged:** Yes --- When selecting a path with special characters, they might get removed by the folder selection C#-side (see issue https://github.com/ElectronNET/Electron.NET/issues/735). They are URL-decoded inside the ShowOpenDialogAsync method, which doesn't make sense: the decoding, if applicable, should be the responsibility of the JS side. It's clearly not mandatory because other "dialog" methods, such as ShowSaveDialogAsync, don't use this UrlDecode and work fine. This PR removes the URL decoding. Re-creation of PR #736

claunia added the pull-request label 2026-01-29 16:59:14 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1282