starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-04 05:34:51 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #814] [CLOSED] Enhanced TypeScript Development Conformity and Build Flexibility #1306

New Issue
Open
opened 2026-01-29 16:59:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:59:31 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/814
Author: @Sieluna
Created: 9/26/2023
Status: ❌ Closed

Base: main ← Head: js-lint

📝 Commits (7)

  • f24f1f9 Normalize code style and restructure project
  • 3a11bc3 Fix unreasonable executablePath profile
  • d771e15 Implement build helper and auto rename
  • 8cdeb86 Force electron-builder install locally
  • 9cca237 Fix build error and command error
  • 6f868ce Fix image load incorrect and modified html code
  • f6cbba7 Fix rendering of C# code block in HTML

📊 Changes

88 files changed (+4393 additions, -6250 deletions)

View changed files

➕ src/ElectronNET.CLI/Commands/Actions/DeployElectronHostHook.cs (+29 -0)
📝 src/ElectronNET.CLI/Commands/Actions/DeployEmbeddedElectronFiles.cs (+20 -47)
➕ src/ElectronNET.CLI/Commands/Actions/DirectoryDelete.cs (+31 -0)
📝 src/ElectronNET.CLI/Commands/AddCommand.cs (+3 -5)
📝 src/ElectronNET.CLI/Commands/BuildCommand.cs (+176 -124)
📝 src/ElectronNET.CLI/Commands/InitCommand.cs (+102 -96)
📝 src/ElectronNET.CLI/Commands/StartElectronCommand.cs (+37 -96)
📝 src/ElectronNET.CLI/ElectronNET.CLI.csproj (+7 -30)
📝 src/ElectronNET.CLI/EmbeddedFileHelper.cs (+53 -0)
📝 src/ElectronNET.CLI/Properties/launchSettings.json (+5 -0)
📝 src/ElectronNET.Host/.gitignore (+2 -1)
➕ src/ElectronNET.Host/ElectronHostAPI/package.json (+16 -0)
📝 src/ElectronNET.Host/ElectronHostAPI/src/app.ts (+6 -5)
📝 src/ElectronNET.Host/ElectronHostAPI/src/autoUpdater.ts (+4 -3)
📝 src/ElectronNET.Host/ElectronHostAPI/src/browserView.ts (+7 -8)
📝 src/ElectronNET.Host/ElectronHostAPI/src/browserWindows.ts (+20 -17)
📝 src/ElectronNET.Host/ElectronHostAPI/src/clipboard.ts (+4 -3)
📝 src/ElectronNET.Host/ElectronHostAPI/src/commandLine.ts (+4 -3)
📝 src/ElectronNET.Host/ElectronHostAPI/src/dialog.ts (+4 -3)
📝 src/ElectronNET.Host/ElectronHostAPI/src/dock.ts (+3 -2)

...and 68 more files

📄 Description

Description:

I have made efforts to align the project more closely with the community's TypeScript development conventions, thereby making the building process more intuitive.

TODO:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/814 **Author:** [@Sieluna](https://github.com/Sieluna) **Created:** 9/26/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `js-lint` --- ### 📝 Commits (7) - [`f24f1f9`](https://github.com/ElectronNET/Electron.NET/commit/f24f1f9140491ac30066d4ba3b53094af28e1f3c) Normalize code style and restructure project - [`3a11bc3`](https://github.com/ElectronNET/Electron.NET/commit/3a11bc30dff23af609f7d047db5c048b3ed561a4) Fix unreasonable executablePath profile - [`d771e15`](https://github.com/ElectronNET/Electron.NET/commit/d771e154a72513107675d8aacb7fc45ef4aae010) Implement build helper and auto rename - [`8cdeb86`](https://github.com/ElectronNET/Electron.NET/commit/8cdeb86d2024801069de895228cca13cf213165c) Force electron-builder install locally - [`9cca237`](https://github.com/ElectronNET/Electron.NET/commit/9cca237119c7c59286a8101670e58348d0bd5c01) Fix build error and command error - [`6f868ce`](https://github.com/ElectronNET/Electron.NET/commit/6f868ceb0d523477ae7d812b221d1b51c451ef53) Fix image load incorrect and modified html code - [`f6cbba7`](https://github.com/ElectronNET/Electron.NET/commit/f6cbba7634c74699c591cf2135ab50d88e422dda) Fix rendering of C# code block in HTML ### 📊 Changes **88 files changed** (+4393 additions, -6250 deletions) <details> <summary>View changed files</summary> ➕ `src/ElectronNET.CLI/Commands/Actions/DeployElectronHostHook.cs` (+29 -0) 📝 `src/ElectronNET.CLI/Commands/Actions/DeployEmbeddedElectronFiles.cs` (+20 -47) ➕ `src/ElectronNET.CLI/Commands/Actions/DirectoryDelete.cs` (+31 -0) 📝 `src/ElectronNET.CLI/Commands/AddCommand.cs` (+3 -5) 📝 `src/ElectronNET.CLI/Commands/BuildCommand.cs` (+176 -124) 📝 `src/ElectronNET.CLI/Commands/InitCommand.cs` (+102 -96) 📝 `src/ElectronNET.CLI/Commands/StartElectronCommand.cs` (+37 -96) 📝 `src/ElectronNET.CLI/ElectronNET.CLI.csproj` (+7 -30) 📝 `src/ElectronNET.CLI/EmbeddedFileHelper.cs` (+53 -0) 📝 `src/ElectronNET.CLI/Properties/launchSettings.json` (+5 -0) 📝 `src/ElectronNET.Host/.gitignore` (+2 -1) ➕ `src/ElectronNET.Host/ElectronHostAPI/package.json` (+16 -0) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/app.ts` (+6 -5) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/autoUpdater.ts` (+4 -3) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/browserView.ts` (+7 -8) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/browserWindows.ts` (+20 -17) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/clipboard.ts` (+4 -3) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/commandLine.ts` (+4 -3) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/dialog.ts` (+4 -3) 📝 `src/ElectronNET.Host/ElectronHostAPI/src/dock.ts` (+3 -2) _...and 68 more files_ </details> ### 📄 Description ## Description: I have made efforts to align the project more closely with the community's TypeScript development conventions, thereby making the building process more intuitive. TODO: - [x] Separate JS and TS code. - [x] Fix "Execute your own typescript code" not working(#815) - [x] Update electron from 13 to16 - [x] Improve build command C# code. - [x] Move JS build-helper to C# https://github.com/ElectronNET/Electron.NET/blob/23f4d39a30b781bb2b179bb1e3826db3cbb00867/src/ElectronNET.CLI/Commands/BuildCommand.cs#L185 - [x] Improve safety access and create folder - [x] Improve start command C# code. - [x] Improve JS build logic - [x] Improve init command C# code - [x] Modified unstable EditLaunchSettings function https://github.com/ElectronNET/Electron.NET/blob/23f4d39a30b781bb2b179bb1e3826db3cbb00867/src/ElectronNET.CLI/Commands/InitCommand.cs#L103-L106 - [ ] Improve add command C# code - [ ] Replace by parser https://github.com/ElectronNET/Electron.NET/blob/23f4d39a30b781bb2b179bb1e3826db3cbb00867/src/ElectronNET.CLI/Commands/AddCommand.cs#L46 - [ ] Improve build performance - [ ] Parallel build C# and JS - [ ] (Need some more advices) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:59:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?