[PR #828] [MERGED] Update Display.cs to current spec #1311

New Issue

claunia · 2026-01-29T16:59:33Z

claunia commented

2026-01-29 16:59:33 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/828
Author: @Yuvix25
Created: 1/10/2024
Status: ✅ Merged
Merged: 2/14/2024
Merged by: @FlorianRappl

Base: main ← Head: yuvix25/update-display-object

📝 Commits (1)

b8b634b update display.cs to current spec

📊 Changes

1 file changed (+46 additions, -6 deletions)

View changed files

📝 src/ElectronNET.API/Entities/Display.cs (+46 -6)

📄 Description

As you can see here, the current Display.cs file in Electron.NET is not up to date. I've added all the missing fields (except for those which show up in the docs, but do not actually appear in the object we fetch from electron), and checked locally to see that it works.

One thing to note is that I did not change the Id value from string to int, because that caused the Electron.Screen.GetAllDisplaysAsync() method to hang forever, and changing it also means breaking backwards compatibility.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/828 **Author:** [@Yuvix25](https://github.com/Yuvix25) **Created:** 1/10/2024 **Status:** ✅ Merged **Merged:** 2/14/2024 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `main` ← **Head:** `yuvix25/update-display-object` --- ### 📝 Commits (1) - [`b8b634b`](https://github.com/ElectronNET/Electron.NET/commit/b8b634beb322a398e281ac3e358e835280bde356) update display.cs to current spec ### 📊 Changes **1 file changed** (+46 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.API/Entities/Display.cs` (+46 -6) </details> ### 📄 Description As you can see [here](https://www.electronjs.org/docs/latest/api/structures/display), the current Display.cs file in Electron.NET is not up to date. I've added all the missing fields (except for those which show up in the docs, but do not actually appear in the object we fetch from electron), and checked locally to see that it works. One thing to note is that I did not change the `Id` value from `string` to `int`, because that caused the `Electron.Screen.GetAllDisplaysAsync()` method to hang forever, and changing it also means breaking backwards compatibility. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:33 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1311