[PR #849] [MERGED] Get back net6 support #1321

New Issue

claunia · 2026-01-29T16:59:37Z

claunia commented

2026-01-29 16:59:37 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/849
Author: @gorsheninmv
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/1/2024
Merged by: @FlorianRappl

Base: develop ← Head: get-back-net6-support

📝 Commits (2)

0775b91 fix: get back net6 support
1864c21 fix: specify target framework

📊 Changes

4 files changed (+21 additions, -8 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -0)
📝 nuke/Build.cs (+17 -5)
📝 src/ElectronNET.API/ElectronNET.API.csproj (+1 -1)
📝 src/ElectronNET.CLI/ElectronNET.CLI.csproj (+1 -2)

📄 Description

.NET6 support is valid until November 12, 2024, more than half a year, I'm not sure this is a good idea to abandon .NET6 support in Electron.NET.

I would like to suggest making the project multitarget and support both LTS versions (.NET6 and .NET8)

dotnet tool doesn't support self-contaied tools (see https://github.com/dotnet/sdk/issues/9565), so that <PublishSelfContained>true</PublishSelfContained> can be useful only for binaries but not for dotnet tool so I decided to remove the line

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/849 **Author:** [@gorsheninmv](https://github.com/gorsheninmv) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/1/2024 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `develop` ← **Head:** `get-back-net6-support` --- ### 📝 Commits (2) - [`0775b91`](https://github.com/ElectronNET/Electron.NET/commit/0775b91dd4acaddab70fc1a020b6c5be7de2970e) fix: get back net6 support - [`1864c21`](https://github.com/ElectronNET/Electron.NET/commit/1864c21c109530839b595b0f024311c7750bfb5a) fix: specify target framework ### 📊 Changes **4 files changed** (+21 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -0) 📝 `nuke/Build.cs` (+17 -5) 📝 `src/ElectronNET.API/ElectronNET.API.csproj` (+1 -1) 📝 `src/ElectronNET.CLI/ElectronNET.CLI.csproj` (+1 -2) </details> ### 📄 Description .NET6 support is valid until [November 12, 2024](https://dotnet.microsoft.com/en-us/platform/support/policy), more than half a year, I'm not sure this is a good idea to abandon .NET6 support in Electron.NET. I would like to suggest making the project multitarget and support both LTS versions (.NET6 and .NET8) dotnet tool doesn't support self-contaied tools (see https://github.com/dotnet/sdk/issues/9565), so that `<PublishSelfContained>true</PublishSelfContained>` can be useful only for binaries but not for dotnet tool so I decided to remove the line --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:37 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1321