[PR #886] [CLOSED] Develop #1331

New Issue

claunia · 2026-01-29T16:59:42Z

claunia commented

2026-01-29 16:59:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/886
Author: @hmsun-es
Created: 8/4/2025
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (1)

7c9a7c3 Squashed commit of the following:

📊 Changes

4 files changed (+248 additions, -35 deletions)

View changed files

📝 src/ElectronNET.CLI/Commands/BuildCommand.cs (+127 -31)
📝 src/ElectronNET.CLI/Commands/StartElectronCommand.cs (+106 -0)
📝 src/ElectronNET.Host/build-helper.js (+14 -4)
📝 src/ElectronNET.WebApp/electron.manifest.json (+1 -0)

📄 Description

commit f69102e220628276806f0e8e01ab1ea483f80e3a
Author: Hyeonmin Seon hmsun.es@esgroup.net
Date: Mon Aug 4 09:20:53 2025 +0900

Changed the Electron version update method in C# and updated the version

Changes:
- Changed BuildCommand.cs to update the Electron version directly from C# code.
- StartElectronCommand.cs reads the Electron version from the manifest file and updates package.json.
- Removed the Electron version update logic from build-helper.js.
- Updated the Electron version in electron.manifest.json from 23.2.0 to 25.9.0.

commit 855e8306c8
Author: Hyeonmin Seon hmsun.es@esgroup.net
Date: Fri Aug 1 17:43:43 2025 +0900

Version Update: Changed to 23.6.2-messe

Changes:
* The value of the Version element has changed from 99.0.0.0 to 23.6.2-messe.
* The package version has been updated to reflect new features and fixes.

commit 498ab0a644
Author: Hyeonmin Seon hmsun.es@esgroup.net
Date: Fri Aug 1 17:37:16 2025 +0900

fix #767 - Added Electron version management and package.json updates.

* BuildCommand.cs now reads the Electron version from the manifest file and updates package.json.
* StartElectronCommand.cs now reads the electronicVersion from the manifest file and updates package.json.
* Improved package.json updates and JSON response direction in build-helper.js.
* Added the electronicVersion property to Electron.manifest.json.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/886 **Author:** [@hmsun-es](https://github.com/hmsun-es) **Created:** 8/4/2025 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (1) - [`7c9a7c3`](https://github.com/ElectronNET/Electron.NET/commit/7c9a7c3de2d4affb4580db59c49a68bd401f821c) Squashed commit of the following: ### 📊 Changes **4 files changed** (+248 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.CLI/Commands/BuildCommand.cs` (+127 -31) 📝 `src/ElectronNET.CLI/Commands/StartElectronCommand.cs` (+106 -0) 📝 `src/ElectronNET.Host/build-helper.js` (+14 -4) 📝 `src/ElectronNET.WebApp/electron.manifest.json` (+1 -0) </details> ### 📄 Description commit f69102e220628276806f0e8e01ab1ea483f80e3a Author: Hyeonmin Seon <hmsun.es@esgroup.net> Date: Mon Aug 4 09:20:53 2025 +0900 Changed the Electron version update method in C# and updated the version Changes: - Changed BuildCommand.cs to update the Electron version directly from C# code. - StartElectronCommand.cs reads the Electron version from the manifest file and updates package.json. - Removed the Electron version update logic from build-helper.js. - Updated the Electron version in electron.manifest.json from 23.2.0 to 25.9.0. commit 855e8306c852231e8ec6afd172fc01adf2683aef Author: Hyeonmin Seon <hmsun.es@esgroup.net> Date: Fri Aug 1 17:43:43 2025 +0900 Version Update: Changed to 23.6.2-messe Changes: * The value of the `Version` element has changed from `99.0.0.0` to `23.6.2-messe`. * The package version has been updated to reflect new features and fixes. commit 498ab0a6443d35560f164887a47fd05c6f6e6543 Author: Hyeonmin Seon <hmsun.es@esgroup.net> Date: Fri Aug 1 17:37:16 2025 +0900 fix #767 - Added Electron version management and package.json updates. * BuildCommand.cs now reads the Electron version from the manifest file and updates package.json. * StartElectronCommand.cs now reads the electronicVersion from the manifest file and updates package.json. * Improved package.json updates and JSON response direction in build-helper.js. * Added the electronicVersion property to Electron.manifest.json. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1331