[PR #885] [CLOSED] fix #767 - Added Electron version management and package.json updates. #1333

New Issue

claunia · 2026-01-29T16:59:42Z

claunia commented

2026-01-29 16:59:42 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/885
Author: @hmsun-es
Created: 8/1/2025
Status: ❌ Closed

Base: main ← Head: develop

📝 Commits (2)

498ab0a fix #767 - Added Electron version management and package.json updates.
855e830 버전 업데이트: 23.6.2-messe로 변경

📊 Changes

5 files changed (+103 additions, -26 deletions)

View changed files

📝 src/ElectronNET.CLI/Commands/BuildCommand.cs (+62 -17)
📝 src/ElectronNET.CLI/Commands/StartElectronCommand.cs (+11 -0)
📝 src/ElectronNET.CLI/ElectronNET.CLI.csproj (+1 -1)
📝 src/ElectronNET.Host/build-helper.js (+28 -8)
📝 src/ElectronNET.WebApp/electron.manifest.json (+1 -0)

📄 Description

BuildCommand.cs now reads the Electron version from the manifest file and updates package.json.
StartElectronCommand.cs now reads the electronicVersion from the manifest file and updates package.json.
Improved package.json updates and JSON response direction in build-helper.js.
Added the electronicVersion property to Electron.manifest.json.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/885 **Author:** [@hmsun-es](https://github.com/hmsun-es) **Created:** 8/1/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `develop` --- ### 📝 Commits (2) - [`498ab0a`](https://github.com/ElectronNET/Electron.NET/commit/498ab0a6443d35560f164887a47fd05c6f6e6543) fix #767 - Added Electron version management and package.json updates. - [`855e830`](https://github.com/ElectronNET/Electron.NET/commit/855e8306c852231e8ec6afd172fc01adf2683aef) 버전 업데이트: 23.6.2-messe로 변경 ### 📊 Changes **5 files changed** (+103 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.CLI/Commands/BuildCommand.cs` (+62 -17) 📝 `src/ElectronNET.CLI/Commands/StartElectronCommand.cs` (+11 -0) 📝 `src/ElectronNET.CLI/ElectronNET.CLI.csproj` (+1 -1) 📝 `src/ElectronNET.Host/build-helper.js` (+28 -8) 📝 `src/ElectronNET.WebApp/electron.manifest.json` (+1 -0) </details> ### 📄 Description * BuildCommand.cs now reads the Electron version from the manifest file and updates package.json. * StartElectronCommand.cs now reads the electronicVersion from the manifest file and updates package.json. * Improved package.json updates and JSON response direction in build-helper.js. * Added the electronicVersion property to Electron.manifest.json. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:42 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1333