[PR #911] [MERGED] feat: updated 'TitleBarOverlay' property to be passed as object #1347

New Issue

claunia · 2026-01-29T16:59:49Z

claunia commented

2026-01-29 16:59:49 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/911
Author: @Denny09310
Created: 11/8/2025
Status: ✅ Merged
Merged: 11/8/2025
Merged by: @FlorianRappl

Base: develop ← Head: develop

📝 Commits (6)

7927a95 feat: enhance titleBarOverlay to accept both a boolean and an object
21ae89b fix: missing public constructor
d79b73e fix: using newtonsoft.json instead of system.text.json for the converter
14962e1 chore: updated documentation
c0e7119 fix: don't write anything if value is null
9bb7dcf fix: added WriteUndefined as there is Newtonsoft.Json

📊 Changes

8 files changed (+80 additions, -8 deletions)

View changed files

📝 src/ElectronNET.API/API/Entities/BrowserWindowOptions.cs (+11 -4)
➕ src/ElectronNET.API/API/Entities/TitleBarOverlay.cs (+22 -0)
➕ src/ElectronNET.API/Converter/TitleBarOverlayConverter.cs (+43 -0)
📝 src/ElectronNET.Host/api/app.js.map (+1 -1)
📝 src/ElectronNET.Host/api/autoUpdater.js.map (+1 -1)
📝 src/ElectronNET.Host/api/nativeTheme.js.map (+1 -1)
📝 src/ElectronNET.Host/api/process.js.map (+1 -1)
📝 src/ElectronNET/build/ElectronNET.Build.dll (+0 -0)

📄 Description

I’ve updated the configuration to allow titleBarOptions to be passed either as an object or a boolean, in line with the Electron documentation. I did some quick testing and it appears to be working correctly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/911 **Author:** [@Denny09310](https://github.com/Denny09310) **Created:** 11/8/2025 **Status:** ✅ Merged **Merged:** 11/8/2025 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (6) - [`7927a95`](https://github.com/ElectronNET/Electron.NET/commit/7927a95cb8371ea0d704d19b952046ed0f231953) feat: enhance titleBarOverlay to accept both a boolean and an object - [`21ae89b`](https://github.com/ElectronNET/Electron.NET/commit/21ae89bc70287b54ee50d1ee551a7f27db9a0da3) fix: missing public constructor - [`d79b73e`](https://github.com/ElectronNET/Electron.NET/commit/d79b73e96014ca6bfee0da6947e9c8540657c211) fix: using newtonsoft.json instead of system.text.json for the converter - [`14962e1`](https://github.com/ElectronNET/Electron.NET/commit/14962e1983d93f596ac0aa50153169196cf5a16f) chore: updated documentation - [`c0e7119`](https://github.com/ElectronNET/Electron.NET/commit/c0e711940de7bc79719348e0c517bf89ff34149a) fix: don't write anything if value is null - [`9bb7dcf`](https://github.com/ElectronNET/Electron.NET/commit/9bb7dcfa6286d85e4fd06e3e155cc72899100c28) fix: added WriteUndefined as there is Newtonsoft.Json ### 📊 Changes **8 files changed** (+80 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.API/API/Entities/BrowserWindowOptions.cs` (+11 -4) ➕ `src/ElectronNET.API/API/Entities/TitleBarOverlay.cs` (+22 -0) ➕ `src/ElectronNET.API/Converter/TitleBarOverlayConverter.cs` (+43 -0) 📝 `src/ElectronNET.Host/api/app.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/autoUpdater.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/nativeTheme.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/process.js.map` (+1 -1) 📝 `src/ElectronNET/build/ElectronNET.Build.dll` (+0 -0) </details> ### 📄 Description I’ve updated the configuration to allow titleBarOptions to be passed either as an object or a boolean, in line with the Electron documentation. I did some quick testing and it appears to be working correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:49 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1347