starred/Electron.NET
1
0
Fork 0
mirror of https://github.com/ElectronNET/Electron.NET.git synced 2026-02-03 21:25:13 +00:00
Code Issues 668 Packages Projects Releases 20 Wiki Activity

[PR #913] [MERGED] Add 77 IntegrationTests and lots of fixes #1351

New Issue
Open
opened 2026-01-29 16:59:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:59:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/913
Author: @softworkz
Created: 11/9/2025
Status: ✅ Merged
Merged: 11/9/2025
Merged by: @FlorianRappl

Base: develop ← Head: submit_tests_fixes

📝 Commits (10+)

  • c5fb5f6 Add IntegrationTests project
  • ed7cc43 browserWindowSetParentWindow: Support null parameter
  • 402147b BrowserWindow: Disable SetPosition 'workaround'
  • 95fd7aa ApiBase: fix event names for App
  • bc0f601 ProcessMetric: Fix deserialization error for CreationTime
  • 4129cc1 main.js: Load api/process import (was missing)
  • 0421095 webContents.ts: Fix clearAuthCache invocation
  • dd465ba notification.ts: Fix notificationIsSupported
  • dc27511 browserWindows.ts: Add catch for Set/GetRepresentedFilename
  • 8dcc372 browserWindows.ts: Fix SetThumbarButtons

📊 Changes

46 files changed (+1599 additions, -64 deletions)

View changed files

📝 src/ElectronNET.API/API/ApiBase.cs (+21 -2)
📝 src/ElectronNET.API/API/App.cs (+15 -2)
📝 src/ElectronNET.API/API/BrowserView.cs (+7 -7)
📝 src/ElectronNET.API/API/BrowserWindow.cs (+20 -12)
📝 src/ElectronNET.API/API/Entities/Cookie.cs (+8 -6)
📝 src/ElectronNET.API/API/Entities/ProcessMetric.cs (+3 -5)
📝 src/ElectronNET.API/Runtime/Services/SocketBridge/SocketBridgeService.cs (+4 -1)
📝 src/ElectronNET.API/Runtime/StartupManager.cs (+14 -2)
📝 src/ElectronNET.Host/api/browserWindows.js (+41 -5)
📝 src/ElectronNET.Host/api/browserWindows.js.map (+1 -1)
📝 src/ElectronNET.Host/api/browserWindows.ts (+38 -7)
📝 src/ElectronNET.Host/api/ipc.js (+25 -0)
📝 src/ElectronNET.Host/api/ipc.js.map (+1 -1)
📝 src/ElectronNET.Host/api/ipc.ts (+25 -1)
📝 src/ElectronNET.Host/api/notification.js (+1 -1)
📝 src/ElectronNET.Host/api/notification.js.map (+1 -1)
📝 src/ElectronNET.Host/api/notification.ts (+1 -1)
📝 src/ElectronNET.Host/api/webContents.js (+23 -3)
📝 src/ElectronNET.Host/api/webContents.js.map (+1 -1)
📝 src/ElectronNET.Host/api/webContents.ts (+20 -4)

...and 26 more files

📄 Description

  • StartupManager: Add support for running under testhost
  • BrowserView.cs: Fix cast exception in Bounds property getter
  • App.cs: Fix UserAgentFallbackAsync
  • ipc.ts: Add helper method for tests
  • browserWindows.ts: Fix SetThumbarButtons
  • browserWindows.ts: Add catch for Set/GetRepresentedFilename...
  • notification.ts: Fix notificationIsSupported...
  • webContents.ts: Fix clearAuthCache invocation...
  • main.js: Load api/process import (was missing)
  • ProcessMetric: Fix deserialization error for CreationTime
  • ApiBase: fix event names for App
  • BrowserWindow: Disable SetPosition 'workaround'...
  • browserWindowSetParentWindow: Support null parameter
  • Add IntegrationTests project

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/913 **Author:** [@softworkz](https://github.com/softworkz) **Created:** 11/9/2025 **Status:** ✅ Merged **Merged:** 11/9/2025 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `develop` ← **Head:** `submit_tests_fixes` --- ### 📝 Commits (10+) - [`c5fb5f6`](https://github.com/ElectronNET/Electron.NET/commit/c5fb5f62d9777d1cbabea1ee198e07f6f7a4e33e) Add IntegrationTests project - [`ed7cc43`](https://github.com/ElectronNET/Electron.NET/commit/ed7cc434eafd273f500de4fe73b81f43582b7d33) browserWindowSetParentWindow: Support null parameter - [`402147b`](https://github.com/ElectronNET/Electron.NET/commit/402147b8eff861978bca6f45be3958b55a9892d9) BrowserWindow: Disable SetPosition 'workaround' - [`95fd7aa`](https://github.com/ElectronNET/Electron.NET/commit/95fd7aa6659c519694e4f0cee850c845289a6d93) ApiBase: fix event names for App - [`bc0f601`](https://github.com/ElectronNET/Electron.NET/commit/bc0f601dd87c8718923ee95502f49dd4240b4c42) ProcessMetric: Fix deserialization error for CreationTime - [`4129cc1`](https://github.com/ElectronNET/Electron.NET/commit/4129cc17a6d69051ec34ddf703cfa7989d3277b5) main.js: Load api/process import (was missing) - [`0421095`](https://github.com/ElectronNET/Electron.NET/commit/04210955a38e90a5dfa1f94fa1895b9448675a9d) webContents.ts: Fix clearAuthCache invocation - [`dd465ba`](https://github.com/ElectronNET/Electron.NET/commit/dd465baebf76f1f5d3076980e4498e5475742ff4) notification.ts: Fix notificationIsSupported - [`dc27511`](https://github.com/ElectronNET/Electron.NET/commit/dc27511aa52158b0ab99f539580eef4e2415c49b) browserWindows.ts: Add catch for Set/GetRepresentedFilename - [`8dcc372`](https://github.com/ElectronNET/Electron.NET/commit/8dcc3721ebf09910344c4e1ab6fcd34334f12863) browserWindows.ts: Fix SetThumbarButtons ### 📊 Changes **46 files changed** (+1599 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.API/API/ApiBase.cs` (+21 -2) 📝 `src/ElectronNET.API/API/App.cs` (+15 -2) 📝 `src/ElectronNET.API/API/BrowserView.cs` (+7 -7) 📝 `src/ElectronNET.API/API/BrowserWindow.cs` (+20 -12) 📝 `src/ElectronNET.API/API/Entities/Cookie.cs` (+8 -6) 📝 `src/ElectronNET.API/API/Entities/ProcessMetric.cs` (+3 -5) 📝 `src/ElectronNET.API/Runtime/Services/SocketBridge/SocketBridgeService.cs` (+4 -1) 📝 `src/ElectronNET.API/Runtime/StartupManager.cs` (+14 -2) 📝 `src/ElectronNET.Host/api/browserWindows.js` (+41 -5) 📝 `src/ElectronNET.Host/api/browserWindows.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/browserWindows.ts` (+38 -7) 📝 `src/ElectronNET.Host/api/ipc.js` (+25 -0) 📝 `src/ElectronNET.Host/api/ipc.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/ipc.ts` (+25 -1) 📝 `src/ElectronNET.Host/api/notification.js` (+1 -1) 📝 `src/ElectronNET.Host/api/notification.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/notification.ts` (+1 -1) 📝 `src/ElectronNET.Host/api/webContents.js` (+23 -3) 📝 `src/ElectronNET.Host/api/webContents.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/webContents.ts` (+20 -4) _...and 26 more files_ </details> ### 📄 Description - StartupManager: Add support for running under testhost - BrowserView.cs: Fix cast exception in Bounds property getter - App.cs: Fix UserAgentFallbackAsync - ipc.ts: Add helper method for tests - browserWindows.ts: Fix SetThumbarButtons - browserWindows.ts: Add catch for Set/GetRepresentedFilename... - notification.ts: Fix notificationIsSupported... - webContents.ts: Fix clearAuthCache invocation... - main.js: Load api/process import (was missing) - ProcessMetric: Fix deserialization error for CreationTime - ApiBase: fix event names for App - BrowserWindow: Disable SetPosition 'workaround'... - browserWindowSetParentWindow: Support null parameter - Add IntegrationTests project --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:59:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
api
applications
bug
bug
dev-experience
discussion
documentation
duplicate
enhancement
examples
Feature
Feature
good first issue
help wanted
In progress
information
infrastructure
invalid
javascript
macos
more-information-needed
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Electron.NET#1351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?