[PR #922] [MERGED] Fix sendToIpcRenderer parameter handling #1356

New Issue

claunia · 2026-01-29T16:59:55Z

claunia commented

2026-01-29 16:59:55 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/922
Author: @softworkz
Created: 11/11/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @FlorianRappl

Base: develop ← Head: submit_fix_ipc_params

📝 Commits (1)

12d2fcb Fix sendToIpcRenderer parameter handling

📊 Changes

3 files changed (+5 additions, -5 deletions)

View changed files

📝 src/ElectronNET.Host/api/ipc.js (+2 -2)
📝 src/ElectronNET.Host/api/ipc.js.map (+1 -1)
📝 src/ElectronNET.Host/api/ipc.ts (+2 -2)

📄 Description

The spread operator must not be used for the data parameter because the params are provided by data as an array and not as function arguments (which the spread operator would collect).
The way it was caused the data parameter to be wrapped in an array once again (n-size data array wrapped inside a single-element array), so the later spread operator unpacks the outer array instead of spreading out the data array as multiple parameters.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/922 **Author:** [@softworkz](https://github.com/softworkz) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@FlorianRappl](https://github.com/FlorianRappl) **Base:** `develop` ← **Head:** `submit_fix_ipc_params` --- ### 📝 Commits (1) - [`12d2fcb`](https://github.com/ElectronNET/Electron.NET/commit/12d2fcb484da330aebc4dd2ce686d59253af1f96) Fix sendToIpcRenderer parameter handling ### 📊 Changes **3 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/ElectronNET.Host/api/ipc.js` (+2 -2) 📝 `src/ElectronNET.Host/api/ipc.js.map` (+1 -1) 📝 `src/ElectronNET.Host/api/ipc.ts` (+2 -2) </details> ### 📄 Description The spread operator must not be used for the data parameter because the params are provided by data as an array and not as function arguments (which the spread operator would collect). The way it was caused the data parameter to be wrapped in an array once again (n-size data array wrapped inside a single-element array), so the later spread operator unpacks the outer array instead of spreading out the data array as multiple parameters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:59:55 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1356